@@ -14,13 +14,13 @@

 Name:           libosmocore

 Requires: osmocom-master

-Version: 1.9.0.122.0265

+Version: 1.9.0.128.85554

 Release:        0

 Summary:        The Open Source Mobile Communications Core Library

 License:        GPL-2.0-only AND GPL-2.0-or-later AND LGPL-2.1-or-later AND AGPL-3.0-or-later

 Group:          Productivity/Telephony/Utilities

 Url:            https://osmocom.org/projects/libosmocore/wiki/Libosmocore

-Source: libosmocore_1.9.0.122.0265.tar.xz

+Source: libosmocore_1.9.0.128.85554.tar.xz

 Source1: rpmlintrc

 BuildRequires:  automake >= 1.6

 BuildRequires:  libtool >= 2

​

@@ -2,7 +2,7 @@

 Source: libosmocore

 Binary: libosmocore, libosmocodec4, libosmocodec-doc, libosmocoding0, libosmocoding-doc, libosmocore21, libosmocore-doc, libosmogb14, libosmogb-doc, libosmogsm20, libosmogsm-doc, libosmoisdn0, libosmoisdn-doc, libosmovty13, libosmovty-doc, libosmoctrl0, libosmoctrl-doc, libosmosim2, libosmosim-doc, libosmousb0, libosmousb-doc, libosmocore-dev, libosmocore-utils, libosmocore-dbg

 Architecture: any all

-Version: 1.9.0.122.0265

+Version: 1.9.0.128.85554

 Maintainer: Osmocom team <openbsc@lists.osmocom.org>

 Homepage: https://projects.osmocom.org/projects/libosmocore

 Standards-Version: 3.9.8

@@ -35,8 +35,8 @@

  libosmovty-doc deb doc optional arch=all

  libosmovty13 deb libs optional arch=any

 Checksums-Sha1:

- 7fcc118feaccc3cc79e0403eace56d95482b1f36 1093340 libosmocore_1.9.0.122.0265.tar.xz

+ 24b95fc04624c4d06b3bb31ac7859fcba509b0a5 1102136 libosmocore_1.9.0.128.85554.tar.xz

 Checksums-Sha256:

- 5e47285cc2b994bd129fcb2aeaef2a733fea8c4b6752a674e2946ca8f11fb42a 1093340 libosmocore_1.9.0.122.0265.tar.xz

+ b31e068f93c2872c3673bcc8cf9e3cc6b74b28ccd38bdfadb3d460efb6554e70 1102136 libosmocore_1.9.0.128.85554.tar.xz

 Files:

- 88870f3e8548ab0f8395044343ab3def 1093340 libosmocore_1.9.0.122.0265.tar.xz

+ 8632a014ac798cf2e443994102ae4666 1102136 libosmocore_1.9.0.128.85554.tar.xz

​

@@ -1 +1 @@

-1.9.0.122-0265

+1.9.0.128-85554

​

@@ -11,6 +11,8 @@

 core      ADD       osmo_sock_multiaddr_get_ip_and_port(), osmo_multiaddr_ip_and_port_snprintf(), osmo_sock_multiaddr_get_name_buf()

 core      ADD       osmo_sock_sctp_get_peer_addr_info()

 core      ADD       gsmtap_inst_fd2() core, DEPRECATE gsmtap_inst_fd()

+core       behavior change     osmo_tdef_fsm_inst_state_chg(): allow millisecond precision

 isdn       ABI change      add states and flags for external T200 handling

+isdn      ADD              initial implementation of the V.110 Terminal Adapter

 gsm        ABI change      add T200 timer states to lapdm_datalink

 gsm        ABI change      add UI queue to struct lapdm_datalink

​

@@ -1,8 +1,8 @@

-libosmocore (1.9.0.122.0265) unstable; urgency=medium

+libosmocore (1.9.0.128.85554) unstable; urgency=medium

   * Automatically generated changelog entry for building the Osmocom master feed

- -- Osmocom OBS scripts <info@osmocom.org>  Fri, 05 Jan 2024 15:42:18 +0000

+ -- Osmocom OBS scripts <info@osmocom.org>  Tue, 09 Jan 2024 13:13:51 +0000

 libosmocore (1.9.0) unstable; urgency=medium

​

@@ -200,7 +200,7 @@

                fmt, ## args)

 #define OSMO_T_FMT "%c%u"

-#define OSMO_T_FMT_ARGS(T) ((T) >= 0 ? 'T' : 'X'), ((T) >= 0 ? T : -T)

+#define OSMO_T_FMT_ARGS(T) ((T) >= 0 ? 'T' : 'X'), ((T) >= 0 ? (T) : -(T))

 int osmo_fsm_register(struct osmo_fsm *fsm);

 void osmo_fsm_unregister(struct osmo_fsm *fsm);

​

@@ -121,11 +121,13 @@

 const struct osmo_tdef_state_timeout *osmo_tdef_get_state_timeout(uint32_t state,

                                  const struct osmo_tdef_state_timeout *timeouts_array);

-/*! Call osmo_fsm_inst_state_chg() or osmo_fsm_inst_state_chg_keep_timer(), depending on the timeouts_array, tdefs and

- * default_timeout.

+/*! Call osmo_fsm_inst_state_chg_ms() or osmo_fsm_inst_state_chg_keep_timer_ms(),

+ * depending on the timeouts_array, tdefs and default_timeout.

  *

- * A T timer configured in sub-second precision is rounded up to the next full second. A timer in unit =

- * OSMO_TDEF_CUSTOM is applied as if the unit is in seconds (i.e. this macro does not make sense for custom units!).

+ * A timer defined with sub-millisecond precision (e.g OSMO_TDEF_US) is rounded up to the next full millisecond.

+ * A timer value defined in units higher than millisecond (e.g. OSMO_TDEF_S, OSMO_TDEF_M) is converted to milliseconds.

+ * A timer in unit = OSMO_TDEF_CUSTOM is applied as if the unit is in seconds (i.e. this macro does not make sense

+ * for custom units!).

  *

  * See osmo_tdef_get_state_timeout() and osmo_tdef_get().

  *

@@ -153,9 +155,10 @@

  * \paramin state  State number to transition to.

  * \paramin timeouts_array  Array of struct osmo_tdef_state_timeout32 to look up state in.

  * \paramin tdefs  Array of struct osmo_tdef (last entry zero initialized) to look up T in.

- * \paramin default_timeout  If a T is set in timeouts_array, but no timeout value is configured for T, then use this

- *                             default timeout value as fallback, or pass -1 to abort the program.

- * \return Return value from osmo_fsm_inst_state_chg() or osmo_fsm_inst_state_chg_keep_timer().

+ * \paramin default_timeout  If a T is set in timeouts_array, but no timeout value is configured for T,

+ *                             then use this default timeout value (in seconds) as fallback,

+ *                             or pass a negative number to abort the program.

+ * \return Return value from osmo_fsm_inst_state_chg_ms() or osmo_fsm_inst_state_chg_keep_timer_ms().

  */

 #define osmo_tdef_fsm_inst_state_chg(fi, state, timeouts_array, tdefs, default_timeout) \

    _osmo_tdef_fsm_inst_state_chg(fi, state, timeouts_array, tdefs, default_timeout, \

​

@@ -2,6 +2,7 @@

    i460_mux.h \

    lapd_core.h \

    v110.h \

+   v110_ta.h \

    $(NULL)

 osmoisdndir = $(includedir)/osmocom/isdn

​

@@ -0,0 +1,113 @@

+#pragma once

+

+#include <stdint.h>

+#include <stdbool.h>

+

+#include <osmocom/core/utils.h>

+#include <osmocom/core/bits.h>

+#include <osmocom/isdn/v110.h>

+

+/* Definition of this struct is intentionally kept private */

+struct osmo_v110_ta;

+

+/*! V.110 5.4.1 Local flow control (DTE-DCE or TE-TA) mode */

+enum osmo_v110_local_flow_ctrl_mode {

+   OSMO_V110_LOCAL_FLOW_CTRL_NONE,     /*!< No local flow control */

+   OSMO_V110_LOCAL_FLOW_CTRL_133_106,  /*!< 5.4.1.1 133/106 operation */

+   OSMO_V110_LOCAL_FLOW_CTRL_105_106,  /*!< 5.4.1.2 105/106 operation */

+   OSMO_V110_LOCAL_FLOW_CTRL_XON_XOFF, /*!< 5.4.1.3 XON/XOFF operation */

+};

+

+/*! Configuration for a V.110 TA instance */

+struct osmo_v110_ta_cfg {

+   /*! Configuration flags (behavior switches and quirks) */

+   unsigned int flags;

+   /*! Synchronous user rate */

+   enum osmo_v100_sync_ra1_rate rate;

+

+   /*! Flow control configuration */

+   struct {

+       /*! Local TA-TE (DTE-DCE) flow control mode */

+       enum osmo_v110_local_flow_ctrl_mode local;

+       /*! End-to-end (TA-to-TA) flow control state */

+       bool end_to_end;

+   } flow_ctrl;

+

+   /*! Opaque application-private data; passed to call-backs. */

+   void *priv;

+

+   /*! Receive call-back of the application.

+    * \paramin priv opaque application-private data.

+    * \paramin buf output buffer for writing to be transmitted data.

+    * \paramin buf_size size of the output buffer. */

+   void (*rx_cb)(void *priv, const ubit_t *buf, size_t buf_size);

+

+   /*! Transmit call-back of the application.

+    * \paramin priv opaque application-private data.

+    * \paramout buf output buffer for writing to be transmitted data.

+    * \paramin buf_size size of the output buffer. */

+   void (*tx_cb)(void *priv, ubit_t *buf, size_t buf_size);

+

+   /*! Modem status line update call-back (optional).

+    * \paramin priv opaque application-private data.

+    * \paramin status updated status; bit-mask of OSMO_V110_TA_C_*. */

+   void (*status_update_cb)(void *priv, unsigned int status);

+};

+

+struct osmo_v110_ta *osmo_v110_ta_alloc(void *ctx, const char *name,

+                   const struct osmo_v110_ta_cfg *cfg);

+void osmo_v110_ta_free(struct osmo_v110_ta *ta);

+

+/*! Various timers for a V.110 TA instance */

+enum osmo_v110_ta_timer {

+   /*! 7.1.5 Loss of frame synchronization: sync recovery timer.

+    * T-number is not assigned in V.110, so we call it X1. */

+   OSMO_V110_TA_TIMER_X1       = -1,

+   /*! 7.1.2 Connect TA to line: sync establishment timer */

+   OSMO_V110_TA_TIMER_T1       = 1,

+   /*! 7.1.4 Disconnect mode: disconnect confirmation timer */

+   OSMO_V110_TA_TIMER_T2       = 2,

+};

+

+int osmo_v110_ta_set_timer_val_ms(struct osmo_v110_ta *ta,

+                 enum osmo_v110_ta_timer timer,

+                 unsigned long val_ms);

+

+int osmo_v110_ta_frame_in(struct osmo_v110_ta *ta, const struct osmo_v110_decoded_frame *in);

+int osmo_v110_ta_frame_out(struct osmo_v110_ta *ta, struct osmo_v110_decoded_frame *out);

+

+int osmo_v110_ta_sync_ind(struct osmo_v110_ta *ta);

+int osmo_v110_ta_desync_ind(struct osmo_v110_ta *ta);

+

+/*! ITU-T Table 9 "Interchange circuit" (see also ITU-T V.24 Chapter 3).

+ * XXX: Not all circuits are present here, only those which we actually use.

+ * TODO: add human-friendly abbreviated circuit names. */

+enum osmo_v110_ta_circuit {

+   OSMO_V110_TA_C_105,     /*!< DTE->DCE | RTS (Request to Send) */

+   OSMO_V110_TA_C_106,     /*!< DTE<-DCE | CTS (Clear to Send) */

+   OSMO_V110_TA_C_107,     /*!< DTE<-DCE | DSR (Data Set Ready) */

+   OSMO_V110_TA_C_108,     /*!< DTE->DCE | DTR (Data Terminal Ready) */

+   OSMO_V110_TA_C_109,     /*!< DTE<-DCE | DCD (Data Carrier Detect) */

+   OSMO_V110_TA_C_133,     /*!< DTE->DCE | Ready for receiving */

+};

+

+extern const struct value_string osmo_v110_ta_circuit_names;

+extern const struct value_string osmo_v110_ta_circuit_descs;

+

+/*! Get a short name of the given TA's circuit (format: NNN/ABBR). */

+static inline const char *osmo_v110_ta_circuit_name(enum osmo_v110_ta_circuit circuit)

+{

+   return get_value_string(osmo_v110_ta_circuit_names, circuit);

+}

+

+/*! Get a brief description of the given TA's circuit. */

+static inline const char *osmo_v110_ta_circuit_desc(enum osmo_v110_ta_circuit circuit)

+{

+   return get_value_string(osmo_v110_ta_circuit_descs, circuit);

+}

+

+unsigned int osmo_v110_ta_get_status(const struct osmo_v110_ta *ta);

+bool osmo_v110_ta_get_circuit(const struct osmo_v110_ta *ta,

+                 enum osmo_v110_ta_circuit circuit);

+int osmo_v110_ta_set_circuit(struct osmo_v110_ta *ta,

+                enum osmo_v110_ta_circuit circuit, bool active);

​

@@ -337,26 +337,37 @@

                  const char *file, int line)

 {

    const struct osmo_tdef_state_timeout *t = osmo_tdef_get_state_timeout(state, timeouts_array);

-   unsigned long val = 0;

+   unsigned long val_ms = 0;

    /* No timeout defined for this state? */

    if (!t)

        return _osmo_fsm_inst_state_chg(fi, state, 0, 0, file, line);

-   if (t->T)

-       val = osmo_tdef_get(tdefs, t->T, OSMO_TDEF_S, default_timeout);

+   if (t->T) {

+       const struct osmo_tdef *tdef = osmo_tdef_get_entry((struct osmo_tdef *)tdefs, t->T);

+       if (tdef == NULL) {

+           /* emulate the old behavior: treat default_timeout as OSMO_TDEF_S */

+           OSMO_ASSERT(default_timeout >= 0);

+           val_ms = default_timeout * 1000;

+       } else {

+           val_ms = osmo_tdef_round(tdef->val, tdef->unit, OSMO_TDEF_MS);

+           /* emulate the old behavior: treat OSMO_TDEF_CUSTOM as OSMO_TDEF_S */

+           if (tdef->unit == OSMO_TDEF_CUSTOM)

+               val_ms *= 1000;

+       }

+   }

    if (t->keep_timer) {

        if (t->T)

-           return _osmo_fsm_inst_state_chg_keep_or_start_timer(fi, state, val, t->T, file, line);

+           return _osmo_fsm_inst_state_chg_keep_or_start_timer_ms(fi, state, val_ms, t->T, file, line);

        else

            return _osmo_fsm_inst_state_chg_keep_timer(fi, state, file, line);

    }

-   /* val is always initialized here, because if t->keep_timer is false, t->T must be != 0.

+   /* val_ms is always initialized here, because if t->keep_timer is false, t->T must be != 0.

     * Otherwise osmo_tdef_get_state_timeout() would have returned NULL. */

    OSMO_ASSERT(t->T);

-   return _osmo_fsm_inst_state_chg(fi, state, val, t->T, file, line);

+   return _osmo_fsm_inst_state_chg_ms(fi, state, val_ms, t->T, file, line);

 }

 const struct value_string osmo_tdef_unit_names = {

​

@@ -641,8 +641,10 @@

    char *str = NULL; /* initialize to avoid uninitialized false warnings on some gcc versions (11.1.0) */

    size_t str_size = 0; /* initialize to avoid uninitialized false warnings on some gcc versions (11.1.0) */

-   if (!mi_data || mi_len < 1)

-       return -EBADMSG;

+   if (!mi_data || mi_len < 1) {

+       rc = -EBADMSG;

+       goto return_error;

+   }

    nibbles_len = (mi_len - 1) * 2 + ((mi_data0 & GSM_MI_ODD) ? 1 : 0);

​

@@ -44,10 +44,11 @@

 };

 /*! Like gsm48_decode_bcd_number2() but with less airtight bounds checking.

- *  \paramout Caller-provided output buffer

+ *  \paramout output Caller-provided output buffer

+ *  \paramin output_len sizeof(output)

  *  \paramin bcd_lv Length-Value portion of to-be-decoded IE

  *  \paramin h_len Length of an optional heder between L and V portion

- *  \returns - in case of success; negative on error */

+ *  \returns 0 in case of success; negative on error */

 int gsm48_decode_bcd_number(char *output, int output_len,

                const uint8_t *bcd_lv, int h_len)

 {

@@ -139,7 +140,7 @@

  *  \paramin max_len Maximum Length of \a bcd_lv

  *  \paramin h_len Length of an optional heder between L and V portion

  *  \paramin input phone number as 0-terminated ASCII

- *  \returns number of bytes used in \a bcd_lv

+ *  \returns number of bytes used in \a bcd_lv; negative on error

  *

  * Depending on a context (e.g. called or calling party BCD number), the

  * optional header between L and V parts can contain TON (Type Of Number),

@@ -179,8 +180,8 @@

 }

 /*! Decode TS 04.08 Bearer Capability IE (10.5.4.5)

- *  \paramout Caller-provided memory for decoded output

- *  \aramin LV portion of TS 04.08 Bearer Capability

+ *  \paramout bcap Caller-provided memory for decoded output

+ *  \paramin lv LV portion of TS 04.08 Bearer Capability

  *  \returns 0 on success; negative on error */

 int gsm48_decode_bearer_cap(struct gsm_mncc_bearer_cap *bcap,

                 const uint8_t *lv)

@@ -371,7 +372,7 @@

 }

 /*! Decode TS 04.08 Call Control Capabilities IE (10.5.4.5a)

- *  \paramout Caller-provided memory for decoded CC capabilities

+ *  \paramout ccap Caller-provided memory for decoded CC capabilities

  *  \paramin lv Length-Value of IE

  *  \returns 0 on success; negative on error */

 int gsm48_decode_cccap(struct gsm_mncc_cccap *ccap, const uint8_t *lv)

@@ -457,7 +458,7 @@

 }

 /*! Decode TS 04.08 Caller ID

- *  \paramout called Caller-provided memory for decoded number

+ *  \paramout callerid Caller-provided memory for decoded number

  *  \paramin lv Length-Value portion of IE

  *  \returns 0 on success; negative on error */

 int gsm48_decode_callerid(struct gsm_mncc_number *callerid,

​

@@ -13,7 +13,7 @@

 noinst_LTLIBRARIES = libisdnint.la

 lib_LTLIBRARIES = libosmoisdn.la

-libisdnint_la_SOURCES = i460_mux.c lapd_core.c v110.c

+libisdnint_la_SOURCES = i460_mux.c lapd_core.c v110.c v110_ta.c

 libisdnint_la_LDFLAGS = -no-undefined

 libisdnint_la_LIBADD = $(top_builddir)/src/core/libosmocore.la

​

@@ -33,5 +33,19 @@

 osmo_v110_sync_ra1_user_to_ir;

 osmo_v110_sync_ra1_ir_to_user;

+osmo_v110_ta_alloc;

+osmo_v110_ta_free;

+osmo_v110_ta_set_timer_val_ms;

+osmo_v110_ta_frame_in;

+osmo_v110_ta_frame_out;

+osmo_v110_ta_sync_ind;

+osmo_v110_ta_desync_ind;

+osmo_v110_ta_get_status;

+osmo_v110_ta_get_circuit;

+osmo_v110_ta_set_circuit;

+

+osmo_v110_ta_circuit_names;

+osmo_v110_ta_circuit_descs;

+

 local: *;

 };

​

@@ -0,0 +1,872 @@

+/*! \file v110_ta.c

+ *  TA (Terminal Adapter) implementation as per ITU-T V.110. */

+/*

+ * (C) 2022 by Harald Welte <laforge@gnumonks.org>

+ * (C) 2023 by sysmocom - s.f.m.c. GmbH <info@sysmocom.de>

+ *

+ * Initial (Work-in-Progress) implementation by Harald Welte,

+ * completed and co-authored by Vadim Yanitskiy.

+ *

+ * All Rights Reserved

+ *

+ * SPDX-License-Identifier: GPL-2.0+

+ *

+ * This program is free software; you can redistribute it and/or modify

+ * it under the terms of the GNU General Public License as published by

+ * the Free Software Foundation; either version 2 of the License, or

+ * (at your option) any later version.

+ *

+ * This program is distributed in the hope that it will be useful,

+ * but WITHOUT ANY WARRANTY; without even the implied warranty of

+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the

+ * GNU General Public License for more details.

+ *

+ */

+

+#include <stdbool.h>

+#include <stdint.h>

+#include <errno.h>

+

+#include <osmocom/core/logging.h>

+#include <osmocom/core/talloc.h>

+#include <osmocom/core/utils.h>

+#include <osmocom/core/bits.h>

+#include <osmocom/core/tdef.h>

+#include <osmocom/core/fsm.h>

+

+#include <osmocom/isdn/v110.h>

+#include <osmocom/isdn/v110_ta.h>

+

+#define S(x) (1 << (x))

+

+#define V24_FLAGMASK_IS_ON(flags, circuit) \

+   (((flags) & S(circuit)) != 0)

+

+#define V24_FLAGMASK_IS_OFF(flags, circuit) \

+   (((flags) & S(circuit)) == 0)

+

+#define V24_FLAGMASK_SET_ON(flags, circuit) \

+   (flags) |= S(circuit)

+

+#define V24_FLAGMASK_SET_OFF(flags, circuit) \

+   (flags) &= ~S(circuit)

+

+/* inverse logic: ON = binary 0; OFF = binary 1 */

+#define V110_SX_BIT_ON     0

+#define V110_SX_BIT_OFF        1

+

+const struct value_string osmo_v110_ta_circuit_names = {

+   { OSMO_V110_TA_C_105,   "105/RTS" },

+   { OSMO_V110_TA_C_106,   "106/CTS" },

+   { OSMO_V110_TA_C_107,   "107/DSR" },

+   { OSMO_V110_TA_C_108,   "108/DTR" },

+   { OSMO_V110_TA_C_109,   "109/DCD" },

+   { OSMO_V110_TA_C_133,   "133" },

+   { 0, NULL }

+};

+

+const struct value_string osmo_v110_ta_circuit_descs = {

+   { OSMO_V110_TA_C_105,   "Request to Send" },

+   { OSMO_V110_TA_C_106,   "Clear to Send" },

+   { OSMO_V110_TA_C_107,   "Data Set Ready" },

+   { OSMO_V110_TA_C_108,   "Data Terminal Ready" },

+   { OSMO_V110_TA_C_109,   "Data Carrier Detect" },

+   { OSMO_V110_TA_C_133,   "Ready for receiving" },

+   { 0, NULL }

+};

+

+static const struct osmo_tdef v110_ta_tdef = {

+   { .T = OSMO_V110_TA_TIMER_X1,

+     .unit = OSMO_TDEF_MS, .default_val = 3000, /* suggested in 7.1.5 e) */

+     .desc = "ITU-T V.110 7.1.5 Loss of frame synchronization: sync recovery timer" },

+   { .T = OSMO_V110_TA_TIMER_T1,

+     .unit = OSMO_TDEF_MS, .default_val = 10000, /* suggested in 7.1.2.2 */

+     .desc = "ITU-T V.110 7.1.2 Connect TA to line: sync establishment timer" },

+   { .T = OSMO_V110_TA_TIMER_T2,

+     .unit = OSMO_TDEF_MS, .default_val = 5000, /* suggested in 7.1.4.1 */

+     .desc = "ITU-T V.110 7.1.4 Disconnect mode: disconnect confirmation timer" },

+   { /* end of list */ }

+};

+

+/*********************************************************************************

+ * V.110 TERMINAL ADAPTER FSM

+ *********************************************************************************/

+

+enum v110_ta_fsm_state {

+   V110_TA_ST_IDLE_READY,      /* 7.1.1 Idle (or ready) state */

+   V110_TA_ST_CON_TA_TO_LINE,  /* 7.1.2 Connect TA to line state */

+   V110_TA_ST_DATA_TRANSFER,   /* 7.1.3 Data transfer state */

+   V110_TA_ST_DISCONNECTING,   /* 7.1.4 Disconnect mode */

+   V110_TA_ST_RESYNCING,       /* 7.1.5 Re-synchronizing state */

+};

+

+enum v110_ta_fsm_event {

+   V110_TA_EV_RX_FRAME_IND,    /* a V.110 frame was received by the lower layer */

+   V110_TA_EV_TX_FRAME_RTS,    /* a V.110 frame is to be sent by the lower layer */

+   V110_TA_EV_V24_STATUS_CHG,  /* V.24 flag-mask has been updated by TE */

+   V110_TA_EV_SYNC_IND,        /* the lower layer has synchronized to the frame clock */

+   V110_TA_EV_DESYNC_IND,      /* the lower layer has lost frame clock synchronization */

+   V110_TA_EV_TIMEOUT,     /* generic event for handling a timeout condition */

+};

+

+static const struct value_string v110_ta_fsm_event_names = {

+   { V110_TA_EV_RX_FRAME_IND,  "RX_FRAME_IND" },

+   { V110_TA_EV_TX_FRAME_RTS,  "TX_FRAME_RTS" },

+   { V110_TA_EV_V24_STATUS_CHG,    "V24_STATUS_CHG" },

+   { V110_TA_EV_SYNC_IND,      "SYNC_IND" },

+   { V110_TA_EV_DESYNC_IND,    "DESYNC_IND" },

+   { V110_TA_EV_TIMEOUT,       "TIMEOUT" },

+   { 0, NULL }

+};

+

+enum v110_ta_d_bit_mode {

+   V110_TA_DBIT_M_ALL_ZERO     = 0,    /* set all bits to binary '0' */

+   V110_TA_DBIT_M_ALL_ONE      = 1,    /* set all bits to binary '1' */

+   V110_TA_DBIT_M_FORWARD,         /* forward D-bits to/from DTE */

+};

+

+struct v110_ta_state {

+   /*! V.24 status flags shared between DTE (user) and DCE (TA, us) */

+   unsigned int v24_flags;

+   struct {

+       /* what kind of D-bits to transmit in V.110 frames */

+       enum v110_ta_d_bit_mode d_bit_mode;

+       /* what to put in S-bits of transmitted V.110 frames */

+       ubit_t s_bits;

+       /* what to put in X-bits of transmitted V.110 frames */

+       ubit_t x_bits;

+   } tx;

+   struct {

+       enum v110_ta_d_bit_mode d_bit_mode;

+   } rx;

+};

+

+struct osmo_v110_ta {

+   const char *name;

+   struct osmo_tdef *Tdefs;

+   struct osmo_fsm_inst *fi;

+   struct osmo_v110_ta_cfg *cfg;

+   struct v110_ta_state state;

+};

+

+static inline bool v110_df_x_bits_are(const struct osmo_v110_decoded_frame *df, ubit_t cmp)

+{

+   return (df->x_bits0 == cmp) && (df->x_bits1 == cmp);

+}

+

+static inline bool v110_df_s_bits_are(const struct osmo_v110_decoded_frame *df, ubit_t cmp)

+{

+   /* ITU-T Table 2/V.110 (see also 5.1.2.3) defines the following S-bits:

+    * S1, S3, S4, S6, S8, S9 (6 bits total).  However, fr->s_bits contains

+    * 9 (MAX_S_BITS) bits, including the undefined bits S2, S5, S7.

+    * Hence we must skip those undefined bits. */

+   static const uint8_t sbit_map = { 0, 2, 3, 5, 7, 8 };

+

+   for (unsigned int i = 0; i < ARRAY_SIZE(sbit_map); i++) {

+       uint8_t idx = sbit_mapi;

+       if (df->s_bitsidx != cmp)

+           return false;

+   }

+

+   return true;

+}

+

+static inline bool v110_df_d_bits_are(const struct osmo_v110_decoded_frame *df, ubit_t cmp)

+{

+   for (unsigned int i = 0; i < MAX_D_BITS; i++) {

+       if (df->d_bitsi != cmp)

+           return false;

+   }

+

+   return true;

+}

+

+/* handle one V.110 frame and forward user bits to the application */

+static void v110_ta_handle_frame(const struct osmo_v110_ta *ta,

+                const struct osmo_v110_decoded_frame *df)

+{

+   const struct osmo_v110_ta_cfg *cfg = ta->cfg;

+   const struct v110_ta_state *ts = &ta->state;

+   ubit_t user_bitsMAX_D_BITS;

+   int num_user_bits;

+   int rc;

+

+   switch (ts->rx.d_bit_mode) {

+   case V110_TA_DBIT_M_ALL_ZERO:

+   case V110_TA_DBIT_M_ALL_ONE:

+       /* generate as many user bits as needed for the configured rate */

+       num_user_bits = osmo_v110_sync_ra1_get_user_data_chunk_bitlen(cfg->rate);

+       OSMO_ASSERT(num_user_bits > 0);

​

@@ -54,6 +54,7 @@

         auth/xor2g_test                                        \

         v110/frame_test                                        \

         v110/ra1_test                                          \

+        v110/ta_test                                           \

         gsm44021/frame_csd_test                                \

         osmo_io/osmo_io_test                   \

         soft_uart/soft_uart_test               \

@@ -373,6 +374,9 @@

 v110_ra1_test_SOURCES = v110/ra1_test.c

 v110_ra1_test_LDADD = $(top_builddir)/src/isdn/libosmoisdn.la $(LDADD)

+v110_ta_test_SOURCES = v110/ta_test.c

+v110_ta_test_LDADD = $(top_builddir)/src/isdn/libosmoisdn.la $(LDADD)

+

 gsm44021_frame_csd_test_SOURCES = gsm44021/frame_csd_test.c

 gsm44021_frame_csd_test_LDADD = $(top_builddir)/src/isdn/libosmoisdn.la \

                $(top_builddir)/src/gsm/libosmogsm.la \

@@ -493,6 +497,7 @@

         smscb/cbsp_test.ok \

         v110/frame_test.ok \

         v110/ra1_test.ok \

+        v110/ta_test.err \

         gsm44021/frame_csd_test.ok \

         osmo_io/osmo_io_test.ok osmo_io/osmo_io_test.err \

         soft_uart/soft_uart_test.ok \

@@ -712,6 +717,8 @@

        >$(srcdir)/v110/frame_test.ok

    v110/ra1_test \

        >$(srcdir)/v110/ra1_test.ok

+   v110/ta_test \

+       2>$(srcdir)/v110/ta_test.err

    gsm44021/frame_csd_test \

        >$(srcdir)/gsm44021/frame_csd_test.ok

    osmo_io/osmo_io_test \

​

@@ -86,14 +86,15 @@

        printf("osmo_tdef_get(%d, %s)\t= %lu\n", T, osmo_tdef_unit_name(AS_UNIT), val); \

    } while (0)

-void print_tdef_info(unsigned int T)

+void print_tdef_info(int T)

 {

    const struct osmo_tdef *t = osmo_tdef_get_entry(tdefs, T);

    if (!t) {

-       printf("T%d=NULL", T);

+       printf(OSMO_T_FMT "=NULL", OSMO_T_FMT_ARGS(T));

        return;

    }

-   printf("T%d=%lu%s", T, t->val, osmo_tdef_unit_name(t->unit));

+   printf(OSMO_T_FMT "=%lu%s",

+          OSMO_T_FMT_ARGS(T), t->val, osmo_tdef_unit_name(t->unit));

    if (t->val != t->default_val)

        printf("(def=%lu)", t->default_val);

    printf("\n");

@@ -109,7 +110,7 @@

    osmo_tdefs_reset(tdefs); // make all values the default

    for (i = 0; i < ARRAY_SIZE(tdefs)-1; i++) {

-       unsigned int T = tdefsi.T;

+       int T = tdefsi.T;

        print_tdef_info(T);

        for (as_unit = OSMO_TDEF_S; as_unit <= OSMO_TDEF_US; as_unit++) {

            print_tdef_get_short(tdefs, T, as_unit);

@@ -120,7 +121,7 @@

        return;

    for (i = 0; i < ARRAY_SIZE(tdefs_range)-1; i++) {

-       unsigned int T = tdefs_rangei.T;

+       int T = tdefs_rangei.T;

        print_tdef_info(T);

        for (as_unit = OSMO_TDEF_S; as_unit <= OSMO_TDEF_US; as_unit++) {

            print_tdef_get_short(tdefs_range, T, as_unit);

@@ -347,9 +348,9 @@

                   osmo_fsm_state_name(&test_tdef_fsm, NEXT_STATE), rc); \

        } else { \

            struct osmo_tdef *t = osmo_tdef_get_entry(tdefs, st->T); \

-           printf(" --> %s (configured as T%d%s %lu %s) rc=%d;\t", \

+           printf(" --> %s (configured as " OSMO_T_FMT "%s %lu %s) rc=%d;\t", \

                   osmo_fsm_state_name(&test_tdef_fsm, NEXT_STATE), \

-                  st->T, st->keep_timer ? "(keep_timer)" : "", \

+                  OSMO_T_FMT_ARGS(st->T), st->keep_timer ? " (keep_timer)" : "", \

                   t? t->val : 0, t? osmo_tdef_unit_name(t->unit) : "-", \

                   rc); \

        } \

​

@@ -1,10 +1,10 @@

 DLGLOBAL DEBUG tdef_test(test_tdef_state_timeout){A}: Allocated

 DLGLOBAL DEBUG tdef_test(test_tdef_state_timeout){A}: State change to A (T1, 100s)

-DLGLOBAL DEBUG tdef_test(test_tdef_state_timeout){A}: State change to B (T2, 1s)

+DLGLOBAL DEBUG tdef_test(test_tdef_state_timeout){A}: State change to B (T2, 100ms)

 DLGLOBAL DEBUG tdef_test(test_tdef_state_timeout){B}: State change to C (T3, 3000s)

 DLGLOBAL DEBUG tdef_test(test_tdef_state_timeout){C}: State change to D (T4, 100s)

-DLGLOBAL DEBUG tdef_test(test_tdef_state_timeout){D}: State change to E (X5, 1s)

-DLGLOBAL DEBUG tdef_test(test_tdef_state_timeout){E}: State change to F (X6, 1s)

+DLGLOBAL DEBUG tdef_test(test_tdef_state_timeout){D}: State change to E (X5, 100ms)

+DLGLOBAL DEBUG tdef_test(test_tdef_state_timeout){E}: State change to F (X6, 1ms)

 DLGLOBAL DEBUG tdef_test(test_tdef_state_timeout){F}: State change to G (T7, 50s)

 DLGLOBAL DEBUG tdef_test(test_tdef_state_timeout){G}: State change to H (T8, 300s)

 DLGLOBAL DEBUG tdef_test(test_tdef_state_timeout){H}: State change to I (T9, 300s)

​

@@ -24,13 +24,13 @@

 osmo_tdef_get(4, m)    = 100

 osmo_tdef_get(4, custom-unit)  = 100

 osmo_tdef_get(4, us)   = 100

-T-5=100ms

+X5=100ms

 osmo_tdef_get(-5, s)   = 1

 osmo_tdef_get(-5, ms)  = 100

 osmo_tdef_get(-5, m)   = 1

 osmo_tdef_get(-5, custom-unit) = 100

 osmo_tdef_get(-5, us)  = 100000

-T-6=100us

+X6=100us

 osmo_tdef_get(-6, s)   = 1

 osmo_tdef_get(-6, ms)  = 1

 osmo_tdef_get(-6, m)   = 1

@@ -165,11 +165,11 @@

 test_tdef_state_timeout()

 state=A T=0, no timeout

  --> A (configured as T1 100 s) rc=0;  state=A T=1, 100.000000 s remaining

- --> B (configured as T2 100 ms) rc=0; state=B T=2, 1.000000 s remaining

+ --> B (configured as T2 100 ms) rc=0; state=B T=2, 0.100000 s remaining

  --> C (configured as T3 50 m) rc=0;   state=C T=3, 3000.000000 s remaining

  --> D (configured as T4 100 custom-unit) rc=0;    state=D T=4, 100.000000 s remaining

- --> E (configured as T-5 100 ms) rc=0;    state=E T=-5, 1.000000 s remaining

- --> F (configured as T-6 100 us) rc=0;    state=F T=-6, 1.000000 s remaining

+ --> E (configured as X5 100 ms) rc=0; state=E T=-5, 0.100000 s remaining

+ --> F (configured as X6 100 us) rc=0; state=F T=-6, 0.001000 s remaining

  --> G (configured as T7 50 s) rc=0;   state=G T=7, 50.000000 s remaining

  --> H (configured as T8 300 s) rc=0;  state=H T=8, 300.000000 s remaining

  --> I (configured as T9 5 m) rc=0;    state=I T=9, 300.000000 s remaining

@@ -177,17 +177,17 @@

 - test keep_timer:

 Time passes: 123.045678 s

 state=J T=10, 1076.954322 s remaining

- --> K (configured as T0(keep_timer) 1 custom-unit) rc=0;  state=K T=10, 1076.954322 s remaining

+ --> K (configured as T0 (keep_timer) 1 custom-unit) rc=0; state=K T=10, 1076.954322 s remaining

  --> A (configured as T1 100 s) rc=0;  state=A T=1, 100.000000 s remaining

 Time passes: 23.045678 s

 state=A T=1, 76.954322 s remaining

- --> K (configured as T0(keep_timer) 1 custom-unit) rc=0;  state=K T=1, 76.954322 s remaining

+ --> K (configured as T0 (keep_timer) 1 custom-unit) rc=0; state=K T=1, 76.954322 s remaining

  --> A (configured as T1 100 s) rc=0;  state=A T=1, 100.000000 s remaining

 Time passes: 23.045678 s

 state=A T=1, 76.954322 s remaining

- --> L (configured as T123(keep_timer) 1 s) rc=0;  state=L T=1, 76.954322 s remaining

+ --> L (configured as T123 (keep_timer) 1 s) rc=0; state=L T=1, 76.954322 s remaining

  --> O (no timer configured for this state) rc=0;  state=O T=0, no timeout

- --> L (configured as T123(keep_timer) 1 s) rc=0;  state=L T=123, 1.000000 s remaining

+ --> L (configured as T123 (keep_timer) 1 s) rc=0; state=L T=123, 1.000000 s remaining

 - test T=0:

  --> O (no timer configured for this state) rc=0;  state=O T=0, no timeout

 - test no timer:

​

@@ -511,6 +511,12 @@

 AT_CHECK($abs_top_builddir/tests/v110/ra1_test, , expout,)

 AT_CLEANUP

+AT_SETUP(v110_ta_test)

+AT_KEYWORDS(v110_ta_test)

+cat $abs_srcdir/v110/ta_test.err > experr

+AT_CHECK($abs_top_builddir/tests/v110/ta_test, , , experr)

+AT_CLEANUP

+

 AT_SETUP(gsm44021_frame_csd_test)

 AT_KEYWORDS(gsm44021_frame_csd_test)

 cat $abs_srcdir/gsm44021/frame_csd_test.ok > expout

​

@@ -0,0 +1,459 @@

+/*

+ * (C) 2023 by sysmocom - s.f.m.c. GmbH <info@sysmocom.de>

+ * Author: Vadim Yanitskiy <vyanitskiy@sysmocom.de>

+ *

+ * All Rights Reserved

+ *

+ * This program is free software; you can redistribute it and/or modify

+ * it under the terms of the GNU General Public License as published by

+ * the Free Software Foundation; either version 2 of the License, or

+ * (at your option) any later version.

+ *

+ * This program is distributed in the hope that it will be useful,

+ * but WITHOUT ANY WARRANTY; without even the implied warranty of

+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the

+ * GNU General Public License for more details.

+ *

+ */

+

+#include <stdio.h>

+#include <stdint.h>

+#include <stdbool.h>

+

+#include <osmocom/core/fsm.h>

+#include <osmocom/core/bits.h>

+#include <osmocom/core/logging.h>

+#include <osmocom/core/application.h>

+

+#include <osmocom/isdn/v110.h>

+#include <osmocom/isdn/v110_ta.h>

+

+static void *test_ctx = NULL;

+

+/* inverse logic: ON = binary 0; OFF = binary 1 */

+#define V110_SX_BIT_ON     0

+#define V110_SX_BIT_OFF        1

+

+/*********************************************************************************

+ * V.110 TA configuration and callbacks

+ *********************************************************************************/

+

+static void v110_ta_test_rx_cb(void *priv, const ubit_t *buf, size_t buf_size)

+{

+   fprintf(stderr, "%s(buf_size=%zu): %s\n",

+       __func__, buf_size, osmo_ubit_dump(buf, buf_size));

+}

+

+static void v110_ta_test_tx_cb(void *priv, ubit_t *buf, size_t buf_size)

+{

+   for (size_t i = 0; i < buf_size; i++)

+       bufi = (i & 1);

+   fprintf(stderr, "%s(buf_size=%zu): %s\n",

+       __func__, buf_size, osmo_ubit_dump(buf, buf_size));

+}

+

+static void v110_ta_test_status_update_cb(void *priv, unsigned int status)

+{

+   fprintf(stderr, "%s(status=0x%08x)\n", __func__, status);

+}

+

+static const struct osmo_v110_ta_cfg v110_ta_test_cfg = {

+   .rate = OSMO_V110_SYNC_RA1_9600,

+   .rx_cb = &v110_ta_test_rx_cb,

+   .tx_cb = &v110_ta_test_tx_cb,

+   .status_update_cb = &v110_ta_test_status_update_cb,

+};

+

+/*********************************************************************************

+ * various helper functions

+ *********************************************************************************/

+

+static void v110_ta_test_init_df(struct osmo_v110_decoded_frame *df)

+{

+   /* quickly set all the bits to binary '1' */

+   memset(df, 1, sizeof(*df));

+   /* D-bits: 0101... pattern */

+   for (unsigned int i = 0; i < MAX_D_BITS; i += 2)

+       df->d_bitsi = 0;

+   /* E-bits: E1/E2/E3 indicate 9600 bps */

+   df->e_bits0 = 0;

+}

+

+static void v110_ta_test_dump_df(const struct osmo_v110_decoded_frame *df)

+{

+   fprintf(stderr, "    D-bits: %s\n", osmo_ubit_dump(&df->d_bits0, MAX_D_BITS));

+   fprintf(stderr, "    E-bits: %s\n", osmo_ubit_dump(&df->e_bits0, MAX_E_BITS));

+   fprintf(stderr, "    S-bits: %s\n", osmo_ubit_dump(&df->s_bits0, MAX_S_BITS));

+   fprintf(stderr, "    X-bits: %s\n", osmo_ubit_dump(&df->x_bits0, MAX_X_BITS));

+}

+

+static void v110_ta_test_dump_circuit(const struct osmo_v110_ta *ta,

+                     enum osmo_v110_ta_circuit circuit,

+                     bool exp_state)

+{

+   bool state = osmo_v110_ta_get_circuit(ta, circuit);

+

+   fprintf(stderr, "circuit %s (%s) is %s (expected to be %s)\n",

+       osmo_v110_ta_circuit_name(circuit),

+       osmo_v110_ta_circuit_desc(circuit),

+       state ? "ON" : "OFF",

+       exp_state ? "ON" : "OFF");

+}

+

+static void v110_ta_test_set_circuit(struct osmo_v110_ta *ta,

+                    enum osmo_v110_ta_circuit circuit,

+                    bool active)

+{

+   int rc;

+

+   fprintf(stderr, "setting circuit %s (%s) %s\n",

+       osmo_v110_ta_circuit_name(circuit),

+       osmo_v110_ta_circuit_desc(circuit),

+       active ? "ON" : "OFF");

+

+   rc = osmo_v110_ta_set_circuit(ta, circuit, active);

+   fprintf(stderr, "osmo_v110_ta_set_circuit() returns %d\n", rc);

+}

+

+/*********************************************************************************

+ * the actual tests

+ *********************************************************************************/

+

+static void test_idle_ready(void)

+{

+   struct osmo_v110_decoded_frame df = { 0 };

+   struct osmo_v110_ta *ta;

+   int rc;

+

+   fprintf(stderr, "\n==== Running %s()\n", __func__);

+

+   ta = osmo_v110_ta_alloc(test_ctx, __func__, &v110_ta_test_cfg);

+   OSMO_ASSERT(ta != NULL);

+

+   /* we expect the TA FSM to be in V110_TA_ST_IDLE_READY */

+

+   fprintf(stderr, "Initial status: 0x%08x\n", osmo_v110_ta_get_status(ta));

+   v110_ta_test_dump_circuit(ta, OSMO_V110_TA_C_106, false);

+   v110_ta_test_dump_circuit(ta, OSMO_V110_TA_C_107, false);

+   v110_ta_test_dump_circuit(ta, OSMO_V110_TA_C_109, false);

+

+   fprintf(stderr, "osmo_v110_ta_frame_in(): all bits set to binary '1'\n");

+   memset(&df, 1, sizeof(df));

+   v110_ta_test_dump_df(&df);

+   rc = osmo_v110_ta_frame_in(ta, &df);

+   fprintf(stderr, "osmo_v110_ta_frame_in() returns %d\n", rc);

+

+   fprintf(stderr, "osmo_v110_ta_frame_out(): expecting all bits set to binary '1'\n");

+   rc = osmo_v110_ta_frame_out(ta, &df);

+   fprintf(stderr, "osmo_v110_ta_frame_out() returns %d\n", rc);

+   if (rc == 0)

+       v110_ta_test_dump_df(&df);

+

+   v110_ta_test_set_circuit(ta, OSMO_V110_TA_C_108, true);

+   v110_ta_test_set_circuit(ta, OSMO_V110_TA_C_108, false);

+   v110_ta_test_set_circuit(ta, OSMO_V110_TA_C_108, true);

+

+   osmo_v110_ta_free(ta);

+}

+

+static void test_conn_ta_line(void)

+{

+   struct osmo_v110_decoded_frame df = { 0 };

+   struct osmo_v110_ta *ta;

+   int rc;

+

+   fprintf(stderr, "\n==== Running %s()\n", __func__);

+

+   ta = osmo_v110_ta_alloc(test_ctx, __func__, &v110_ta_test_cfg);

+   OSMO_ASSERT(ta != NULL);

+

+   /* we expect the TA FSM to be in V110_TA_ST_IDLE_READY */

+

+   v110_ta_test_set_circuit(ta, OSMO_V110_TA_C_108, true);

+

+   /* we expect the TA FSM to be in V110_TA_ST_CON_TA_TO_LINE */

+

+   fprintf(stderr, "osmo_v110_ta_frame_out(): S-/X-bits are expected to be 1 (OFF)\n");

+   fprintf(stderr, "osmo_v110_ta_frame_out(): D-/E-bits are all expected to be 1\n");

+   rc = osmo_v110_ta_frame_out(ta, &df);

+   fprintf(stderr, "osmo_v110_ta_frame_out() returns %d\n", rc);

+   if (rc == 0)

+       v110_ta_test_dump_df(&df);

+

+   /* TODO: test implicit sync by sending V110_TA_EV_RX_FRAME_IND */

+

+   fprintf(stderr, "osmo_v110_ta_sync_ind(): the lower layer indicates sync event\n");

+   osmo_v110_ta_sync_ind(ta);

+

+   fprintf(stderr, "osmo_v110_ta_frame_out(): S-/X-bits are expected to be 0 (ON)\n");

+   fprintf(stderr, "osmo_v110_ta_frame_out(): D-/E-bits are all expected to be 1\n");

+   rc = osmo_v110_ta_frame_out(ta, &df);

+   fprintf(stderr, "osmo_v110_ta_frame_out() returns %d\n", rc);

+   if (rc == 0)

+       v110_ta_test_dump_df(&df);

+

+   fprintf(stderr, "osmo_v110_ta_frame_in(): S-/X-bits are OFF, expect no state change\n");

+   v110_ta_test_init_df(&df);

+   v110_ta_test_dump_df(&df);

+   rc = osmo_v110_ta_frame_in(ta, &df);

+   fprintf(stderr, "osmo_v110_ta_frame_in() returns %d\n", rc);

​

@@ -0,0 +1,284 @@

+

+==== Running test_idle_ready()

+DLGLOBAL DEBUG V110-TA(test_idle_ready){IDLE_READY}: Allocated

+DLGLOBAL DEBUG V110-TA(test_idle_ready){IDLE_READY}: State change to IDLE_READY (no timeout)

+v110_ta_test_status_update_cb(status=0x00000000)

+Initial status: 0x00000000

+circuit 106/CTS (Clear to Send) is OFF (expected to be OFF)

+circuit 107/DSR (Data Set Ready) is OFF (expected to be OFF)

+circuit 109/DCD (Data Carrier Detect) is OFF (expected to be OFF)

+osmo_v110_ta_frame_in(): all bits set to binary '1'

+    D-bits: 111111111111111111111111111111111111111111111111

+    E-bits: 1111111

+    S-bits: 111111111

+    X-bits: 11

+DLGLOBAL DEBUG V110-TA(test_idle_ready){IDLE_READY}: Received Event RX_FRAME_IND

+v110_ta_test_rx_cb(buf_size=48): 111111111111111111111111111111111111111111111111

+osmo_v110_ta_frame_in() returns 0

+osmo_v110_ta_frame_out(): expecting all bits set to binary '1'

+DLGLOBAL DEBUG V110-TA(test_idle_ready){IDLE_READY}: Received Event TX_FRAME_RTS

+osmo_v110_ta_frame_out() returns 0

+    D-bits: 111111111111111111111111111111111111111111111111

+    E-bits: 1111111

+    S-bits: 111111111

+    X-bits: 11

+setting circuit 108/DTR (Data Terminal Ready) ON

+DLGLOBAL DEBUG V110-TA(test_idle_ready){IDLE_READY}: Received Event V24_STATUS_CHG

+DLGLOBAL DEBUG V110-TA(test_idle_ready){IDLE_READY}: State change to CONNECT_TA_TO_LINE (T1, 10s)

+osmo_v110_ta_set_circuit() returns 0

+setting circuit 108/DTR (Data Terminal Ready) OFF

+DLGLOBAL DEBUG V110-TA(test_idle_ready){CONNECT_TA_TO_LINE}: Received Event V24_STATUS_CHG

+DLGLOBAL DEBUG V110-TA(test_idle_ready){CONNECT_TA_TO_LINE}: State change to IDLE_READY (no timeout)

+v110_ta_test_status_update_cb(status=0x00000000)

+osmo_v110_ta_set_circuit() returns 0

+setting circuit 108/DTR (Data Terminal Ready) ON

+DLGLOBAL DEBUG V110-TA(test_idle_ready){IDLE_READY}: Received Event V24_STATUS_CHG

+DLGLOBAL DEBUG V110-TA(test_idle_ready){IDLE_READY}: State change to CONNECT_TA_TO_LINE (T1, 10s)

+osmo_v110_ta_set_circuit() returns 0

+DLGLOBAL DEBUG V110-TA(test_idle_ready){CONNECT_TA_TO_LINE}: Deallocated

+

+==== Running test_conn_ta_line()

+DLGLOBAL DEBUG V110-TA(test_conn_ta_line){IDLE_READY}: Allocated

+DLGLOBAL DEBUG V110-TA(test_conn_ta_line){IDLE_READY}: State change to IDLE_READY (no timeout)

+v110_ta_test_status_update_cb(status=0x00000000)

+setting circuit 108/DTR (Data Terminal Ready) ON

+DLGLOBAL DEBUG V110-TA(test_conn_ta_line){IDLE_READY}: Received Event V24_STATUS_CHG

+DLGLOBAL DEBUG V110-TA(test_conn_ta_line){IDLE_READY}: State change to CONNECT_TA_TO_LINE (T1, 10s)

+osmo_v110_ta_set_circuit() returns 0

+osmo_v110_ta_frame_out(): S-/X-bits are expected to be 1 (OFF)

+osmo_v110_ta_frame_out(): D-/E-bits are all expected to be 1

+DLGLOBAL DEBUG V110-TA(test_conn_ta_line){CONNECT_TA_TO_LINE}: Received Event TX_FRAME_RTS

+osmo_v110_ta_frame_out() returns 0

+    D-bits: 111111111111111111111111111111111111111111111111

+    E-bits: 1111111

+    S-bits: 111111111

+    X-bits: 11

+osmo_v110_ta_sync_ind(): the lower layer indicates sync event

+DLGLOBAL DEBUG V110-TA(test_conn_ta_line){CONNECT_TA_TO_LINE}: Received Event SYNC_IND

+osmo_v110_ta_frame_out(): S-/X-bits are expected to be 0 (ON)

+osmo_v110_ta_frame_out(): D-/E-bits are all expected to be 1

+DLGLOBAL DEBUG V110-TA(test_conn_ta_line){CONNECT_TA_TO_LINE}: Received Event TX_FRAME_RTS

+osmo_v110_ta_frame_out() returns 0

+    D-bits: 111111111111111111111111111111111111111111111111

+    E-bits: 1111111

+    S-bits: 000000000

+    X-bits: 00

+osmo_v110_ta_frame_in(): S-/X-bits are OFF, expect no state change

+    D-bits: 010101010101010101010101010101010101010101010101

+    E-bits: 0111111

+    S-bits: 111111111

+    X-bits: 11

+DLGLOBAL DEBUG V110-TA(test_conn_ta_line){CONNECT_TA_TO_LINE}: Received Event RX_FRAME_IND

+v110_ta_test_rx_cb(buf_size=48): 111111111111111111111111111111111111111111111111

+osmo_v110_ta_frame_in() returns 0

+osmo_v110_ta_frame_in(): S-/X-bits are ON, expect state change

+    D-bits: 010101010101010101010101010101010101010101010101

+    E-bits: 0111111

+    S-bits: 000000000

+    X-bits: 00

+DLGLOBAL DEBUG V110-TA(test_conn_ta_line){CONNECT_TA_TO_LINE}: Received Event RX_FRAME_IND

+v110_ta_test_status_update_cb(status=0x0000001e)

+DLGLOBAL DEBUG V110-TA(test_conn_ta_line){CONNECT_TA_TO_LINE}: State change to DATA_TRANSFER (no timeout)

+v110_ta_test_status_update_cb(status=0x0000001e)

+v110_ta_test_rx_cb(buf_size=48): 010101010101010101010101010101010101010101010101

+osmo_v110_ta_frame_in() returns 0

+DLGLOBAL DEBUG V110-TA(test_conn_ta_line){DATA_TRANSFER}: Deallocated

+

+==== Running test_data_transfer()

+DLGLOBAL DEBUG V110-TA(test_data_transfer){IDLE_READY}: Allocated

+DLGLOBAL DEBUG V110-TA(test_data_transfer){IDLE_READY}: State change to IDLE_READY (no timeout)

+v110_ta_test_status_update_cb(status=0x00000000)

+setting circuit 108/DTR (Data Terminal Ready) ON

+DLGLOBAL DEBUG V110-TA(test_data_transfer){IDLE_READY}: Received Event V24_STATUS_CHG

+DLGLOBAL DEBUG V110-TA(test_data_transfer){IDLE_READY}: State change to CONNECT_TA_TO_LINE (T1, 10s)

+osmo_v110_ta_set_circuit() returns 0

+osmo_v110_ta_sync_ind(): the lower layer indicates sync event

+DLGLOBAL DEBUG V110-TA(test_data_transfer){CONNECT_TA_TO_LINE}: Received Event SYNC_IND

+osmo_v110_ta_frame_in(): S-/X-bits are ON, expect state change

+    D-bits: 010101010101010101010101010101010101010101010101

+    E-bits: 0111111

+    S-bits: 000000000

+    X-bits: 00

+DLGLOBAL DEBUG V110-TA(test_data_transfer){CONNECT_TA_TO_LINE}: Received Event RX_FRAME_IND

+v110_ta_test_status_update_cb(status=0x0000001e)

+DLGLOBAL DEBUG V110-TA(test_data_transfer){CONNECT_TA_TO_LINE}: State change to DATA_TRANSFER (no timeout)

+v110_ta_test_status_update_cb(status=0x0000001e)

+v110_ta_test_rx_cb(buf_size=48): 010101010101010101010101010101010101010101010101

+osmo_v110_ta_frame_in() returns 0

+circuit 106/CTS (Clear to Send) is ON (expected to be ON)

+circuit 107/DSR (Data Set Ready) is ON (expected to be ON)

+circuit 109/DCD (Data Carrier Detect) is ON (expected to be ON)

+osmo_v110_ta_frame_out(): S-/X-bits are expected to be 0 (ON)

+osmo_v110_ta_frame_out(): E1..E3-bits are expected to be 011 (9600)

+osmo_v110_ta_frame_out(): we also expect the .tx_cb() to be called

+DLGLOBAL DEBUG V110-TA(test_data_transfer){DATA_TRANSFER}: Received Event TX_FRAME_RTS

+v110_ta_test_tx_cb(buf_size=48): 010101010101010101010101010101010101010101010101

+osmo_v110_ta_frame_out() returns 0

+    D-bits: 010101010101010101010101010101010101010101010101

+    E-bits: 0111111

+    S-bits: 000000000

+    X-bits: 00

+osmo_v110_ta_frame_in(): feed that frame that we pulled out back into the TA

+DLGLOBAL DEBUG V110-TA(test_data_transfer){DATA_TRANSFER}: Received Event RX_FRAME_IND

+v110_ta_test_rx_cb(buf_size=48): 010101010101010101010101010101010101010101010101

+osmo_v110_ta_frame_in() returns 0

+DLGLOBAL DEBUG V110-TA(test_data_transfer){DATA_TRANSFER}: Deallocated

+

+==== Running test_data_transfer_disc_local()

+DLGLOBAL DEBUG V110-TA(test_data_transfer_disc_local){IDLE_READY}: Allocated

+DLGLOBAL DEBUG V110-TA(test_data_transfer_disc_local){IDLE_READY}: State change to IDLE_READY (no timeout)

+v110_ta_test_status_update_cb(status=0x00000000)

+setting circuit 108/DTR (Data Terminal Ready) ON

+DLGLOBAL DEBUG V110-TA(test_data_transfer_disc_local){IDLE_READY}: Received Event V24_STATUS_CHG

+DLGLOBAL DEBUG V110-TA(test_data_transfer_disc_local){IDLE_READY}: State change to CONNECT_TA_TO_LINE (T1, 10s)

+osmo_v110_ta_set_circuit() returns 0

+osmo_v110_ta_sync_ind(): the lower layer indicates sync event

+DLGLOBAL DEBUG V110-TA(test_data_transfer_disc_local){CONNECT_TA_TO_LINE}: Received Event SYNC_IND

+osmo_v110_ta_frame_in(): S-/X-bits are ON, expect state change

+    D-bits: 010101010101010101010101010101010101010101010101

+    E-bits: 0111111

+    S-bits: 000000000

+    X-bits: 00