Osmocom Open Build Service

osmo-hlr.spec Changed

commit_2989873a68e395553c6b925b8a368c9918350b3e.txt Added

commit_390f6fcf1325f293a737b00d218a6f871e04541f.txt Deleted

osmo-hlr_1.6.0.6.390f.dsc -> osmo-hlr_1.6.0.7.2989.dsc Changed

@@ -2,7 +2,7 @@
 Source: osmo-hlr
 Binary: osmo-hlr, osmo-hlr-dbg, libosmo-gsup-client0, libosmo-gsup-client-dev, libosmo-mslookup1, libosmo-mslookup-dev, osmo-mslookup-utils, osmo-hlr-doc
 Architecture: any all
-Version: 1.6.0.6.390f
+Version: 1.6.0.7.2989
 Maintainer: Osmocom team <openbsc@lists.osmocom.org>
 Homepage: https://projects.osmocom.org/projects/osmo-hlr
 Standards-Version: 3.9.6
@@ -19,8 +19,8 @@
  osmo-hlr-doc deb doc optional arch=all
  osmo-mslookup-utils deb utils optional arch=any
 Checksums-Sha1:
- e1ad255d0736ac1e55339e4d0dd61ba5a061fc0d 172184 osmo-hlr_1.6.0.6.390f.tar.xz
+ a86a2580baf4b96f056244431b302f8add01641b 171976 osmo-hlr_1.6.0.7.2989.tar.xz
 Checksums-Sha256:
- 2d48767d8250d4fc702941c028711efe406520670ec4d0125cee4720e7460a77 172184 osmo-hlr_1.6.0.6.390f.tar.xz
+ 53284313a765e68e11075e926f85d22c9846fbd6c9262eb216ee42413dfddef5 171976 osmo-hlr_1.6.0.7.2989.tar.xz
 Files:
- fba649ed15db1b8dc29854c5db00e69a 172184 osmo-hlr_1.6.0.6.390f.tar.xz
+ 4120a1e19439f6ee047d6021af9c7ddb 171976 osmo-hlr_1.6.0.7.2989.tar.xz

osmo-hlr_1.6.0.6.390f.tar.xz/.tarball-version -> osmo-hlr_1.6.0.7.2989.tar.xz/.tarball-version Changed

osmo-hlr_1.6.0.6.390f.tar.xz/debian/changelog -> osmo-hlr_1.6.0.7.2989.tar.xz/debian/changelog Changed

osmo-hlr_1.6.0.6.390f.tar.xz/include/osmocom/hlr/gsup_server.h -> osmo-hlr_1.6.0.7.2989.tar.xz/include/osmocom/hlr/gsup_server.h Changed

osmo-hlr_1.6.0.6.390f.tar.xz/src/gsup_server.c -> osmo-hlr_1.6.0.7.2989.tar.xz/src/gsup_server.c Changed

@@ -446,19 +446,16 @@
  * \paramout gsup  The gsup message to populate.
  * \paramin imsi  The subscriber's IMSI.
  * \paramin msisdn The subscriber's MSISDN.
- * \paramout msisdn_enc A buffer large enough to store the MSISDN in encoded form.
- * \paramin msisdn_enc_size Size of the buffer (must be >= OSMO_GSUP_MAX_CALLED_PARTY_BCD_LEN).
- * \paramout apn_buf A buffer large enough to store an APN (required if cn_domain is OSMO_GSUP_CN_DOMAIN_PS).
- * \paramin apn_buf_size Size of APN buffer (must be >= APN_MAXLEN).
  * \paramin cn_domain The CN Domain of the subscriber connection.
+ * \paramin talloc_ctx To allocation memory for dynamic fields (msisdn, apn) in the gsup field
  * \returns 0 on success, and negative on error.
  */
 int osmo_gsup_create_insert_subscriber_data_msg(struct osmo_gsup_message *gsup, const char *imsi, const char *msisdn,
-						uint8_t *msisdn_enc, size_t msisdn_enc_size,
-						uint8_t *apn_buf, size_t apn_buf_size,
-						enum osmo_gsup_cn_domain cn_domain)
+						enum osmo_gsup_cn_domain cn_domain,
+						void *talloc_ctx)
 {
 	int len;
+	uint8_t *msisdn_buf = talloc_size(talloc_ctx, OSMO_GSUP_MAX_CALLED_PARTY_BCD_LEN);
 
 	OSMO_ASSERT(gsup);
 	*gsup = (struct osmo_gsup_message){
@@ -467,27 +464,22 @@
 
 	osmo_strlcpy(gsup->imsi, imsi, sizeof(gsup->imsi));
 
-	if (msisdn_enc_size < OSMO_GSUP_MAX_CALLED_PARTY_BCD_LEN)
-		return -ENOSPC;
-
-	OSMO_ASSERT(msisdn_enc);
-	len = gsm48_encode_bcd_number(msisdn_enc, msisdn_enc_size, 0, msisdn);
+	len = gsm48_encode_bcd_number(msisdn_buf, OSMO_GSUP_MAX_CALLED_PARTY_BCD_LEN, 0, msisdn);
 	if (len < 1) {
 		LOGP(DLGSUP, LOGL_ERROR, "%s: Error: cannot encode MSISDN '%s'\n", imsi, msisdn);
 		return -ENOSPC;
 	}
-	gsup->msisdn_enc = msisdn_enc;
+	gsup->msisdn_enc = msisdn_buf;
 	gsup->msisdn_enc_len = len;
 
 	#pragma message "FIXME: deal with encoding the following data: gsup.hlr_enc"
 
 	gsup->cn_domain = cn_domain;
 	if (gsup->cn_domain == OSMO_GSUP_CN_DOMAIN_PS) {
-		OSMO_ASSERT(apn_buf_size >= APN_MAXLEN);
-		OSMO_ASSERT(apn_buf);
+		uint8_t *apn_buf = talloc_size(talloc_ctx, APN_MAXLEN);
 		/* FIXME: PDP infos - use more fine-grained access control
 		   instead of wildcard APN */
-		osmo_gsup_configure_wildcard_apn(gsup, apn_buf, apn_buf_size);
+		osmo_gsup_configure_wildcard_apn(gsup, apn_buf, APN_MAXLEN);
 	}
 
 	return 0;

osmo-hlr_1.6.0.6.390f.tar.xz/src/hlr.c -> osmo-hlr_1.6.0.7.2989.tar.xz/src/hlr.c Changed

osmo-hlr_1.6.0.6.390f.tar.xz/src/lu_fsm.c -> osmo-hlr_1.6.0.7.2989.tar.xz/src/lu_fsm.c Changed

Changes of Revision 18