Osmocom Open Build Service

open5gs_2.4.11.10.a99a7.202210070002.dsc -> open5gs_2.4.11.12.3955.202210080002.dsc Changed

@@ -2,7 +2,7 @@
 Source: open5gs
 Binary: open5gs-common, open5gs-mme, open5gs-sgwc, open5gs-smf, open5gs-amf, open5gs-sgwu, open5gs-upf, open5gs-hss, open5gs-pcrf, open5gs-nrf, open5gs-ausf, open5gs-udm, open5gs-pcf, open5gs-nssf, open5gs-bsf, open5gs-udr, open5gs, open5gs-dbg
 Architecture: any
-Version: 2.4.11.10.a99a7.202210070002
+Version: 2.4.11.12.3955.202210080002
 Maintainer: Harald Welte <laforge@gnumonks.org>
 Uploaders: Sukchan Lee <acetcom@gmail.com>
 Homepage: https://open5gs.org
@@ -30,8 +30,8 @@
  open5gs-udr deb net optional arch=any
  open5gs-upf deb net optional arch=any
 Checksums-Sha1:
- 9adbfeb799d22e31426536422c9c6b005c01c02a 11471192 open5gs_2.4.11.10.a99a7.202210070002.tar.xz
+ 8b02399cea29e412b070f26cc2f3e07b4824e5d3 11471676 open5gs_2.4.11.12.3955.202210080002.tar.xz
 Checksums-Sha256:
- 65c83ea2122c88e2708419db0ade358fb9449c13b55a8e0bf81f1dc2e59a56d1 11471192 open5gs_2.4.11.10.a99a7.202210070002.tar.xz
+ 8d4f5e0c652a20bf02383f21fad4b935e4d028d93064eb637cb5e78e47a61e2e 11471676 open5gs_2.4.11.12.3955.202210080002.tar.xz
 Files:
- 03fc18cb8b0b8a11c2a7a29135383be3 11471192 open5gs_2.4.11.10.a99a7.202210070002.tar.xz
+ d5a0e8ebc87a35ced0af2f31e1df1ffd 11471676 open5gs_2.4.11.12.3955.202210080002.tar.xz

open5gs_2.4.11.10.a99a7.202210070002.tar.xz/.tarball-version -> open5gs_2.4.11.12.3955.202210080002.tar.xz/.tarball-version Changed

open5gs_2.4.11.10.a99a7.202210070002.tar.xz/debian/changelog -> open5gs_2.4.11.12.3955.202210080002.tar.xz/debian/changelog Changed

open5gs_2.4.11.10.a99a7.202210070002.tar.xz/src/mme/mme-path.c -> open5gs_2.4.11.12.3955.202210080002.tar.xz/src/mme/mme-path.c Changed

open5gs_2.4.11.10.a99a7.202210070002.tar.xz/src/mme/mme-s6a-handler.c -> open5gs_2.4.11.12.3955.202210080002.tar.xz/src/mme/mme-s6a-handler.c Changed

@@ -226,15 +226,35 @@
     switch (clr_message->cancellation_type) {
     case OGS_DIAM_S6A_CT_SUBSCRIPTION_WITHDRAWL:
         mme_ue->detach_type = MME_DETACH_TYPE_HSS_EXPLICIT;
+
+        /*
+         * Before sending Detach-Request,
+         * we need to check whether UE is IDLE or not.
+         */
         if (ECM_IDLE(mme_ue)) {
             MME_STORE_PAGING_INFO(mme_ue, MME_PAGING_TYPE_DETACH_TO_UE, NULL);
             ogs_assert(OGS_OK == s1ap_send_paging(mme_ue, S1AP_CNDomain_ps));
         } else {
             ogs_assert(OGS_OK == nas_eps_send_detach_request(mme_ue));
+            if (MME_P_TMSI_IS_AVAILABLE(mme_ue)) {
+                ogs_assert(OGS_OK == sgsap_send_detach_indication(mme_ue));
+            } else {
+                mme_send_delete_session_or_detach(mme_ue);
+            }
         }
         break;
     case OGS_DIAM_S6A_CT_MME_UPDATE_PROCEDURE:
         mme_ue->detach_type = MME_DETACH_TYPE_HSS_IMPLICIT;
+
+        /*
+         * There is no need to send NAS or S1AP message to the UE.
+         * So, we don't have to check whether UE is IDLE or not.
+         */
+        if (MME_P_TMSI_IS_AVAILABLE(mme_ue)) {
+            ogs_assert(OGS_OK == sgsap_send_detach_indication(mme_ue));
+        } else {
+            mme_send_delete_session_or_detach(mme_ue);
+        }
         break;
     default:
         ogs_fatal("Unsupported Cancellation-Type %d",
@@ -242,12 +262,6 @@
         ogs_assert_if_reached();
         break;
     }
-
-    if (MME_P_TMSI_IS_AVAILABLE(mme_ue)) {
-        ogs_assert(OGS_OK == sgsap_send_detach_indication(mme_ue));
-    } else {
-        mme_send_delete_session_or_detach(mme_ue);
-    }
 }
 
 static uint8_t mme_ue_session_from_slice_data(mme_ue_t *mme_ue,

open5gs_2.4.11.10.a99a7.202210070002.tar.xz/src/smf/n4-handler.c -> open5gs_2.4.11.12.3955.202210080002.tar.xz/src/smf/n4-handler.c Changed

@@ -1117,7 +1117,7 @@
 
     ogs_debug("Session Report Request");
 
-    cause_value = OGS_GTP2_CAUSE_REQUEST_ACCEPTED;
+    cause_value = OGS_PFCP_CAUSE_REQUEST_ACCEPTED;
 
     if (!sess) {
         ogs_error("No Context");
@@ -1126,10 +1126,10 @@
 
     if (pfcp_req->report_type.presence == 0) {
         ogs_error("No Report Type");
-        cause_value = OGS_GTP2_CAUSE_MANDATORY_IE_MISSING;
+        cause_value = OGS_PFCP_CAUSE_MANDATORY_IE_MISSING;
     }
 
-    if (cause_value != OGS_GTP2_CAUSE_REQUEST_ACCEPTED) {
+    if (cause_value != OGS_PFCP_CAUSE_REQUEST_ACCEPTED) {
         ogs_pfcp_send_error_message(pfcp_xact, 0,
                 OGS_PFCP_SESSION_REPORT_RESPONSE_TYPE,
                 cause_value, 0);
@@ -1168,14 +1168,19 @@
                                 "Paging Policy Indication Value");
                         ogs_pfcp_send_error_message(pfcp_xact, 0,
                                 OGS_PFCP_SESSION_REPORT_RESPONSE_TYPE,
-                                OGS_GTP2_CAUSE_SERVICE_NOT_SUPPORTED, 0);
+                                OGS_PFCP_CAUSE_SERVICE_NOT_SUPPORTED, 0);
                         return;
                     }
 
                     if (qfi) {
                         qos_flow = smf_qos_flow_find_by_qfi(sess, qfi);
-                        if (!qos_flow)
+                        if (!qos_flow) {
                             ogs_error("Cannot find the QoS Flow%d", qfi);
+                            ogs_pfcp_send_error_message(pfcp_xact, 0,
+                                OGS_PFCP_SESSION_REPORT_RESPONSE_TYPE,
+                                OGS_PFCP_CAUSE_SESSION_CONTEXT_NOT_FOUND, 0);
+                            return;
+                        }
                     }
                 } else {
                     ogs_error("No Info");
@@ -1187,7 +1192,6 @@
                     pfcp_req->downlink_data_report.pdr_id.u16);
                 if (!pdr)
                     ogs_error("Cannot find the PDR-ID%d", pdr_id);
-
             } else {
                 ogs_error("No PDR-ID");
             }
@@ -1195,11 +1199,11 @@
             ogs_error("No Downlink Data Report");
         }
 
-        if (!pdr || !qos_flow) {
-            ogs_error("No Context %p:%p", pdr, qos_flow);
+        if (!pdr) {
+            ogs_error("No Context");
             ogs_pfcp_send_error_message(pfcp_xact, 0,
                     OGS_PFCP_SESSION_REPORT_RESPONSE_TYPE,
-                    cause_value, 0);
+                    OGS_PFCP_CAUSE_SESSION_CONTEXT_NOT_FOUND, 0);
             return;
         }

Changes of Revision 104