Osmocom Open Build Service

Changes of Revision 1349

open5gs_2.7.6.4891.fba2.202603011800.dsc -> open5gs_2.7.6.4892.209a.202603021800.dsc Changed

@@ -2,7 +2,7 @@
 Source: open5gs
 Binary: open5gs-common, open5gs-mme, open5gs-sgwc, open5gs-smf, open5gs-amf, open5gs-sgwu, open5gs-upf, open5gs-hss, open5gs-pcrf, open5gs-nrf, open5gs-scp, open5gs-sepp, open5gs-ausf, open5gs-udm, open5gs-pcf, open5gs-nssf, open5gs-bsf, open5gs-udr, open5gs, open5gs-dbg
 Architecture: any
-Version: 2.7.6.4891.fba2.202603011800
+Version: 2.7.6.4892.209a.202603021800
 Maintainer: Harald Welte <laforge@gnumonks.org>
 Uploaders: Sukchan Lee <acetcom@gmail.com>
 Homepage: https://open5gs.org
@@ -32,8 +32,8 @@
  open5gs-udr deb net optional arch=any
  open5gs-upf deb net optional arch=any
 Checksums-Sha1:
- e600cd87c1fe7c5b4b7b0be3ba2934c343e28684 15128080 open5gs_2.7.6.4891.fba2.202603011800.tar.xz
+ ca614bae9e33be2579404844864c307838157a5b 15127932 open5gs_2.7.6.4892.209a.202603021800.tar.xz
 Checksums-Sha256:
- e861dea45087bdf875e0f326f3a9f7e4b22fabb05c22b654295eed4baf13f6eb 15128080 open5gs_2.7.6.4891.fba2.202603011800.tar.xz
+ a78fd9535135b4160f6ead7c7589c55d345b95029e9e8f86f99bcbabeeef6be8 15127932 open5gs_2.7.6.4892.209a.202603021800.tar.xz
 Files:
- f9778642a59755cd7fb1d7fdcb318cdd 15128080 open5gs_2.7.6.4891.fba2.202603011800.tar.xz
+ 91643e2fa36bc9745ef2f5e729528c50 15127932 open5gs_2.7.6.4892.209a.202603021800.tar.xz

open5gs_2.7.6.4891.fba2.202603011800.tar.xz/.tarball-version -> open5gs_2.7.6.4892.209a.202603021800.tar.xz/.tarball-version Changed

open5gs_2.7.6.4891.fba2.202603011800.tar.xz/debian/changelog -> open5gs_2.7.6.4892.209a.202603021800.tar.xz/debian/changelog Changed

open5gs_2.7.6.4891.fba2.202603011800.tar.xz/src/smf/gn-handler.c -> open5gs_2.7.6.4892.209a.202603021800.tar.xz/src/smf/gn-handler.c Changed

@@ -109,6 +109,10 @@
         ogs_error("No User Location Info");
         cause_value = OGS_GTP1_CAUSE_MANDATORY_IE_MISSING;
     }
+    if (req->end_user_address.presence == 0) {
+        ogs_error("No End User Address");
+        cause_value = OGS_GTP1_CAUSE_MANDATORY_IE_MISSING;
+    }
 
     if (!ogs_diam_is_relay_or_app_advertised(OGS_DIAM_GX_APPLICATION_ID)) {
         ogs_error("No Gx Diameter Peer");
@@ -137,7 +141,10 @@
     rv = ogs_gtp1_gsn_addr_to_ip(req->sgsn_address_for_signalling.data,
                                  req->sgsn_address_for_signalling.len,
                                   &sess->sgw_s5c_ip);
-    ogs_assert(rv == OGS_OK);
+    if (rv != OGS_OK) {
+        ogs_error("Invalid SGSN Address for signalling");
+        return OGS_GTP1_CAUSE_MANDATORY_IE_INCORRECT;
+    }
     ogs_debug("    SGW_S5C_TEID0x%x SMF_N4_TEID0x%x",
             sess->sgw_s5c_teid, sess->smf_n4_teid);
 
@@ -246,8 +253,10 @@
     ogs_assert(eua);
     rv = ogs_gtp1_eua_to_ip(eua, req->end_user_address.len, &sess->session.ue_ip,
             &sess->ue_session_type);
-    if(rv != OGS_OK)
+    if (rv != OGS_OK) {
+        ogs_error("Invalid End User Address");
         return OGS_GTP1_CAUSE_MANDATORY_IE_INCORRECT;
+    }
 
     /* Initially Set Session Type from UE */
     sess->session.session_type = sess->ue_session_type;
@@ -269,7 +278,10 @@
     rv = ogs_gtp1_gsn_addr_to_ip(req->sgsn_address_for_user_traffic.data,
                                  req->sgsn_address_for_user_traffic.len,
                                  &bearer->sgw_s5u_ip);
-    ogs_assert(rv == OGS_OK);
+    if (rv != OGS_OK) {
+        ogs_error("Invalid SGSN Address for user traffic");
+        return OGS_GTP1_CAUSE_MANDATORY_IE_INCORRECT;
+    }
     ogs_debug("    SGW_S5U_TEID0x%x PGW_S5U_TEID0x%x",
             bearer->sgw_s5u_teid, bearer->pgw_s5u_teid);
     if (qos_pdec->data_octet6_to_13_present) {
@@ -424,8 +436,14 @@
         sess->sgw_s5c_teid = req->tunnel_endpoint_identifier_control_plane.u32;
         rv = ogs_gtp1_gsn_addr_to_ip(req->sgsn_address_for_control_plane.data,
                                      req->sgsn_address_for_control_plane.len,
-                                      &sess->sgw_s5c_ip);
-        ogs_assert(rv == OGS_OK);
+                                     &sess->sgw_s5c_ip);
+        if (rv != OGS_OK) {
+            ogs_error("Invalid SGSN Address for control plane");
+            ogs_gtp1_send_error_message(xact, sess->sgw_s5c_teid,
+                    OGS_GTP1_UPDATE_PDP_CONTEXT_RESPONSE_TYPE,
+                    OGS_GTP1_CAUSE_MANDATORY_IE_INCORRECT);
+            return;
+        }
         ogs_debug("    Updated SGW_S5C_TEID0x%x SMF_N4_TEID0x%x",
                 sess->sgw_s5c_teid, sess->smf_n4_teid);
     }
@@ -435,7 +453,14 @@
     rv = ogs_gtp1_gsn_addr_to_ip(req->sgsn_address_for_user_traffic.data,
                                  req->sgsn_address_for_user_traffic.len,
                                  &bearer->sgw_s5u_ip);
-    ogs_assert(rv == OGS_OK);
+
+    if (rv != OGS_OK) {
+        ogs_error("Invalid SGSN Address for user traffic");
+        ogs_gtp1_send_error_message(xact, sess->sgw_s5c_teid,
+                OGS_GTP1_UPDATE_PDP_CONTEXT_RESPONSE_TYPE,
+                OGS_GTP1_CAUSE_MANDATORY_IE_INCORRECT);
+        return;
+    }
     ogs_debug("    Updated SGW_S5U_TEID0x%x PGW_S5U_TEID0x%x",
             bearer->sgw_s5u_teid, bearer->pgw_s5u_teid);
 
@@ -445,6 +470,7 @@
     qos_pdec = &sess->gtp.v1.qos_pdec;
     rv = ogs_gtp1_parse_qos_profile(qos_pdec, &req->quality_of_service_profile);
     if(rv < 0) {
+        ogs_error("ogs_gtp1_parse_qos_profile() failed");
         ogs_gtp1_send_error_message(xact, sess->sgw_s5c_teid,
                 OGS_GTP1_UPDATE_PDP_CONTEXT_RESPONSE_TYPE,
                 OGS_GTP1_CAUSE_MANDATORY_IE_INCORRECT);
@@ -499,7 +525,7 @@
     /* Update remote TEID and GTP-U IP address on the UPF. UpdatePDPContextResp
      * will be sent when UPF answers back this request
      */
-     ogs_list_for_each(&sess->pfcp.pdr_list, pdr) {
+    ogs_list_for_each(&sess->pfcp.pdr_list, pdr) {
         ogs_pfcp_far_t *far = pdr->far;
         ogs_assert(far);
 
@@ -510,10 +536,17 @@
             continue;
 
         if (pdr->id == bearer->dl_pdr->id) {
-            rv = ogs_pfcp_ip_to_outer_header_creation(&bearer->sgw_s5u_ip,
-                                                &far->outer_header_creation,
-                                                &far->outer_header_creation_len);
-            ogs_assert(rv == OGS_OK);
+            rv = ogs_pfcp_ip_to_outer_header_creation(
+                    &bearer->sgw_s5u_ip,
+                    &far->outer_header_creation,
+                    &far->outer_header_creation_len);
+            if (rv != OGS_OK) {
+                ogs_error("PFCP outer header creation failed");
+                ogs_gtp1_send_error_message(xact, sess->sgw_s5c_teid,
+                        OGS_GTP1_UPDATE_PDP_CONTEXT_RESPONSE_TYPE,
+                        OGS_GTP1_CAUSE_SYSTEM_FAILURE);
+                return;
+            }
             far->outer_header_creation.teid = bearer->sgw_s5u_teid;
         }
     }
@@ -522,7 +555,13 @@
             OGS_PFCP_MODIFY_DL_ONLY|OGS_PFCP_MODIFY_ACTIVATE,
             OGS_NAS_PROCEDURE_TRANSACTION_IDENTITY_UNASSIGNED,
             OGS_GTP1_CAUSE_REACTIACTION_REQUESTED);
-    ogs_assert(rv == OGS_OK);
+    if (rv != OGS_OK) {
+        ogs_error("PFCP Session Modification Request failed");
+        ogs_gtp1_send_error_message(xact, sess->sgw_s5c_teid,
+                OGS_GTP1_UPDATE_PDP_CONTEXT_RESPONSE_TYPE,
+                OGS_GTP1_CAUSE_SYSTEM_FAILURE);
+        return;
+    }
 
     /* TODO: TS 29.061: Upon reception of an UpdatePDPContextRequest from the
        SGSN, the GGSN may send an Accounting Request (Interim) to the Diameter