Changes of Revision 7

open5gs_2.4.8.202207010002.dsc -> open5gs_2.4.8.202207020002.dsc Changed
x
 
1
@@ -2,7 +2,7 @@
2
 Source: open5gs
3
 Binary: open5gs-common, open5gs-mme, open5gs-sgwc, open5gs-smf, open5gs-amf, open5gs-sgwu, open5gs-upf, open5gs-hss, open5gs-pcrf, open5gs-nrf, open5gs-ausf, open5gs-udm, open5gs-pcf, open5gs-nssf, open5gs-bsf, open5gs-udr, open5gs, open5gs-dbg
4
 Architecture: any
5
-Version: 2.4.8.202207010002
6
+Version: 2.4.8.202207020002
7
 Maintainer: Harald Welte <laforge@gnumonks.org>
8
 Uploaders: Sukchan Lee <acetcom@gmail.com>
9
 Homepage: https://open5gs.org
10
@@ -30,8 +30,8 @@
11
  open5gs-udr deb net optional arch=any
12
  open5gs-upf deb net optional arch=any
13
 Checksums-Sha1:
14
- fc5dd83e6e1531f4819b9b29515e9a95b6679fd5 11444060 open5gs_2.4.8.202207010002.tar.xz
15
+ 21d4477859f767e7d0d5facb3f3217e7afe1263f 11444376 open5gs_2.4.8.202207020002.tar.xz
16
 Checksums-Sha256:
17
- 52963ee9bf7ce27f5fe1de65b86b152cdcc0ff54d6811302976f0cffa73e2d01 11444060 open5gs_2.4.8.202207010002.tar.xz
18
+ f45d52e0c66b18a60cb5d2b663c092fa43e657421799e3175be99d5e0347014d 11444376 open5gs_2.4.8.202207020002.tar.xz
19
 Files:
20
- 00282b87d56da28014e0d41348c65f67 11444060 open5gs_2.4.8.202207010002.tar.xz
21
+ 400768a21f9864506213981a76393e16 11444376 open5gs_2.4.8.202207020002.tar.xz
22
open5gs_2.4.8.202207020002.tar.xz/.clang-tidy Added
71
 
1
@@ -0,0 +1,69 @@
2
+---
3
+Checks: '*,
4
+  -altera-id-dependent-backward-branch,
5
+  -altera-struct-pack-align,
6
+  -altera-unroll-loops,
7
+  -android-cloexec-*,
8
+  -bugprone-branch-clone,
9
+  -bugprone-easily-swappable-parameters,
10
+  -bugprone-macro-parentheses,
11
+  -bugprone-reserved-identifier,
12
+  -bugprone-sizeof-expression,
13
+  -cert-dcl37-c,
14
+  -cert-dcl51-cpp,
15
+  -cert-err33-c,
16
+  -cert-err34-c,
17
+  -clang-analyzer-optin.performance.Padding,
18
+  -clang-analyzer-security.insecureAPI.bcmp,
19
+  -clang-analyzer-security.insecureAPI.bcopy,
20
+  -clang-analyzer-security.insecureAPI.bzero,
21
+  -clang-diagnostic-error,
22
+  -clang-diagnostic-typedef-redefinition,
23
+  -clang-diagnostic-unknown-warning-option,
24
+  -concurrency-mt-unsafe,
25
+  -cppcoreguidelines-avoid-magic-numbers,
26
+  -cppcoreguidelines-avoid-non-const-global-variables,
27
+  -cppcoreguidelines-init-variables,
28
+  -google-readability-braces-around-statements,
29
+  -google-readability-casting,
30
+  -google-readability-function-size,
31
+  -google-readability-todo,
32
+  -hicpp-braces-around-statements,
33
+  -hicpp-function-size,
34
+  -hicpp-multiway-paths-covered,
35
+  -llvm-else-after-return,
36
+  -llvm-header-guard,
37
+  -llvm-include-order,
38
+  -llvmlibc-restrict-system-libc-headers,
39
+  -misc-no-recursion,
40
+  -misc-unused-parameters,
41
+  -performance-no-int-to-ptr,
42
+  -readability-avoid-const-params-in-decls,
43
+  -readability-braces-around-statements,
44
+  -readability-duplicate-include,
45
+  -readability-else-after-return,
46
+  -readability-function-cognitive-complexity,
47
+  -readability-function-size,
48
+  -readability-identifier-length,
49
+  -readability-isolate-declaration,
50
+  -readability-magic-numbers,
51
+  -readability-non-const-parameter,
52
+  -readability-redundant-control-flow,
53
+  -readability-redundant-declaration,
54
+  -readability-suspicious-call-argument,
55
+
56
+
57
+  -bugprone-implicit-widening-of-multiplication-result,
58
+  -bugprone-narrowing-conversions,
59
+  -cert-exp42-c,
60
+  -cert-flp37-c,
61
+  -clang-analyzer-core.NullDereference,
62
+  -clang-analyzer-deadcode.DeadStores,
63
+  -clang-analyzer-security.insecureAPI.strcpy,
64
+  -cppcoreguidelines-interfaces-global-init,
65
+  -cppcoreguidelines-narrowing-conversions,
66
+  -hicpp-signed-bitwise,
67
+  '
68
+
69
+WarningsAsErrors: false
70
+HeaderFilterRegex: '(.*\.h)'
71
open5gs_2.4.8.202207010002.tar.xz/debian/changelog -> open5gs_2.4.8.202207020002.tar.xz/debian/changelog Changed
12
 
1
@@ -1,8 +1,8 @@
2
-open5gs (2.4.8.202207010002) UNRELEASED; urgency=medium
3
+open5gs (2.4.8.202207020002) UNRELEASED; urgency=medium
4
 
5
   * Snapshot build
6
 
7
- -- Sukchan Lee <acetcom@gmail.com>  Fri, 01 Jul 2022 00:09:11 +0000
8
+ -- Sukchan Lee <acetcom@gmail.com>  Sat, 02 Jul 2022 00:09:11 +0000
9
 
10
 open5gs (2.4.8) unstable; urgency=medium
11
 
12
open5gs_2.4.8.202207010002.tar.xz/debian/control -> open5gs_2.4.8.202207020002.tar.xz/debian/control Changed
163
 
1
@@ -31,7 +31,7 @@
2
 Package: open5gs-common
3
 Architecture: any
4
 Multi-Arch: same
5
-Depends: osmocom-nightly (= 1.0.0.202207010002), ${shlibs:Depends},
6
+Depends: osmocom-nightly (= 1.0.0.202207020002), ${shlibs:Depends},
7
          ${misc:Depends}
8
 Description: 5G Core and EPC (Shared Files)
9
  Open5GS is a C-language implementation of 5G Core and EPC
10
@@ -43,7 +43,7 @@
11
 Package: open5gs-mme
12
 Architecture: any
13
 Multi-Arch: same
14
-Depends: osmocom-nightly (= 1.0.0.202207010002), ${shlibs:Depends},
15
+Depends: osmocom-nightly (= 1.0.0.202207020002), ${shlibs:Depends},
16
          ${misc:Depends},
17
          open5gs-common (= ${binary:Version})
18
 Description: MME (Mobility Management Entity)
19
@@ -58,7 +58,7 @@
20
 Package: open5gs-sgwc
21
 Architecture: any
22
 Multi-Arch: same
23
-Depends: osmocom-nightly (= 1.0.0.202207010002), ${shlibs:Depends},
24
+Depends: osmocom-nightly (= 1.0.0.202207020002), ${shlibs:Depends},
25
          ${misc:Depends},
26
          open5gs-common (= ${binary:Version})
27
 Description: SGW-C (Serving Gateway - Control Plane)
28
@@ -72,7 +72,7 @@
29
 Package: open5gs-smf
30
 Architecture: any
31
 Multi-Arch: same
32
-Depends: osmocom-nightly (= 1.0.0.202207010002), ${shlibs:Depends},
33
+Depends: osmocom-nightly (= 1.0.0.202207020002), ${shlibs:Depends},
34
          ${misc:Depends},
35
          open5gs-common (= ${binary:Version})
36
 Description: SMF (Session Management Function)
37
@@ -84,7 +84,7 @@
38
 Package: open5gs-amf
39
 Architecture: any
40
 Multi-Arch: same
41
-Depends: osmocom-nightly (= 1.0.0.202207010002), ${shlibs:Depends},
42
+Depends: osmocom-nightly (= 1.0.0.202207020002), ${shlibs:Depends},
43
          ${misc:Depends},
44
          open5gs-common (= ${binary:Version})
45
 Description: AMF (Access and Mobility Management Function)
46
@@ -96,7 +96,7 @@
47
 Package: open5gs-sgwu
48
 Architecture: any
49
 Multi-Arch: same
50
-Depends: osmocom-nightly (= 1.0.0.202207010002), ${shlibs:Depends},
51
+Depends: osmocom-nightly (= 1.0.0.202207020002), ${shlibs:Depends},
52
          ${misc:Depends},
53
          open5gs-common (= ${binary:Version})
54
 Description: SGW-U (Serving Gateway - User Plane)
55
@@ -110,7 +110,7 @@
56
 Package: open5gs-upf
57
 Architecture: any
58
 Multi-Arch: same
59
-Depends: osmocom-nightly (= 1.0.0.202207010002), ${shlibs:Depends},
60
+Depends: osmocom-nightly (= 1.0.0.202207020002), ${shlibs:Depends},
61
          ${misc:Depends},
62
          udev,
63
          open5gs-common (= ${binary:Version})
64
@@ -123,7 +123,7 @@
65
 Package: open5gs-hss
66
 Architecture: any
67
 Multi-Arch: same
68
-Depends: osmocom-nightly (= 1.0.0.202207010002), ${shlibs:Depends},
69
+Depends: osmocom-nightly (= 1.0.0.202207020002), ${shlibs:Depends},
70
          ${misc:Depends},
71
          mongodb-org | mongodb,
72
          open5gs-common (= ${binary:Version})
73
@@ -140,7 +140,7 @@
74
 Package: open5gs-pcrf
75
 Architecture: any
76
 Multi-Arch: same
77
-Depends: osmocom-nightly (= 1.0.0.202207010002), ${shlibs:Depends},
78
+Depends: osmocom-nightly (= 1.0.0.202207020002), ${shlibs:Depends},
79
          ${misc:Depends},
80
          mongodb-org | mongodb,
81
          open5gs-common (= ${binary:Version})
82
@@ -156,7 +156,7 @@
83
 Package: open5gs-nrf
84
 Architecture: any
85
 Multi-Arch: same
86
-Depends: osmocom-nightly (= 1.0.0.202207010002), ${shlibs:Depends},
87
+Depends: osmocom-nightly (= 1.0.0.202207020002), ${shlibs:Depends},
88
          ${misc:Depends},
89
          open5gs-common (= ${binary:Version})
90
 Description: NRF (Network Repository Function)
91
@@ -168,7 +168,7 @@
92
 Package: open5gs-ausf
93
 Architecture: any
94
 Multi-Arch: same
95
-Depends: osmocom-nightly (= 1.0.0.202207010002), ${shlibs:Depends},
96
+Depends: osmocom-nightly (= 1.0.0.202207020002), ${shlibs:Depends},
97
          ${misc:Depends},
98
          open5gs-common (= ${binary:Version})
99
 Description: AUSF (Authentication Server Function)
100
@@ -180,7 +180,7 @@
101
 Package: open5gs-udm
102
 Architecture: any
103
 Multi-Arch: same
104
-Depends: osmocom-nightly (= 1.0.0.202207010002), ${shlibs:Depends},
105
+Depends: osmocom-nightly (= 1.0.0.202207020002), ${shlibs:Depends},
106
          ${misc:Depends},
107
          open5gs-common (= ${binary:Version})
108
 Description: UDM (Unified Data Management)
109
@@ -192,7 +192,7 @@
110
 Package: open5gs-pcf
111
 Architecture: any
112
 Multi-Arch: same
113
-Depends: osmocom-nightly (= 1.0.0.202207010002), ${shlibs:Depends},
114
+Depends: osmocom-nightly (= 1.0.0.202207020002), ${shlibs:Depends},
115
          ${misc:Depends},
116
          open5gs-common (= ${binary:Version})
117
 Description: PCF (Policy Control Function)
118
@@ -204,7 +204,7 @@
119
 Package: open5gs-nssf
120
 Architecture: any
121
 Multi-Arch: same
122
-Depends: osmocom-nightly (= 1.0.0.202207010002), ${shlibs:Depends},
123
+Depends: osmocom-nightly (= 1.0.0.202207020002), ${shlibs:Depends},
124
          ${misc:Depends},
125
          open5gs-common (= ${binary:Version})
126
 Description: NSSF (Network Slice Selection Function)
127
@@ -216,7 +216,7 @@
128
 Package: open5gs-bsf
129
 Architecture: any
130
 Multi-Arch: same
131
-Depends: osmocom-nightly (= 1.0.0.202207010002), ${shlibs:Depends},
132
+Depends: osmocom-nightly (= 1.0.0.202207020002), ${shlibs:Depends},
133
          ${misc:Depends},
134
          open5gs-common (= ${binary:Version})
135
 Description: BSF (Binding Support Function)
136
@@ -228,7 +228,7 @@
137
 Package: open5gs-udr
138
 Architecture: any
139
 Multi-Arch: same
140
-Depends: osmocom-nightly (= 1.0.0.202207010002), ${shlibs:Depends},
141
+Depends: osmocom-nightly (= 1.0.0.202207020002), ${shlibs:Depends},
142
          ${misc:Depends},
143
          open5gs-common (= ${binary:Version})
144
 Description: UDR (Unified Data Repository)
145
@@ -240,7 +240,7 @@
146
 Package: open5gs
147
 Architecture: any
148
 Multi-Arch: same
149
-Depends: osmocom-nightly (= 1.0.0.202207010002), ${misc:Depends},
150
+Depends: osmocom-nightly (= 1.0.0.202207020002), ${misc:Depends},
151
          open5gs-common (= ${binary:Version}),
152
          open5gs-mme (= ${binary:Version}),
153
          open5gs-sgwc (= ${binary:Version}),
154
@@ -266,7 +266,7 @@
155
 Package: open5gs-dbg
156
 Architecture: any
157
 Multi-Arch: same
158
-Depends: osmocom-nightly (= 1.0.0.202207010002), ${misc:Depends},
159
+Depends: osmocom-nightly (= 1.0.0.202207020002), ${misc:Depends},
160
          open5gs (= ${binary:Version})
161
 Description: Debug symbols for Open5GS
162
  Open5GS is a C-language implementation of 5G Core and EPC
163
open5gs_2.4.8.202207010002.tar.xz/lib/app/ogs-config.h -> open5gs_2.4.8.202207020002.tar.xz/lib/app/ogs-config.h Changed
10
 
1
@@ -29,7 +29,7 @@
2
 #endif
3
 
4
 int ogs_app_config_parse_sockopt(
5
-        ogs_yaml_iter_t *parent, ogs_sockopt_t *sockopt);
6
+        ogs_yaml_iter_t *parent, ogs_sockopt_t *option);
7
 
8
 #ifdef __cplusplus
9
 }
10
open5gs_2.4.8.202207010002.tar.xz/lib/core/ogs-pkbuf.c -> open5gs_2.4.8.202207020002.tar.xz/lib/core/ogs-pkbuf.c Changed
17
 
1
@@ -297,11 +297,13 @@
2
 {
3
 #if OGS_USE_TALLOC
4
     ogs_pkbuf_t *newbuf;
5
-    int size = pkbuf->end - pkbuf->head;
6
+    int size = 0;
7
 
8
+    ogs_assert(pkbuf);
9
+    size = pkbuf->end - pkbuf->head;
10
     ogs_assert(size > 0);
11
     newbuf = ogs_pkbuf_alloc_debug(NULL, size, file_line);
12
-    if (!pkbuf) {
13
+    if (!newbuf) {
14
         ogs_error("ogs_pkbuf_alloc() failed size=%d", size);
15
         return NULL;
16
     }
17
open5gs_2.4.8.202207010002.tar.xz/lib/core/ogs-process.h -> open5gs_2.4.8.202207020002.tar.xz/lib/core/ogs-process.h Changed
10
 
1
@@ -84,7 +84,7 @@
2
     ogs_proc_option_inherit_environment = 0x2
3
 };
4
 
5
-int ogs_proc_create(const char *const command_line, int options,
6
+int ogs_proc_create(const char *const commandLine, int options,
7
                     ogs_proc_t *const out_process);
8
 
9
 FILE *ogs_proc_stdin(const ogs_proc_t *const process);
10
open5gs_2.4.8.202207010002.tar.xz/lib/core/ogs-sockaddr.h -> open5gs_2.4.8.202207020002.tar.xz/lib/core/ogs-sockaddr.h Changed
15
 
1
@@ -99,10 +99,10 @@
2
     ogs_inet_ntop(__aDDR, __bUF, OGS_ADDRSTRLEN)
3
 #define OGS_PORT(__aDDR) \
4
     be16toh((__aDDR)->ogs_sin_port)
5
-const char *ogs_inet_ntop(void *addr, char *buf, int buflen);
6
-int ogs_inet_pton(int family, const char *src, void *addr);
7
+const char *ogs_inet_ntop(void *sa, char *buf, int buflen);
8
+int ogs_inet_pton(int family, const char *src, void *sa);
9
 
10
-socklen_t ogs_sockaddr_len(const void *addr);
11
+socklen_t ogs_sockaddr_len(const void *sa);
12
 bool ogs_sockaddr_is_equal(void *p, void *q);
13
 
14
 int ogs_ipsubnet(ogs_ipsubnet_t *ipsub,
15
open5gs_2.4.8.202207010002.tar.xz/lib/crypt/ogs-base64.h -> open5gs_2.4.8.202207020002.tar.xz/lib/crypt/ogs-base64.h Changed
23
 
1
@@ -43,16 +43,16 @@
2
 extern "C" {
3
 #endif
4
 
5
-int ogs_base64_decode_len(const char *coded_src);
6
-int ogs_base64_decode(char *plain_dst, const char *coded_src);
7
+int ogs_base64_decode_len(const char *bufcoded);
8
+int ogs_base64_decode(char *bufplain, const char *bufcoded);
9
 int ogs_base64_decode_binary(
10
-        unsigned char *plain_dst, const char *coded_src);
11
+        unsigned char *bufplain, const char *bufcoded);
12
 
13
 int ogs_base64_encode_len(int len);
14
 int ogs_base64_encode(
15
-        char *coded_dst, const char *plain_src, int len_plain_src);
16
+        char *encoded, const char *string, int len);
17
 int ogs_base64_encode_binary(
18
-        char *coded_dst, const unsigned char *plain_src, int len_plain_src);
19
+        char *encoded, const unsigned char *string, int len);
20
 
21
 #ifdef __cplusplus
22
 }
23
open5gs_2.4.8.202207010002.tar.xz/lib/gtp/v1/message.c -> open5gs_2.4.8.202207020002.tar.xz/lib/gtp/v1/message.c Changed
201
 
1
@@ -21,7 +21,7 @@
2
 /*******************************************************************************
3
  * This file had been created by gtp1-tlv.py script v0.1.0
4
  * Please do not modify this file but regenerate it via script.
5
- * Created on: 2022-05-12 14:42:38.611950 by pespin
6
+ * Created on: 2022-06-30 08:56:31.641366 by ubuntu
7
  * from 29060-g00.docx
8
  ******************************************************************************/
9
 
10
@@ -2264,20 +2264,20 @@
11
 }};
12
 
13
 
14
-int ogs_gtp1_parse_msg(ogs_gtp1_message_t *gtp_message, ogs_pkbuf_t *pkbuf)
15
+int ogs_gtp1_parse_msg(ogs_gtp1_message_t *gtp1_message, ogs_pkbuf_t *pkbuf)
16
 {
17
     int rv = OGS_ERROR;
18
     ogs_gtp1_header_t *h = NULL;
19
     uint16_t size = 0;
20
 
21
-    ogs_assert(gtp_message);
22
+    ogs_assert(gtp1_message);
23
     ogs_assert(pkbuf);
24
     ogs_assert(pkbuf->len);
25
 
26
     h = (ogs_gtp1_header_t *)pkbuf->data;
27
     ogs_assert(h);
28
 
29
-    memset(gtp_message, 0, sizeof(ogs_gtp1_message_t));
30
+    memset(gtp1_message, 0, sizeof(ogs_gtp1_message_t));
31
 
32
     if (h->e || h->s || h->pn)
33
         size = OGS_GTPV1C_HEADER_LEN;
34
@@ -2285,242 +2285,242 @@
35
         size = OGS_GTPV1C_HEADER_LEN - 4;
36
 
37
     ogs_assert(ogs_pkbuf_pull(pkbuf, size));
38
-    memcpy(&gtp_message->h, pkbuf->data - size, size);
39
+    memcpy(&gtp1_message->h, pkbuf->data - size, size);
40
 
41
-    gtp_message->h.teid = be32toh(gtp_message->h.teid);
42
+    gtp1_message->h.teid = be32toh(gtp1_message->h.teid);
43
 
44
     if (pkbuf->len == 0) {
45
         ogs_assert(ogs_pkbuf_push(pkbuf, size));
46
         return OGS_OK;
47
     }
48
 
49
-    switch(gtp_message->h.type) {
50
+    switch(gtp1_message->h.type) {
51
     case OGS_GTP1_ECHO_REQUEST_TYPE:
52
-        rv = ogs_tlv_parse_msg_desc(&gtp_message->echo_request,
53
+        rv = ogs_tlv_parse_msg_desc(&gtp1_message->echo_request,
54
                 &ogs_gtp1_tlv_desc_echo_request, pkbuf, OGS_TLV_MODE_T1_L2);
55
         break;
56
     case OGS_GTP1_ECHO_RESPONSE_TYPE:
57
-        rv = ogs_tlv_parse_msg_desc(&gtp_message->echo_response,
58
+        rv = ogs_tlv_parse_msg_desc(&gtp1_message->echo_response,
59
                 &ogs_gtp1_tlv_desc_echo_response, pkbuf, OGS_TLV_MODE_T1_L2);
60
         break;
61
     case OGS_GTP1_CREATE_PDP_CONTEXT_REQUEST_TYPE:
62
-        rv = ogs_tlv_parse_msg_desc(&gtp_message->create_pdp_context_request,
63
+        rv = ogs_tlv_parse_msg_desc(&gtp1_message->create_pdp_context_request,
64
                 &ogs_gtp1_tlv_desc_create_pdp_context_request, pkbuf, OGS_TLV_MODE_T1_L2);
65
         break;
66
     case OGS_GTP1_CREATE_PDP_CONTEXT_RESPONSE_TYPE:
67
-        rv = ogs_tlv_parse_msg_desc(&gtp_message->create_pdp_context_response,
68
+        rv = ogs_tlv_parse_msg_desc(&gtp1_message->create_pdp_context_response,
69
                 &ogs_gtp1_tlv_desc_create_pdp_context_response, pkbuf, OGS_TLV_MODE_T1_L2);
70
         break;
71
     case OGS_GTP1_UPDATE_PDP_CONTEXT_REQUEST_TYPE:
72
-        rv = ogs_tlv_parse_msg_desc(&gtp_message->update_pdp_context_request,
73
+        rv = ogs_tlv_parse_msg_desc(&gtp1_message->update_pdp_context_request,
74
                 &ogs_gtp1_tlv_desc_update_pdp_context_request, pkbuf, OGS_TLV_MODE_T1_L2);
75
         break;
76
     case OGS_GTP1_UPDATE_PDP_CONTEXT_RESPONSE_TYPE:
77
-        rv = ogs_tlv_parse_msg_desc(&gtp_message->update_pdp_context_response,
78
+        rv = ogs_tlv_parse_msg_desc(&gtp1_message->update_pdp_context_response,
79
                 &ogs_gtp1_tlv_desc_update_pdp_context_response, pkbuf, OGS_TLV_MODE_T1_L2);
80
         break;
81
     case OGS_GTP1_DELETE_PDP_CONTEXT_REQUEST_TYPE:
82
-        rv = ogs_tlv_parse_msg_desc(&gtp_message->delete_pdp_context_request,
83
+        rv = ogs_tlv_parse_msg_desc(&gtp1_message->delete_pdp_context_request,
84
                 &ogs_gtp1_tlv_desc_delete_pdp_context_request, pkbuf, OGS_TLV_MODE_T1_L2);
85
         break;
86
     case OGS_GTP1_DELETE_PDP_CONTEXT_RESPONSE_TYPE:
87
-        rv = ogs_tlv_parse_msg_desc(&gtp_message->delete_pdp_context_response,
88
+        rv = ogs_tlv_parse_msg_desc(&gtp1_message->delete_pdp_context_response,
89
                 &ogs_gtp1_tlv_desc_delete_pdp_context_response, pkbuf, OGS_TLV_MODE_T1_L2);
90
         break;
91
     case OGS_GTP1_INITIATE_PDP_CONTEXT_ACTIVATION_REQUEST_TYPE:
92
-        rv = ogs_tlv_parse_msg_desc(&gtp_message->initiate_pdp_context_activation_request,
93
+        rv = ogs_tlv_parse_msg_desc(&gtp1_message->initiate_pdp_context_activation_request,
94
                 &ogs_gtp1_tlv_desc_initiate_pdp_context_activation_request, pkbuf, OGS_TLV_MODE_T1_L2);
95
         break;
96
     case OGS_GTP1_INITIATE_PDP_CONTEXT_ACTIVATION_RESPONSE_TYPE:
97
-        rv = ogs_tlv_parse_msg_desc(&gtp_message->initiate_pdp_context_activation_response,
98
+        rv = ogs_tlv_parse_msg_desc(&gtp1_message->initiate_pdp_context_activation_response,
99
                 &ogs_gtp1_tlv_desc_initiate_pdp_context_activation_response, pkbuf, OGS_TLV_MODE_T1_L2);
100
         break;
101
     case OGS_GTP1_PDU_NOTIFICATION_REQUEST_TYPE:
102
-        rv = ogs_tlv_parse_msg_desc(&gtp_message->pdu_notification_request,
103
+        rv = ogs_tlv_parse_msg_desc(&gtp1_message->pdu_notification_request,
104
                 &ogs_gtp1_tlv_desc_pdu_notification_request, pkbuf, OGS_TLV_MODE_T1_L2);
105
         break;
106
     case OGS_GTP1_PDU_NOTIFICATION_RESPONSE_TYPE:
107
-        rv = ogs_tlv_parse_msg_desc(&gtp_message->pdu_notification_response,
108
+        rv = ogs_tlv_parse_msg_desc(&gtp1_message->pdu_notification_response,
109
                 &ogs_gtp1_tlv_desc_pdu_notification_response, pkbuf, OGS_TLV_MODE_T1_L2);
110
         break;
111
     case OGS_GTP1_PDU_NOTIFICATION_REJECT_REQUEST_TYPE:
112
-        rv = ogs_tlv_parse_msg_desc(&gtp_message->pdu_notification_reject_request,
113
+        rv = ogs_tlv_parse_msg_desc(&gtp1_message->pdu_notification_reject_request,
114
                 &ogs_gtp1_tlv_desc_pdu_notification_reject_request, pkbuf, OGS_TLV_MODE_T1_L2);
115
         break;
116
     case OGS_GTP1_PDU_NOTIFICATION_REJECT_RESPONSE_TYPE:
117
-        rv = ogs_tlv_parse_msg_desc(&gtp_message->pdu_notification_reject_response,
118
+        rv = ogs_tlv_parse_msg_desc(&gtp1_message->pdu_notification_reject_response,
119
                 &ogs_gtp1_tlv_desc_pdu_notification_reject_response, pkbuf, OGS_TLV_MODE_T1_L2);
120
         break;
121
     case OGS_GTP1_SUPPORTED_EXTENSION_HEADERS_NOTIFICATION_TYPE:
122
-        rv = ogs_tlv_parse_msg_desc(&gtp_message->supported_extension_headers_notification,
123
+        rv = ogs_tlv_parse_msg_desc(&gtp1_message->supported_extension_headers_notification,
124
                 &ogs_gtp1_tlv_desc_supported_extension_headers_notification, pkbuf, OGS_TLV_MODE_T1_L2);
125
         break;
126
     case OGS_GTP1_SEND_ROUTEING_INFORMATION_FOR_GPRS_REQUEST_TYPE:
127
-        rv = ogs_tlv_parse_msg_desc(&gtp_message->send_routeing_information_for_gprs_request,
128
+        rv = ogs_tlv_parse_msg_desc(&gtp1_message->send_routeing_information_for_gprs_request,
129
                 &ogs_gtp1_tlv_desc_send_routeing_information_for_gprs_request, pkbuf, OGS_TLV_MODE_T1_L2);
130
         break;
131
     case OGS_GTP1_SEND_ROUTEING_INFORMATION_FOR_GPRS_RESPONSE_TYPE:
132
-        rv = ogs_tlv_parse_msg_desc(&gtp_message->send_routeing_information_for_gprs_response,
133
+        rv = ogs_tlv_parse_msg_desc(&gtp1_message->send_routeing_information_for_gprs_response,
134
                 &ogs_gtp1_tlv_desc_send_routeing_information_for_gprs_response, pkbuf, OGS_TLV_MODE_T1_L2);
135
         break;
136
     case OGS_GTP1_FAILURE_REPORT_REQUEST_TYPE:
137
-        rv = ogs_tlv_parse_msg_desc(&gtp_message->failure_report_request,
138
+        rv = ogs_tlv_parse_msg_desc(&gtp1_message->failure_report_request,
139
                 &ogs_gtp1_tlv_desc_failure_report_request, pkbuf, OGS_TLV_MODE_T1_L2);
140
         break;
141
     case OGS_GTP1_FAILURE_REPORT_RESPONSE_TYPE:
142
-        rv = ogs_tlv_parse_msg_desc(&gtp_message->failure_report_response,
143
+        rv = ogs_tlv_parse_msg_desc(&gtp1_message->failure_report_response,
144
                 &ogs_gtp1_tlv_desc_failure_report_response, pkbuf, OGS_TLV_MODE_T1_L2);
145
         break;
146
     case OGS_GTP1_NOTE_MS_GPRS_PRESENT_REQUEST_TYPE:
147
-        rv = ogs_tlv_parse_msg_desc(&gtp_message->note_ms_gprs_present_request,
148
+        rv = ogs_tlv_parse_msg_desc(&gtp1_message->note_ms_gprs_present_request,
149
                 &ogs_gtp1_tlv_desc_note_ms_gprs_present_request, pkbuf, OGS_TLV_MODE_T1_L2);
150
         break;
151
     case OGS_GTP1_NOTE_MS_GPRS_PRESENT_RESPONSE_TYPE:
152
-        rv = ogs_tlv_parse_msg_desc(&gtp_message->note_ms_gprs_present_response,
153
+        rv = ogs_tlv_parse_msg_desc(&gtp1_message->note_ms_gprs_present_response,
154
                 &ogs_gtp1_tlv_desc_note_ms_gprs_present_response, pkbuf, OGS_TLV_MODE_T1_L2);
155
         break;
156
     case OGS_GTP1_IDENTIFICATION_REQUEST_TYPE:
157
-        rv = ogs_tlv_parse_msg_desc(&gtp_message->identification_request,
158
+        rv = ogs_tlv_parse_msg_desc(&gtp1_message->identification_request,
159
                 &ogs_gtp1_tlv_desc_identification_request, pkbuf, OGS_TLV_MODE_T1_L2);
160
         break;
161
     case OGS_GTP1_IDENTIFICATION_RESPONSE_TYPE:
162
-        rv = ogs_tlv_parse_msg_desc(&gtp_message->identification_response,
163
+        rv = ogs_tlv_parse_msg_desc(&gtp1_message->identification_response,
164
                 &ogs_gtp1_tlv_desc_identification_response, pkbuf, OGS_TLV_MODE_T1_L2);
165
         break;
166
     case OGS_GTP1_SGSN_CONTEXT_REQUEST_TYPE:
167
-        rv = ogs_tlv_parse_msg_desc(&gtp_message->sgsn_context_request,
168
+        rv = ogs_tlv_parse_msg_desc(&gtp1_message->sgsn_context_request,
169
                 &ogs_gtp1_tlv_desc_sgsn_context_request, pkbuf, OGS_TLV_MODE_T1_L2);
170
         break;
171
     case OGS_GTP1_SGSN_CONTEXT_RESPONSE_TYPE:
172
-        rv = ogs_tlv_parse_msg_desc(&gtp_message->sgsn_context_response,
173
+        rv = ogs_tlv_parse_msg_desc(&gtp1_message->sgsn_context_response,
174
                 &ogs_gtp1_tlv_desc_sgsn_context_response, pkbuf, OGS_TLV_MODE_T1_L2);
175
         break;
176
     case OGS_GTP1_SGSN_CONTEXT_ACKNOWLEDGE_TYPE:
177
-        rv = ogs_tlv_parse_msg_desc(&gtp_message->sgsn_context_acknowledge,
178
+        rv = ogs_tlv_parse_msg_desc(&gtp1_message->sgsn_context_acknowledge,
179
                 &ogs_gtp1_tlv_desc_sgsn_context_acknowledge, pkbuf, OGS_TLV_MODE_T1_L2);
180
         break;
181
     case OGS_GTP1_FORWARD_RELOCATION_REQUEST_TYPE:
182
-        rv = ogs_tlv_parse_msg_desc(&gtp_message->forward_relocation_request,
183
+        rv = ogs_tlv_parse_msg_desc(&gtp1_message->forward_relocation_request,
184
                 &ogs_gtp1_tlv_desc_forward_relocation_request, pkbuf, OGS_TLV_MODE_T1_L2);
185
         break;
186
     case OGS_GTP1_FORWARD_RELOCATION_RESPONSE_TYPE:
187
-        rv = ogs_tlv_parse_msg_desc(&gtp_message->forward_relocation_response,
188
+        rv = ogs_tlv_parse_msg_desc(&gtp1_message->forward_relocation_response,
189
                 &ogs_gtp1_tlv_desc_forward_relocation_response, pkbuf, OGS_TLV_MODE_T1_L2);
190
         break;
191
     case OGS_GTP1_FORWARD_RELOCATION_COMPLETE_TYPE:
192
-        rv = ogs_tlv_parse_msg_desc(&gtp_message->forward_relocation_complete,
193
+        rv = ogs_tlv_parse_msg_desc(&gtp1_message->forward_relocation_complete,
194
                 &ogs_gtp1_tlv_desc_forward_relocation_complete, pkbuf, OGS_TLV_MODE_T1_L2);
195
         break;
196
     case OGS_GTP1_RELOCATION_CANCEL_REQUEST_TYPE:
197
-        rv = ogs_tlv_parse_msg_desc(&gtp_message->relocation_cancel_request,
198
+        rv = ogs_tlv_parse_msg_desc(&gtp1_message->relocation_cancel_request,
199
                 &ogs_gtp1_tlv_desc_relocation_cancel_request, pkbuf, OGS_TLV_MODE_T1_L2);
200
         break;
201
open5gs_2.4.8.202207010002.tar.xz/lib/gtp/v1/message.h -> open5gs_2.4.8.202207020002.tar.xz/lib/gtp/v1/message.h Changed
10
 
1
@@ -21,7 +21,7 @@
2
 /*******************************************************************************
3
  * This file had been created by gtp1-tlv.py script v0.1.0
4
  * Please do not modify this file but regenerate it via script.
5
- * Created on: 2022-05-12 14:42:38.599141 by pespin
6
+ * Created on: 2022-06-30 08:56:31.627300 by ubuntu
7
  * from 29060-g00.docx
8
  ******************************************************************************/
9
 
10
open5gs_2.4.8.202207010002.tar.xz/lib/gtp/v1/path.h -> open5gs_2.4.8.202207020002.tar.xz/lib/gtp/v1/path.h Changed
10
 
1
@@ -32,7 +32,7 @@
2
 typedef struct ogs_gtp_xact_s ogs_gtp_xact_t;
3
 
4
 
5
-ogs_pkbuf_t *ogs_gtp1_handle_echo_req(ogs_pkbuf_t *pkt);
6
+ogs_pkbuf_t *ogs_gtp1_handle_echo_req(ogs_pkbuf_t *pkb);
7
 void ogs_gtp1_send_error_message(
8
         ogs_gtp_xact_t *xact, uint32_t teid, uint8_t type, uint8_t cause_value);
9
 
10
open5gs_2.4.8.202207010002.tar.xz/lib/gtp/v1/support/gtp1-tlv.py -> open5gs_2.4.8.202207020002.tar.xz/lib/gtp/v1/support/gtp1-tlv.py Changed
83
 
1
@@ -594,20 +594,20 @@
2
         f.write("}};\n\n")
3
 f.write("\n")
4
 
5
-f.write("""int ogs_gtp1_parse_msg(ogs_gtp1_message_t *gtp_message, ogs_pkbuf_t *pkbuf)
6
+f.write("""int ogs_gtp1_parse_msg(ogs_gtp1_message_t *gtp1_message, ogs_pkbuf_t *pkbuf)
7
 {
8
     int rv = OGS_ERROR;
9
     ogs_gtp1_header_t *h = NULL;
10
     uint16_t size = 0;
11
 
12
-    ogs_assert(gtp_message);
13
+    ogs_assert(gtp1_message);
14
     ogs_assert(pkbuf);
15
     ogs_assert(pkbuf->len);
16
 
17
     h = (ogs_gtp1_header_t *)pkbuf->data;
18
     ogs_assert(h);
19
 
20
-    memset(gtp_message, 0, sizeof(ogs_gtp1_message_t));
21
+    memset(gtp1_message, 0, sizeof(ogs_gtp1_message_t));
22
 
23
     if (h->e || h->s || h->pn)
24
         size = OGS_GTPV1C_HEADER_LEN;
25
@@ -615,25 +615,25 @@
26
         size = OGS_GTPV1C_HEADER_LEN - 4;
27
 
28
     ogs_assert(ogs_pkbuf_pull(pkbuf, size));
29
-    memcpy(&gtp_message->h, pkbuf->data - size, size);
30
+    memcpy(&gtp1_message->h, pkbuf->data - size, size);
31
 
32
-    gtp_message->h.teid = be32toh(gtp_message->h.teid);
33
+    gtp1_message->h.teid = be32toh(gtp1_message->h.teid);
34
 
35
     if (pkbuf->len == 0) {
36
         ogs_assert(ogs_pkbuf_push(pkbuf, size));
37
         return OGS_OK;
38
     }
39
 
40
-    switch(gtp_message->h.type) {
41
+    switch(gtp1_message->h.type) {
42
 """)
43
 for (k, v) in sorted_msg_list:
44
     if "ies" in msg_listk:
45
         f.write("    case OGS_GTP1_%s_TYPE:\n" % v_upper(k))
46
-        f.write("        rv = ogs_tlv_parse_msg_desc(&gtp_message->%s,\n" % v_lower(k))
47
+        f.write("        rv = ogs_tlv_parse_msg_desc(&gtp1_message->%s,\n" % v_lower(k))
48
         f.write("                &ogs_gtp1_tlv_desc_%s, pkbuf, OGS_TLV_MODE_T1_L2);\n" % v_lower(k))
49
         f.write("        break;\n")
50
 f.write("""    default:
51
-        ogs_warn("Not implmeneted(type:%d)", gtp_message->h.type);
52
+        ogs_warn("Not implmeneted(type:%d)", gtp1_message->h.type);
53
         break;
54
     }
55
 
56
@@ -644,21 +644,21 @@
57
 
58
 """)
59
 
60
-f.write("""ogs_pkbuf_t *ogs_gtp1_build_msg(ogs_gtp1_message_t *gtp_message)
61
+f.write("""ogs_pkbuf_t *ogs_gtp1_build_msg(ogs_gtp1_message_t *gtp1_message)
62
 {
63
     ogs_pkbuf_t *pkbuf = NULL;
64
 
65
-    ogs_assert(gtp_message);
66
-    switch(gtp_message->h.type) {
67
+    ogs_assert(gtp1_message);
68
+    switch(gtp1_message->h.type) {
69
 """)
70
 for (k, v) in sorted_msg_list:
71
     if "ies" in msg_listk:
72
         f.write("    case OGS_GTP1_%s_TYPE:\n" % v_upper(k))
73
         f.write("        pkbuf = ogs_tlv_build_msg(&ogs_gtp1_tlv_desc_%s,\n" % v_lower(k))
74
-        f.write("                &gtp_message->%s, OGS_TLV_MODE_T1_L2);\n" % v_lower(k))
75
+        f.write("                &gtp1_message->%s, OGS_TLV_MODE_T1_L2);\n" % v_lower(k))
76
         f.write("        break;\n")
77
 f.write("""    default:
78
-        ogs_warn("Not implmeneted(type:%d)", gtp_message->h.type);
79
+        ogs_warn("Not implmeneted(type:%d)", gtp1_message->h.type);
80
         break;
81
     }
82
 
83
open5gs_2.4.8.202207010002.tar.xz/lib/gtp/v2/message.c -> open5gs_2.4.8.202207020002.tar.xz/lib/gtp/v2/message.c Changed
10
 
1
@@ -20,7 +20,7 @@
2
 /*******************************************************************************
3
  * This file had been created by gtp-tlv.py script v0.1.0
4
  * Please do not modify this file but regenerate it via script.
5
- * Created on: 2022-06-11 20:06:47.872181 by acetcom
6
+ * Created on: 2022-06-30 08:56:57.201419 by ubuntu
7
  * from 29274-g30.docx
8
  ******************************************************************************/
9
 
10
open5gs_2.4.8.202207010002.tar.xz/lib/gtp/v2/message.h -> open5gs_2.4.8.202207020002.tar.xz/lib/gtp/v2/message.h Changed
21
 
1
@@ -20,7 +20,7 @@
2
 /*******************************************************************************
3
  * This file had been created by gtp-tlv.py script v0.1.0
4
  * Please do not modify this file but regenerate it via script.
5
- * Created on: 2022-06-11 20:06:47.866971 by acetcom
6
+ * Created on: 2022-06-30 08:56:57.190289 by ubuntu
7
  * from 29274-g30.docx
8
  ******************************************************************************/
9
 
10
@@ -1274,8 +1274,8 @@
11
    };
12
 } ogs_gtp2_message_t;
13
 
14
-int ogs_gtp2_parse_msg(ogs_gtp2_message_t *gtp_message, ogs_pkbuf_t *pkbuf);
15
-ogs_pkbuf_t *ogs_gtp2_build_msg(ogs_gtp2_message_t *gtp_message);
16
+int ogs_gtp2_parse_msg(ogs_gtp2_message_t *gtp2_message, ogs_pkbuf_t *pkbuf);
17
+ogs_pkbuf_t *ogs_gtp2_build_msg(ogs_gtp2_message_t *gtp2_message);
18
 
19
 #ifdef __cplusplus
20
 }
21
open5gs_2.4.8.202207010002.tar.xz/lib/gtp/v2/path.h -> open5gs_2.4.8.202207020002.tar.xz/lib/gtp/v2/path.h Changed
10
 
1
@@ -35,7 +35,7 @@
2
         ogs_gtp2_header_t *gtp_hdesc, ogs_gtp2_extension_header_t *ext_hdesc,
3
         ogs_pkbuf_t *pkbuf);
4
 
5
-ogs_pkbuf_t *ogs_gtp2_handle_echo_req(ogs_pkbuf_t *pkt);
6
+ogs_pkbuf_t *ogs_gtp2_handle_echo_req(ogs_pkbuf_t *pkb);
7
 void ogs_gtp2_send_error_message(
8
         ogs_gtp_xact_t *xact, uint32_t teid, uint8_t type, uint8_t cause_value);
9
 
10
open5gs_2.4.8.202207010002.tar.xz/lib/gtp/v2/support/gtp-tlv.py -> open5gs_2.4.8.202207020002.tar.xz/lib/gtp/v2/support/gtp-tlv.py Changed
12
 
1
@@ -603,8 +603,8 @@
2
 f.write("   };\n");
3
 f.write("} ogs_gtp2_message_t;\n\n")
4
 
5
-f.write("""int ogs_gtp2_parse_msg(ogs_gtp2_message_t *gtp_message, ogs_pkbuf_t *pkbuf);
6
-ogs_pkbuf_t *ogs_gtp2_build_msg(ogs_gtp2_message_t *gtp_message);
7
+f.write("""int ogs_gtp2_parse_msg(ogs_gtp2_message_t *gtp2_message, ogs_pkbuf_t *pkbuf);
8
+ogs_pkbuf_t *ogs_gtp2_build_msg(ogs_gtp2_message_t *gtp2_message);
9
 
10
 #ifdef __cplusplus
11
 }
12
open5gs_2.4.8.202207010002.tar.xz/lib/gtp/xact.c -> open5gs_2.4.8.202207020002.tar.xz/lib/gtp/xact.c Changed
12
 
1
@@ -34,8 +34,8 @@
2
 static OGS_POOL(pool, ogs_gtp_xact_t);
3
 
4
 static ogs_gtp_xact_t *ogs_gtp_xact_remote_create(ogs_gtp_node_t *gnode, uint8_t gtp_version, uint32_t sqn);
5
-static ogs_gtp_xact_stage_t ogs_gtp2_xact_get_stage(uint8_t type, uint32_t sqn);
6
-static ogs_gtp_xact_stage_t ogs_gtp1_xact_get_stage(uint8_t type, uint32_t sqn);
7
+static ogs_gtp_xact_stage_t ogs_gtp2_xact_get_stage(uint8_t type, uint32_t xid);
8
+static ogs_gtp_xact_stage_t ogs_gtp1_xact_get_stage(uint8_t type, uint32_t xid);
9
 static int ogs_gtp_xact_delete(ogs_gtp_xact_t *xact);
10
 static int ogs_gtp_xact_update_rx(ogs_gtp_xact_t *xact, uint8_t type);
11
 static ogs_gtp_xact_t *ogs_gtp_xact_find_by_xid(
12
open5gs_2.4.8.202207010002.tar.xz/lib/nas/5gs/types.h -> open5gs_2.4.8.202207020002.tar.xz/lib/nas/5gs/types.h Changed
19
 
1
@@ -554,12 +554,12 @@
2
 } __attribute__ ((packed)) ogs_nas_rejected_s_nssai_t;
3
 
4
 void ogs_nas_build_rejected_nssai(
5
-        ogs_nas_rejected_nssai_t *nas_rejected_nssai,
6
-        ogs_nas_rejected_s_nssai_t *nas_rejected_s_nssai,
7
-        int num_of_nas_rejected_s_nssai);
8
+        ogs_nas_rejected_nssai_t *rejected_nssai,
9
+        ogs_nas_rejected_s_nssai_t *rejected_s_nssai,
10
+        int num_of_rejected_s_nssai);
11
 int ogs_nas_parse_rejected_nssai(
12
-        ogs_nas_rejected_s_nssai_t *nas_rejected_s_nssai,
13
-        ogs_nas_rejected_nssai_t *nas_rejected_nssai);
14
+        ogs_nas_rejected_s_nssai_t *rejected_s_nssai,
15
+        ogs_nas_rejected_nssai_t *rejected_nssai);
16
 
17
 /* 9.11.3.49 Service area list
18
  * O TLV 6-114 */
19
open5gs_2.4.8.202207010002.tar.xz/lib/nas/common/types.h -> open5gs_2.4.8.202207020002.tar.xz/lib/nas/common/types.h Changed
12
 
1
@@ -748,8 +748,8 @@
2
 } __attribute__ ((packed)) ogs_nas_apn_aggregate_maximum_bit_rate_t;
3
 
4
 void apn_ambr_build(
5
-    ogs_nas_apn_aggregate_maximum_bit_rate_t * apn_aggregate_maximum_bit_rate,
6
-    uint32_t dl_ambr, uint32_t ul_ambr);
7
+    ogs_nas_apn_aggregate_maximum_bit_rate_t *apn_aggregate_maximum_bit_rate,
8
+    uint32_t dl_apn_ambr, uint32_t ul_apn_ambr);
9
 
10
 /* 9.9.4.3 EPS quality of service
11
  * M LV 2-14 */
12
open5gs_2.4.8.202207010002.tar.xz/lib/pfcp/conv.h -> open5gs_2.4.8.202207020002.tar.xz/lib/pfcp/conv.h Changed
11
 
1
@@ -40,7 +40,8 @@
2
 int ogs_pfcp_f_seid_to_ip(ogs_pfcp_f_seid_t *f_seid, ogs_ip_t *ip);
3
 
4
 int ogs_pfcp_sockaddr_to_f_teid(
5
-    ogs_sockaddr_t *a, ogs_sockaddr_t *b, ogs_pfcp_f_teid_t *f_teid, int *len);
6
+    ogs_sockaddr_t *addr, ogs_sockaddr_t *addr6,
7
+    ogs_pfcp_f_teid_t *f_teid, int *len);
8
 int ogs_pfcp_f_teid_to_sockaddr(
9
     ogs_pfcp_f_teid_t *f_teid, int f_teid_len,
10
     ogs_sockaddr_t **addr, ogs_sockaddr_t **addr6);
11
open5gs_2.4.8.202207010002.tar.xz/lib/pfcp/types.h -> open5gs_2.4.8.202207020002.tar.xz/lib/pfcp/types.h Changed
14
 
1
@@ -838,10 +838,10 @@
2
 } __attribute__ ((packed)) ogs_pfcp_sdf_filter_t;
3
 
4
 int16_t ogs_pfcp_build_sdf_filter(
5
-        ogs_tlv_octet_t *octet, ogs_pfcp_sdf_filter_t *info,
6
+        ogs_tlv_octet_t *octet, ogs_pfcp_sdf_filter_t *filter,
7
         void *data, int data_len);
8
 int16_t ogs_pfcp_parse_sdf_filter(
9
-        ogs_pfcp_sdf_filter_t *info, ogs_tlv_octet_t *octet);
10
+        ogs_pfcp_sdf_filter_t *filter, ogs_tlv_octet_t *octet);
11
 
12
 /*
13
  * 8.2.8 MBR
14
open5gs_2.4.8.202207010002.tar.xz/lib/pfcp/xact.c -> open5gs_2.4.8.202207020002.tar.xz/lib/pfcp/xact.c Changed
10
 
1
@@ -38,7 +38,7 @@
2
 static ogs_pfcp_xact_t *ogs_pfcp_xact_remote_create(
3
         ogs_pfcp_node_t *node, uint32_t sqn);
4
 static ogs_pfcp_xact_stage_t ogs_pfcp_xact_get_stage(
5
-        uint8_t type, uint32_t sqn);
6
+        uint8_t type, uint32_t xid);
7
 static int ogs_pfcp_xact_delete(ogs_pfcp_xact_t *xact);
8
 static int ogs_pfcp_xact_update_rx(ogs_pfcp_xact_t *xact, uint8_t type);
9
 static ogs_pfcp_xact_t *ogs_pfcp_xact_find_by_xid(
10
open5gs_2.4.8.202207010002.tar.xz/lib/sbi/conv.h -> open5gs_2.4.8.202207020002.tar.xz/lib/sbi/conv.h Changed
10
 
1
@@ -50,7 +50,7 @@
2
 int ogs_strftimezone(char *str, size_t size, int tm_gmtoff);
3
 char *ogs_sbi_localtime_string(ogs_time_t time);
4
 char *ogs_sbi_gmtime_string(ogs_time_t time);
5
-char *ogs_sbi_timezone_string(int tm_offset);
6
+char *ogs_sbi_timezone_string(int tm_gmtoff);
7
 bool ogs_sbi_time_from_string(ogs_time_t *time, char *str);
8
 
9
 char *ogs_sbi_s_nssai_to_string(ogs_s_nssai_t *s_nssai);
10
open5gs_2.4.8.202207010002.tar.xz/lib/sbi/nghttp2-server.c -> open5gs_2.4.8.202207020002.tar.xz/lib/sbi/nghttp2-server.c Changed
10
 
1
@@ -36,7 +36,7 @@
2
 static bool server_send_response(
3
         ogs_sbi_stream_t *stream, ogs_sbi_response_t *response);
4
 
5
-static ogs_sbi_server_t *server_from_stream(ogs_sbi_stream_t *data);
6
+static ogs_sbi_server_t *server_from_stream(ogs_sbi_stream_t *stream);
7
 
8
 const ogs_sbi_server_actions_t ogs_nghttp2_server_actions = {
9
     server_init,
10
open5gs_2.4.8.202207010002.tar.xz/meson.build -> open5gs_2.4.8.202207020002.tar.xz/meson.build Changed
39
 
1
@@ -42,6 +42,12 @@
2
 python3_exe = join_paths(python3.path())
3
 mkdir_p = 'import os; os.makedirs("@0@", exist_ok=True) if not os.environ.get("DESTDIR") else False;'
4
 install_conf = 'import os; import shutil; shutil.copy("@0@", "@1@") if not os.environ.get("DESTDIR") and not os.path.isfile(os.path.join("@1@", os.path.split("@0@")1)) else False;'
5
+cppcheck = find_program('cppcheck', required: false)
6
+clangtidy = find_program('run-clang-tidy', required: false) # requires clang-tools package
7
+if clangtidy.found() != true
8
+    clangtidy = find_program('clang-tidy', required: false)
9
+endif
10
+
11
 
12
 meson.add_install_script(python3_exe, '-c',
13
         mkdir_p.format(join_paths(localstatedir, 'log', 'open5gs')))
14
@@ -131,3 +137,24 @@
15
   '        debugging support:            ' + get_option('buildtype'),
16
   '',
17
 ))
18
+
19
+
20
+if cppcheck.found()
21
+    run_target('analyze-cppcheck',
22
+    command :  'misc/static_code_analyze.sh',
23
+        cppcheck.path(),
24
+        meson.build_root(),
25
+        meson.source_root()
26
+        
27
+    )
28
+endif
29
+
30
+if clangtidy.found()
31
+    run_target('analyze-clang-tidy',
32
+    command :  'misc/static_code_analyze.sh',
33
+        clangtidy.path(),
34
+        meson.build_root(),
35
+        meson.source_root()
36
+        
37
+    )
38
+endif
39
open5gs_2.4.8.202207020002.tar.xz/misc/static_code_analyze.sh Added
42
 
1
@@ -0,0 +1,40 @@
2
+#!/usr/bin/env bash
3
+
4
+ANALYZE_TOOL="${1}" && shift
5
+BUILD_DIR="${1}" && shift
6
+SOURCES_DIR="${1}" && shift
7
+
8
+SOURCES=$(find ${SOURCES_DIR}/src ${SOURCES_DIR}/lib -not -path *asn1c* -not -path *ipfw* -name *.c)
9
+#SOURCES=$(find ${SOURCES_DIR}/src ${SOURCES_DIR}/lib ${SOURCES_DIR}/subprojects -name *.c)
10
+
11
+if  ${ANALYZE_TOOL} == *"clang-tidy"* ;
12
+then
13
+    if  ${ANALYZE_TOOL} == *"run-clang-tidy"* ; then
14
+        OPTS="${OPTS} -j $(nproc)"
15
+    fi
16
+
17
+    OPTS="${OPTS} -quiet"
18
+    OPTS="${OPTS} -p=${BUILD_DIR}"
19
+
20
+    ${ANALYZE_TOOL} ${OPTS} ${SOURCES} 2>/dev/null
21
+
22
+elif  ${ANALYZE_TOOL} == *"cppcheck"* ;
23
+then
24
+    OPTS="${OPTS} -j $(nproc)"
25
+#    OPTS="${OPTS} --quiet"
26
+    OPTS="${OPTS} --verbose"
27
+    OPTS="${OPTS} --enable=all"
28
+    OPTS="${OPTS} --verbose"
29
+    OPTS="${OPTS} --suppress=variableScope"
30
+    OPTS="${OPTS} --suppress=preprocessorErrorDirective"
31
+    OPTS="${OPTS} --suppress=unusedVariable"
32
+    OPTS="${OPTS} --output-file=cppchecklog.log"
33
+    OPTS="${OPTS} --cppcheck-build-dir=${BUILD_DIR}/cppcheck"
34
+    OPTS="${OPTS} --project=${BUILD_DIR}/compile_commands.json"
35
+
36
+    ${ANALYZE_TOOL} ${OPTS} ${SOURCES}
37
+
38
+else
39
+    echo "Unknown static code analysis tool: ${ANALYZE_TOOL}"
40
+    exit 1
41
+fi
42
open5gs_2.4.8.202207010002.tar.xz/src/amf/ngap-path.h -> open5gs_2.4.8.202207020002.tar.xz/src/amf/ngap-path.h Changed
14
 
1
@@ -56,10 +56,10 @@
2
 
3
 int ngap_send_ran_ue_context_release_command(
4
     ran_ue_t *ran_ue, NGAP_Cause_PR group, long cause,
5
-    uint8_t action, ogs_time_t delay);
6
+    uint8_t action, ogs_time_t duration);
7
 int ngap_send_amf_ue_context_release_command(
8
     amf_ue_t *amf_ue, NGAP_Cause_PR group, long cause,
9
-    uint8_t action, ogs_time_t delay);
10
+    uint8_t action, ogs_time_t duration);
11
 
12
 int ngap_send_paging(amf_ue_t *amf_ue);
13
 int ngap_send_pdu_resource_setup_request(
14
open5gs_2.4.8.202207010002.tar.xz/src/amf/nnssf-handler.h -> open5gs_2.4.8.202207020002.tar.xz/src/amf/nnssf-handler.h Changed
10
 
1
@@ -27,7 +27,7 @@
2
 #include "context.h"
3
 
4
 int amf_nnssf_nsselection_handle_get(
5
-        amf_sess_t *sess, ogs_sbi_message_t *message);
6
+        amf_sess_t *sess, ogs_sbi_message_t *recvmsg);
7
 
8
 #ifdef __cplusplus
9
 }
10
open5gs_2.4.8.202207010002.tar.xz/src/amf/npcf-handler.h -> open5gs_2.4.8.202207020002.tar.xz/src/amf/npcf-handler.h Changed
10
 
1
@@ -27,7 +27,7 @@
2
 #include "context.h"
3
 
4
 int amf_npcf_am_policy_control_handle_create(
5
-        amf_ue_t *amf_ue, ogs_sbi_message_t *message);
6
+        amf_ue_t *amf_ue, ogs_sbi_message_t *recvmsg);
7
 
8
 #ifdef __cplusplus
9
 }
10
open5gs_2.4.8.202207010002.tar.xz/src/amf/nsmf-handler.h -> open5gs_2.4.8.202207020002.tar.xz/src/amf/nsmf-handler.h Changed
10
 
1
@@ -27,7 +27,7 @@
2
 #include "context.h"
3
 
4
 int amf_nsmf_pdusession_handle_create_sm_context(
5
-        amf_sess_t *sess, ogs_sbi_message_t *message);
6
+        amf_sess_t *sess, ogs_sbi_message_t *recvmsg);
7
 int amf_nsmf_pdusession_handle_update_sm_context(
8
         amf_sess_t *sess, int state, ogs_sbi_message_t *recvmsg);
9
 int amf_nsmf_pdusession_handle_release_sm_context(amf_sess_t *sess, int state);
10
open5gs_2.4.8.202207010002.tar.xz/src/amf/nudm-handler.h -> open5gs_2.4.8.202207020002.tar.xz/src/amf/nudm-handler.h Changed
10
 
1
@@ -27,7 +27,7 @@
2
 #include "context.h"
3
 
4
 int amf_nudm_sdm_handle_provisioned(
5
-        amf_ue_t *amf_ue, ogs_sbi_message_t *message);
6
+        amf_ue_t *amf_ue, ogs_sbi_message_t *recvmsg);
7
 
8
 #ifdef __cplusplus
9
 }
10
open5gs_2.4.8.202207010002.tar.xz/src/mme/esm-handler.h -> open5gs_2.4.8.202207020002.tar.xz/src/mme/esm-handler.h Changed
14
 
1
@@ -27,10 +27,10 @@
2
 #endif
3
 
4
 int esm_handle_pdn_connectivity_request(mme_bearer_t *bearer,
5
-        ogs_nas_eps_pdn_connectivity_request_t *pdn_connectivity_request,
6
+        ogs_nas_eps_pdn_connectivity_request_t *req,
7
         int create_action);
8
 int esm_handle_information_response(mme_sess_t *sess, 
9
-        ogs_nas_eps_esm_information_response_t *bearer_information_response);
10
+        ogs_nas_eps_esm_information_response_t *rsp);
11
 int esm_handle_bearer_resource_allocation_request(
12
         mme_bearer_t *bearer, ogs_nas_eps_message_t *message);
13
 int esm_handle_bearer_resource_modification_request(
14
open5gs_2.4.8.202207010002.tar.xz/src/mme/mme-context.h -> open5gs_2.4.8.202207020002.tar.xz/src/mme/mme-context.h Changed
10
 
1
@@ -704,7 +704,7 @@
2
 ogs_sockaddr_t *mme_pgw_addr_find_by_apn(
3
         ogs_list_t *list, int family, char *apn);
4
 
5
-mme_vlr_t *mme_vlr_add(ogs_sockaddr_t *addr, ogs_sockopt_t *option);
6
+mme_vlr_t *mme_vlr_add(ogs_sockaddr_t *sa_list, ogs_sockopt_t *option);
7
 void mme_vlr_remove(mme_vlr_t *vlr);
8
 void mme_vlr_remove_all(void);
9
 void mme_vlr_close(mme_vlr_t *vlr);
10
open5gs_2.4.8.202207010002.tar.xz/src/mme/mme-s11-build.h -> open5gs_2.4.8.202207020002.tar.xz/src/mme/mme-s11-build.h Changed
10
 
1
@@ -27,7 +27,7 @@
2
 ogs_pkbuf_t *mme_s11_build_create_session_request(
3
         uint8_t type, mme_sess_t *sess, int create_action);
4
 ogs_pkbuf_t *mme_s11_build_modify_bearer_request(
5
-        uint8_t type, mme_ue_t *mme_ue, int uli_presense);
6
+        uint8_t type, mme_ue_t *mme_ue, int uli_presence);
7
 ogs_pkbuf_t *mme_s11_build_delete_session_request(
8
         uint8_t type, mme_sess_t *sess, int action);
9
 ogs_pkbuf_t *mme_s11_build_create_bearer_response(
10
open5gs_2.4.8.202207010002.tar.xz/src/mme/mme-s11-handler.h -> open5gs_2.4.8.202207020002.tar.xz/src/mme/mme-s11-handler.h Changed
18
 
1
@@ -41,13 +41,13 @@
2
         ogs_gtp2_delete_session_response_t *rsp);
3
 void mme_s11_handle_create_bearer_request(
4
         ogs_gtp_xact_t *xact, mme_ue_t *mme_ue,
5
-        ogs_gtp2_create_bearer_request_t *rsp);
6
+        ogs_gtp2_create_bearer_request_t *req);
7
 void mme_s11_handle_update_bearer_request(
8
         ogs_gtp_xact_t *xact, mme_ue_t *mme_ue,
9
-        ogs_gtp2_update_bearer_request_t *rsp);
10
+        ogs_gtp2_update_bearer_request_t *req);
11
 void mme_s11_handle_delete_bearer_request(
12
         ogs_gtp_xact_t *xact, mme_ue_t *mme_ue,
13
-        ogs_gtp2_delete_bearer_request_t *rsp);
14
+        ogs_gtp2_delete_bearer_request_t *req);
15
 
16
 void mme_s11_handle_release_access_bearers_response(
17
         ogs_gtp_xact_t *xact, mme_ue_t *mme_ue,
18
open5gs_2.4.8.202207010002.tar.xz/src/sgwc/sxa-handler.h -> open5gs_2.4.8.202207020002.tar.xz/src/sgwc/sxa-handler.h Changed
15
 
1
@@ -28,11 +28,11 @@
2
 
3
 void sgwc_sxa_handle_session_establishment_response(
4
         sgwc_sess_t *sess, ogs_pfcp_xact_t *pfcp_xact,
5
-        ogs_gtp2_message_t *gtp_message,
6
+        ogs_gtp2_message_t *recv_message,
7
         ogs_pfcp_session_establishment_response_t *pfcp_rsp);
8
 void sgwc_sxa_handle_session_modification_response(
9
         sgwc_sess_t *sess, ogs_pfcp_xact_t *pfcp_xact,
10
-        ogs_gtp2_message_t *gtp_message,
11
+        ogs_gtp2_message_t *recv_message,
12
         ogs_pfcp_session_modification_response_t *pfcp_rsp);
13
 void sgwc_sxa_handle_session_deletion_response(
14
         sgwc_sess_t *sess, ogs_pfcp_xact_t *pfcp_xact,
15
open5gs_2.4.8.202207010002.tar.xz/src/smf/gy-handler.h -> open5gs_2.4.8.202207020002.tar.xz/src/smf/gy-handler.h Changed
10
 
1
@@ -32,7 +32,7 @@
2
         ogs_gtp_xact_t *gtp_xact);
3
 void smf_gy_handle_cca_update_request(
4
         smf_sess_t *sess, ogs_diam_gy_message_t *gy_message,
5
-        ogs_pfcp_xact_t *gtp_xact);
6
+        ogs_pfcp_xact_t *pfcp_xact);
7
 uint32_t smf_gy_handle_cca_termination_request(
8
         smf_sess_t *sess, ogs_diam_gy_message_t *gy_message,
9
         ogs_gtp_xact_t *gtp_xact);
10
open5gs_2.4.8.202207010002.tar.xz/src/smf/n4-handler.h -> open5gs_2.4.8.202207020002.tar.xz/src/smf/n4-handler.h Changed
10
 
1
@@ -41,7 +41,7 @@
2
         ogs_pfcp_session_establishment_response_t *rsp);
3
 void smf_epc_n4_handle_session_modification_response(
4
         smf_sess_t *sess, ogs_pfcp_xact_t *xact,
5
-        ogs_gtp2_message_t *gtp2_message,
6
+        ogs_gtp2_message_t *recv_message,
7
         ogs_pfcp_session_modification_response_t *rsp);
8
 uint8_t smf_epc_n4_handle_session_deletion_response(
9
         smf_sess_t *sess, ogs_pfcp_xact_t *xact,
10
open5gs_2.4.8.202207010002.tar.xz/src/smf/s5c-handler.h -> open5gs_2.4.8.202207020002.tar.xz/src/smf/s5c-handler.h Changed
18
 
1
@@ -42,13 +42,13 @@
2
         ogs_pkbuf_t *gtpbuf, ogs_gtp2_modify_bearer_request_t *req);
3
 void smf_s5c_handle_create_bearer_response(
4
         smf_sess_t *sess, ogs_gtp_xact_t *xact,
5
-        ogs_gtp2_create_bearer_response_t *req);
6
+        ogs_gtp2_create_bearer_response_t *rsp);
7
 void smf_s5c_handle_update_bearer_response(
8
         smf_sess_t *sess, ogs_gtp_xact_t *xact,
9
-        ogs_gtp2_update_bearer_response_t *req);
10
+        ogs_gtp2_update_bearer_response_t *rsp);
11
 bool smf_s5c_handle_delete_bearer_response(
12
         smf_sess_t *sess, ogs_gtp_xact_t *xact,
13
-        ogs_gtp2_delete_bearer_response_t *req);
14
+        ogs_gtp2_delete_bearer_response_t *rsp);
15
 void smf_s5c_handle_bearer_resource_command(
16
         smf_sess_t *sess, ogs_gtp_xact_t *xact,
17
         ogs_gtp2_bearer_resource_command_t *cmd);
18