Changes of Revision 868

View file
open5gs_2.7.2.4536.c888.202411042026.dsc -> open5gs_2.7.2.4538.4211.202411052026.dsc Changed
​x
 
1
@@ -2,7 +2,7 @@
2
 Source: open5gs
3
 Binary: open5gs-common, open5gs-mme, open5gs-sgwc, open5gs-smf, open5gs-amf, open5gs-sgwu, open5gs-upf, open5gs-hss, open5gs-pcrf, open5gs-nrf, open5gs-scp, open5gs-sepp, open5gs-ausf, open5gs-udm, open5gs-pcf, open5gs-nssf, open5gs-bsf, open5gs-udr, open5gs, open5gs-dbg
4
 Architecture: any
5
-Version: 2.7.2.4536.c888.202411042026
6
+Version: 2.7.2.4538.4211.202411052026
7
 Maintainer: Harald Welte <laforge@gnumonks.org>
8
 Uploaders: Sukchan Lee <acetcom@gmail.com>
9
 Homepage: https://open5gs.org
10
@@ -32,8 +32,8 @@
11
  open5gs-udr deb net optional arch=any
12
  open5gs-upf deb net optional arch=any
13
 Checksums-Sha1:
14
- 1ec9bc6a95f2fe4da094390455921c86c7cf0100 14510900 open5gs_2.7.2.4536.c888.202411042026.tar.xz
15
+ b44d94f31d41e84a67e35b8ae78bbba8284656d2 14512008 open5gs_2.7.2.4538.4211.202411052026.tar.xz
16
 Checksums-Sha256:
17
- a18f3e9dfb5b5108f6b93bbadf893b292a7663c3b47b4f63c61d9dc990dea493 14510900 open5gs_2.7.2.4536.c888.202411042026.tar.xz
18
+ 5046214c77d12ca2289eba470278bf2cc86e6baffd6b54d30c0c341e251740e8 14512008 open5gs_2.7.2.4538.4211.202411052026.tar.xz
19
 Files:
20
- 209e3d71ff442175ba8d2496aacda390 14510900 open5gs_2.7.2.4536.c888.202411042026.tar.xz
21
+ f7418a2b3b2a9893a3850272f1ea1bb7 14512008 open5gs_2.7.2.4538.4211.202411052026.tar.xz
22
​
View file
open5gs_2.7.2.4536.c888.202411042026.tar.xz/.tarball-version -> open5gs_2.7.2.4538.4211.202411052026.tar.xz/.tarball-version Changed
4
 
1
@@ -1 +1 @@
2
-2.7.2.4536-c888.202411042026
3
+2.7.2.4538-4211.202411052026
4
​
View file
open5gs_2.7.2.4536.c888.202411042026.tar.xz/debian/changelog -> open5gs_2.7.2.4538.4211.202411052026.tar.xz/debian/changelog Changed
12
 
1
@@ -1,8 +1,8 @@
2
-open5gs (2.7.2.4536.c888.202411042026) unstable; urgency=medium
3
+open5gs (2.7.2.4538.4211.202411052026) unstable; urgency=medium
4
5
   * Automatically generated changelog entry for building the Osmocom nightly feed
6
7
- -- Osmocom OBS scripts <info@osmocom.org>  Mon, 04 Nov 2024 20:28:00 +0000
8
+ -- Osmocom OBS scripts <info@osmocom.org>  Tue, 05 Nov 2024 20:27:58 +0000
9
10
 open5gs (2.7.2) unstable; urgency=medium
11
12
​
View file
open5gs_2.7.2.4536.c888.202411042026.tar.xz/lib/asn1c/util/conv.c -> open5gs_2.7.2.4538.4211.202411052026.tar.xz/lib/asn1c/util/conv.c Changed
14
 
1
@@ -205,8 +205,10 @@
2
         bit_string->buf = CALLOC(bit_string->size, sizeof(uint8_t));
3
         memcpy(bit_string->buf, &ip->addr6, OGS_IPV6_LEN);
4
         ogs_debug("    IPv6%s", OGS_INET_NTOP(&ip->addr6, buf));
5
-    } else
6
-        ogs_assert_if_reached();
7
+    } else {
8
+        ogs_error("No IPv4 or IPv6");
9
+        return OGS_ERROR;
10
+    }
11
12
     return OGS_OK;
13
 }
14
​
View file
open5gs_2.7.2.4536.c888.202411042026.tar.xz/lib/proto/types.h -> open5gs_2.7.2.4538.4211.202411052026.tar.xz/lib/proto/types.h Changed
10
 
1
@@ -699,7 +699,7 @@
2
     void *data;
3
 } ogs_pco_id_t;
4
5
-#define OGS_MAX_NUM_OF_PROTOCOL_OR_CONTAINER_ID    16
6
+#define OGS_MAX_NUM_OF_PROTOCOL_OR_CONTAINER_ID    32
7
 typedef struct ogs_pco_s {
8
 ED3(uint8_t ext:1;,
9
     uint8_t spare:4;,
10
​
View file
open5gs_2.7.2.4536.c888.202411042026.tar.xz/src/mme/emm-build.c -> open5gs_2.7.2.4538.4211.202411052026.tar.xz/src/mme/emm-build.c Changed
86
 
1
@@ -1,5 +1,5 @@
2
 /*
3
- * Copyright (C) 2019-2023 by Sukchan Lee <acetcom@gmail.com>
4
+ * Copyright (C) 2019-2024 by Sukchan Lee <acetcom@gmail.com>
5
  *
6
  * This file is part of Open5GS.
7
  *
8
@@ -163,7 +163,7 @@
9
     attach_accept->esm_message_container.buffer = esmbuf->data;
10
     attach_accept->esm_message_container.length = esmbuf->len;
11
12
-    if (mme_ue->next.m_tmsi) {
13
+    if (MME_NEXT_GUTI_IS_AVAILABLE(mme_ue)) {
14
         attach_accept->presencemask |= OGS_NAS_EPS_ATTACH_ACCEPT_GUTI_PRESENT;
15
16
         ogs_debug("    %s    GUTIG:%d,C:%d,M_TMSI:0x%x",
17
@@ -207,9 +207,9 @@
18
     eps_network_feature_support->ims_voice_over_ps_session_in_s1_mode = 1;
19
     eps_network_feature_support->extended_protocol_configuration_options = 1;
20
21
-    if (MME_P_TMSI_IS_AVAILABLE(mme_ue)) {
22
+    if (MME_NEXT_P_TMSI_IS_AVAILABLE(mme_ue)) {
23
         ogs_assert(mme_ue->csmap);
24
-        ogs_assert(mme_ue->p_tmsi);
25
+        ogs_assert(mme_ue->next.p_tmsi);
26
27
         attach_accept->presencemask |=
28
             OGS_NAS_EPS_ATTACH_ACCEPT_LOCATION_AREA_IDENTIFICATION_PRESENT;
29
@@ -224,7 +224,7 @@
30
         tmsi->spare = 0xf;
31
         tmsi->odd_even = 0;
32
         tmsi->type = OGS_NAS_MOBILE_IDENTITY_TMSI;
33
-        tmsi->tmsi = mme_ue->p_tmsi;
34
+        tmsi->tmsi = mme_ue->next.p_tmsi;
35
         ogs_debug("    P-TMSI: 0x%08x", tmsi->tmsi);
36
     }
37
38
@@ -494,6 +494,10 @@
39
     ogs_nas_eps_tracking_area_update_accept_t *tau_accept =
40
         &message.emm.tracking_area_update_accept;
41
     ogs_nas_eps_mobile_identity_t *nas_guti = &tau_accept->guti;
42
+    ogs_nas_location_area_identification_t *lai =
43
+        &tau_accept->location_area_identification;
44
+    ogs_nas_mobile_identity_t *ms_identity = &tau_accept->ms_identity;
45
+    ogs_nas_mobile_identity_tmsi_t *tmsi = &ms_identity->tmsi;;
46
     ogs_nas_gprs_timer_t *t3412_value = &tau_accept->t3412_value;
47
     ogs_nas_gprs_timer_t *t3402_value = &tau_accept->t3402_value;
48
     ogs_nas_gprs_timer_t *t3423_value = &tau_accept->t3423_value;
49
@@ -530,7 +534,7 @@
50
             OGS_NAS_EPS_TRACKING_AREA_UPDATE_ACCEPT_T3412_VALUE_PRESENT ;
51
     }
52
53
-    if (mme_ue->next.m_tmsi) {
54
+    if (MME_NEXT_GUTI_IS_AVAILABLE(mme_ue)) {
55
         tau_accept->presencemask |=
56
             OGS_NAS_EPS_TRACKING_AREA_UPDATE_ACCEPT_GUTI_PRESENT;
57
58
@@ -595,6 +599,27 @@
59
         sess = mme_sess_next(sess);
60
     }
61
62
+    /* Location Area Identification & MS Identity */
63
+    if (MME_NEXT_P_TMSI_IS_AVAILABLE(mme_ue)) {
64
+        ogs_assert(mme_ue->csmap);
65
+        ogs_assert(mme_ue->next.p_tmsi);
66
+
67
+        tau_accept->presencemask |= OGS_NAS_EPS_TRACKING_AREA_UPDATE_ACCEPT_LOCATION_AREA_IDENTIFICATION_PRESENT;
68
+        lai->nas_plmn_id = mme_ue->csmap->lai.nas_plmn_id;
69
+        lai->lac = mme_ue->csmap->lai.lac;
70
+        ogs_debug("    LAIPLMN_ID:%06x,LAC:%d",
71
+                ogs_plmn_id_hexdump(&lai->nas_plmn_id), lai->lac);
72
+
73
+        tau_accept->presencemask |=
74
+            OGS_NAS_EPS_TRACKING_AREA_UPDATE_ACCEPT_MS_IDENTITY_PRESENT;
75
+        ms_identity->length = 5;
76
+        tmsi->spare = 0xf;
77
+        tmsi->odd_even = 0;
78
+        tmsi->type = OGS_NAS_MOBILE_IDENTITY_TMSI;
79
+        tmsi->tmsi = mme_ue->next.p_tmsi;
80
+        ogs_debug("    P-TMSI: 0x%08x", tmsi->tmsi);
81
+    }
82
+
83
     /* Set T3402 */
84
     if (mme_self()->time.t3402.value) {
85
         rv = ogs_nas_gprs_timer_from_sec(
86
​
View file
open5gs_2.7.2.4536.c888.202411042026.tar.xz/src/mme/emm-sm.c -> open5gs_2.7.2.4538.4211.202411052026.tar.xz/src/mme/emm-sm.c Changed
201
 
1
@@ -260,7 +260,7 @@
2
              * the network, the network shall implicitly detach the UE.
3
              */
4
             mme_ue->detach_type = MME_DETACH_TYPE_MME_IMPLICIT;
5
-            if (MME_P_TMSI_IS_AVAILABLE(mme_ue)) {
6
+            if (MME_CURRENT_P_TMSI_IS_AVAILABLE(mme_ue)) {
7
                 ogs_assert(OGS_OK == sgsap_send_detach_indication(mme_ue));
8
             } else {
9
                 enb_ue_t *enb_ue = enb_ue_find_by_id(mme_ue->enb_ue_id);
10
@@ -519,6 +519,8 @@
11
                              rai.lai.lac, rai.rac);
12
                     r = nas_eps_send_tau_reject(enb_ue, mme_ue,
13
                     OGS_NAS_EMM_CAUSE_UE_IDENTITY_CANNOT_BE_DERIVED_BY_THE_NETWORK);
14
+                    ogs_expect(r == OGS_OK);
15
+                    ogs_assert(r != OGS_ERROR);
16
                     OGS_FSM_TRAN(s, &emm_state_exception);
17
                     break;
18
                 }
19
@@ -637,9 +639,36 @@
20
              * 10. UplinkNASTransport + Tracking area update complete (Target)
21
              */
22
23
-            if (e->s1ap_code == S1AP_ProcedureCode_id_initialUEMessage) {
24
-                ogs_debug("    Iniital UE Message");
25
-                if (mme_ue->nas_eps.update.active_flag) {
26
+            /* Update CSMAP from Tracking area update request */
27
+            mme_ue->csmap = mme_csmap_find_by_tai(&mme_ue->tai);
28
+            if (mme_ue->csmap &&
29
+                mme_ue->network_access_mode ==
30
+                    OGS_NETWORK_ACCESS_MODE_PACKET_AND_CIRCUIT &&
31
+                (mme_ue->nas_eps.update.value ==
32
+                 OGS_NAS_EPS_UPDATE_TYPE_COMBINED_TA_LA_UPDATING ||
33
+                 mme_ue->nas_eps.update.value ==
34
+                 OGS_NAS_EPS_UPDATE_TYPE_COMBINED_TA_LA_UPDATING_WITH_IMSI_ATTACH)) {
35
+
36
+                if (e->s1ap_code == S1AP_ProcedureCode_id_initialUEMessage)
37
+                    mme_ue->tracking_area_update_request_type =
38
+                        MME_TAU_TYPE_INITIAL_UE_MESSAGE;
39
+                else if (e->s1ap_code ==
40
+                        S1AP_ProcedureCode_id_uplinkNASTransport)
41
+                    mme_ue->tracking_area_update_request_type =
42
+                        MME_TAU_TYPE_UPLINK_NAS_TRANPORT;
43
+                else {
44
+                    ogs_error("Invalid Procedure Code%d", (int)e->s1ap_code);
45
+                    break;
46
+                }
47
+
48
+                ogs_assert(OGS_OK ==
49
+                    sgsap_send_location_update_request(mme_ue));
50
+
51
+            } else {
52
+
53
+                if (e->s1ap_code == S1AP_ProcedureCode_id_initialUEMessage) {
54
+                    ogs_debug("    Iniital UE Message");
55
+                    if (mme_ue->nas_eps.update.active_flag) {
56
57
     /*
58
      * TS33.401
59
@@ -652,39 +681,52 @@
60
      * UP data or pending downlink signalling, radio bearers will be established
61
      * as part of the TAU procedure and a KeNB derivation is necessary.
62
      */
63
-                    ogs_kdf_kenb(mme_ue->kasme, mme_ue->ul_count.i32,
64
-                            mme_ue->kenb);
65
-                    ogs_kdf_nh_enb(mme_ue->kasme, mme_ue->kenb, mme_ue->nh);
66
-                    mme_ue->nhcc = 1;
67
+                        ogs_kdf_kenb(mme_ue->kasme, mme_ue->ul_count.i32,
68
+                                mme_ue->kenb);
69
+                        ogs_kdf_nh_enb(mme_ue->kasme, mme_ue->kenb, mme_ue->nh);
70
+                        mme_ue->nhcc = 1;
71
72
-                    r = nas_eps_send_tau_accept(mme_ue,
73
-                            S1AP_ProcedureCode_id_InitialContextSetup);
74
-                    ogs_expect(r == OGS_OK);
75
-                    ogs_assert(r != OGS_ERROR);
76
-                } else {
77
+                        r = nas_eps_send_tau_accept(mme_ue,
78
+                                S1AP_ProcedureCode_id_InitialContextSetup);
79
+                        ogs_expect(r == OGS_OK);
80
+                        ogs_assert(r != OGS_ERROR);
81
+                    } else {
82
+                        r = nas_eps_send_tau_accept(mme_ue,
83
+                                S1AP_ProcedureCode_id_downlinkNASTransport);
84
+                        ogs_expect(r == OGS_OK);
85
+                        ogs_assert(r != OGS_ERROR);
86
+                    }
87
+                } else if (e->s1ap_code ==
88
+                        S1AP_ProcedureCode_id_uplinkNASTransport) {
89
+                    ogs_debug("    Uplink NAS Transport");
90
                     r = nas_eps_send_tau_accept(mme_ue,
91
                             S1AP_ProcedureCode_id_downlinkNASTransport);
92
                     ogs_expect(r == OGS_OK);
93
                     ogs_assert(r != OGS_ERROR);
94
+                } else {
95
+                    ogs_error("Invalid Procedure Code%d", (int)e->s1ap_code);
96
+                    break;
97
                 }
98
-            } else if (e->s1ap_code ==
99
-                    S1AP_ProcedureCode_id_uplinkNASTransport) {
100
-                ogs_debug("    Uplink NAS Transport");
101
-                r = nas_eps_send_tau_accept(mme_ue,
102
-                        S1AP_ProcedureCode_id_downlinkNASTransport);
103
-                ogs_expect(r == OGS_OK);
104
-                ogs_assert(r != OGS_ERROR);
105
-            } else {
106
-                ogs_fatal("Invalid Procedure Code%d", (int)e->s1ap_code);
107
-            }
108
109
-            if (!mme_ue->nas_eps.update.active_flag) {
110
-                enb_ue->relcause.group = S1AP_Cause_PR_nas;
111
-                enb_ue->relcause.cause = S1AP_CauseNas_normal_release;
112
-                mme_send_release_access_bearer_or_ue_context_release(enb_ue);
113
+        /*
114
+         * When active_flag is 0, check if the P-TMSI has been updated.
115
+         * If the P-TMSI has changed, wait to receive the TAU Complete message
116
+         * from the UE before sending the UEContextReleaseCommand.
117
+         *
118
+         * This ensures that the UE has acknowledged the new P-TMSI,
119
+         * allowing the TAU procedure to complete successfully
120
+         * and maintaining synchronization between the UE and the network.
121
+         */
122
+                if (!mme_ue->nas_eps.update.active_flag &&
123
+                    !MME_NEXT_P_TMSI_IS_AVAILABLE(mme_ue)) {
124
+                    enb_ue->relcause.group = S1AP_Cause_PR_nas;
125
+                    enb_ue->relcause.cause = S1AP_CauseNas_normal_release;
126
+                    mme_send_release_access_bearer_or_ue_context_release(
127
+                            enb_ue);
128
+                }
129
             }
130
131
-            if (mme_ue->next.m_tmsi) {
132
+            if (MME_NEXT_GUTI_IS_AVAILABLE(mme_ue)) {
133
                 ogs_fatal("MME does not create new GUTI");
134
                 ogs_assert_if_reached();
135
                 OGS_FSM_TRAN(s, &emm_state_initial_context_setup);
136
@@ -744,7 +786,7 @@
137
             if (e->s1ap_code == S1AP_ProcedureCode_id_initialUEMessage) {
138
                 ogs_debug("    Initial UE Message");
139
140
-                if (!MME_P_TMSI_IS_AVAILABLE(mme_ue)) {
141
+                if (!MME_CURRENT_P_TMSI_IS_AVAILABLE(mme_ue)) {
142
                     ogs_warn("No P-TMSI : UE%s", mme_ue->imsi_bcd);
143
                     r = nas_eps_send_service_reject(enb_ue, mme_ue,
144
                         OGS_NAS_EMM_CAUSE_UE_IDENTITY_CANNOT_BE_DERIVED_BY_THE_NETWORK);
145
@@ -791,7 +833,7 @@
146
                     S1AP_ProcedureCode_id_uplinkNASTransport) {
147
                 ogs_debug("    Uplink NAS Transport");
148
149
-                if (!MME_P_TMSI_IS_AVAILABLE(mme_ue)) {
150
+                if (!MME_CURRENT_P_TMSI_IS_AVAILABLE(mme_ue)) {
151
                     ogs_warn("No P-TMSI : UE%s", mme_ue->imsi_bcd);
152
                     r = nas_eps_send_service_reject(enb_ue, mme_ue,
153
                         OGS_NAS_EMM_CAUSE_UE_IDENTITY_CANNOT_BE_DERIVED_BY_THE_NETWORK);
154
@@ -874,7 +916,7 @@
155
              */
156
             CLEAR_S1_CONTEXT(mme_ue);
157
158
-            if (MME_P_TMSI_IS_AVAILABLE(mme_ue)) {
159
+            if (MME_CURRENT_P_TMSI_IS_AVAILABLE(mme_ue)) {
160
                 ogs_assert(OGS_OK == sgsap_send_detach_indication(mme_ue));
161
             } else {
162
                 mme_send_delete_session_or_detach(enb_ue, mme_ue);
163
@@ -932,8 +974,62 @@
164
             break;
165
166
         case OGS_NAS_EPS_TRACKING_AREA_UPDATE_COMPLETE:
167
-            ogs_error("%s Tracking area update complete in INVALID-STATE",
168
-                        mme_ue->imsi_bcd);
169
+            ogs_info("%s Tracking area update complete", mme_ue->imsi_bcd);
170
+
171
+        /*
172
+         * TS24.301
173
+         * Section 4.4.4.3
174
+         * Integrity checking of NAS signalling messages in the MME:
175
+         *
176
+         * Once the secure exchange of NAS messages has been established
177
+         * for the NAS signalling connection, the receiving EMM or ESM entity
178
+         * in the MME shall not process any NAS signalling messages
179
+         * unless they have been successfully integrity checked by the NAS.
180
+         * If any NAS signalling message, having not successfully passed
181
+         * the integrity check, is received, then the NAS in the MME shall
182
+         * discard that message. If any NAS signalling message is received,
183
+         * as not integrity protected even though the secure exchange
184
+         * of NAS messages has been established, then the NAS shall discard
185
+         * this message.
186
+         */
187
+            h.type = e->nas_type;
188
+            if (h.integrity_protected == 0) {
189
+                ogs_error("%s No Integrity Protected", mme_ue->imsi_bcd);
190
+                break;
191
+            }
192
+
193
+            if (!SECURITY_CONTEXT_IS_VALID(mme_ue)) {
194
+                ogs_error("%s No Security Context", mme_ue->imsi_bcd);
195
+                break;
196
+            }
197
+
198
+            /*
199
+             * If the OLD ENB_UE is being maintained in MME-UE Context,
200
+             * it deletes the S1 Context after exchanging
201
​
View file
open5gs_2.7.2.4536.c888.202411042026.tar.xz/src/mme/mme-context.c -> open5gs_2.7.2.4538.4211.202411052026.tar.xz/src/mme/mme-context.c Changed
78
 
1
@@ -3300,7 +3300,7 @@
2
     ogs_assert(served_gummei->num_of_mme_gid > 0);
3
     ogs_assert(served_gummei->num_of_mme_code > 0);
4
5
-    if (mme_ue->next.m_tmsi) {
6
+    if (MME_NEXT_GUTI_IS_AVAILABLE(mme_ue)) {
7
         ogs_warn("GUTI has already been allocated");
8
         return;
9
     }
10
@@ -3320,9 +3320,9 @@
11
12
 void mme_ue_confirm_guti(mme_ue_t *mme_ue)
13
 {
14
-    ogs_assert(mme_ue->next.m_tmsi);
15
+    ogs_assert(MME_NEXT_GUTI_IS_AVAILABLE(mme_ue));
16
17
-    if (mme_ue->current.m_tmsi) {
18
+    if (MME_CURRENT_GUTI_IS_AVAILABLE(mme_ue)) {
19
         /* MME has a VALID GUTI
20
          * As such, we need to remove previous GUTI in hash table */
21
         ogs_hash_set(self.guti_ue_hash,
22
@@ -3348,6 +3348,37 @@
23
               mme_ue->current.guti.m_tmsi);
24
 }
25
26
+void mme_ue_set_p_tmsi(
27
+        mme_ue_t *mme_ue,
28
+        ogs_nas_mobile_identity_tmsi_t *nas_mobile_identity_tmsi)
29
+{
30
+    ogs_assert(mme_ue);
31
+    ogs_assert(nas_mobile_identity_tmsi);
32
+
33
+    /*
34
+     * If the P-TMSI received from MSC/VLR is different from the current P-TMSI
35
+     * known by the MME, store this new P-TMSI as 'Next P-TMSI'. This value will
36
+     * be sent to the UE through the Attach Accept or TAU Accept message.
37
+     *
38
+     * When the UE sends an Attach Complete or TAU Complete message,
39
+     * the MME updates the 'Current P-TMSI' with the value in 'Next P-TMSI',
40
+     * thereby confirming and saving the new P-TMSI.
41
+     */
42
+    mme_ue->next.p_tmsi = be32toh(nas_mobile_identity_tmsi->tmsi);
43
+    if (mme_ue->next.p_tmsi != INVALID_P_TMSI) {
44
+        if (mme_ue->current.p_tmsi == mme_ue->next.p_tmsi)
45
+            mme_ue->next.p_tmsi = INVALID_P_TMSI;
46
+    }
47
+}
48
+void mme_ue_confirm_p_tmsi(mme_ue_t *mme_ue)
49
+{
50
+    ogs_assert(mme_ue);
51
+    ogs_assert(mme_ue->next.p_tmsi);
52
+
53
+    mme_ue->current.p_tmsi = mme_ue->next.p_tmsi;
54
+    mme_ue->next.p_tmsi = INVALID_P_TMSI;
55
+}
56
+
57
 static bool compare_ue_info(mme_sgw_t *node, enb_ue_t *enb_ue)
58
 {
59
     int i;
60
@@ -3567,14 +3598,15 @@
61
         ogs_hash_set(mme_self()->imsi_ue_hash,
62
                 mme_ue->imsi, mme_ue->imsi_len, NULL);
63
64
-    if (mme_ue->current.m_tmsi) {
65
+    if (MME_CURRENT_GUTI_IS_AVAILABLE(mme_ue)) {
66
         ogs_hash_set(self.guti_ue_hash,
67
                 &mme_ue->current.guti, sizeof(ogs_nas_eps_guti_t), NULL);
68
         ogs_assert(mme_m_tmsi_free(mme_ue->current.m_tmsi) == OGS_OK);
69
     }
70
71
-    if (mme_ue->next.m_tmsi)
72
+    if (MME_NEXT_GUTI_IS_AVAILABLE(mme_ue)) {
73
         ogs_assert(mme_m_tmsi_free(mme_ue->next.m_tmsi) == OGS_OK);
74
+    }
75
76
     /* Clear the saved PDN Connectivity Request */
77
     OGS_NAS_CLEAR_DATA(&mme_ue->pdn_connectivity_request);
78
​
View file
open5gs_2.7.2.4536.c888.202411042026.tar.xz/src/mme/mme-context.h -> open5gs_2.7.2.4538.4211.202411052026.tar.xz/src/mme/mme-context.h Changed
72
 
1
@@ -204,8 +204,6 @@
2
 #define MME_SGSAP_IS_CONNECTED(__mME) \
3
     ((__mME) && ((__mME)->csmap) && ((__mME)->csmap->vlr) && \
4
      (OGS_FSM_CHECK(&(__mME)->csmap->vlr->sm, sgsap_state_connected)))
5
-#define MME_P_TMSI_IS_AVAILABLE(__mME) \
6
-    (MME_SGSAP_IS_CONNECTED(__mME) && (__mME)->p_tmsi)
7
8
 typedef struct mme_vlr_s {
9
     ogs_lnode_t     lnode;
10
@@ -363,6 +361,11 @@
11
         ogs_nas_detach_type_t detach;
12
     } nas_eps;
13
14
+#define MME_TAU_TYPE_INITIAL_UE_MESSAGE    1
15
+#define MME_TAU_TYPE_UPLINK_NAS_TRANPORT   2
16
+#define MME_TAU_TYPE_UNPROTECTED_INGERITY  3
17
+    uint8_t tracking_area_update_request_type;
18
+
19
     /* 1. MME initiated detach request to the UE.
20
      *    (nas_eps.type = MME_EPS_TYPE_DETACH_REQUEST_TO_UE)
21
      * 2. If UE is IDLE, Paging sent to the UE
22
@@ -403,7 +406,6 @@
23
     int             a_msisdn_len;
24
     char            a_msisdn_bcdOGS_MAX_MSISDN_BCD_LEN+1;
25
26
-    mme_p_tmsi_t    p_tmsi;
27
     struct {
28
         ogs_pool_id_t   *mme_gn_teid_node; /* A node of MME-Gn-TEID */
29
         uint32_t        mme_gn_teid;   /* MME-Gn-TEID is derived from NODE */
30
@@ -416,8 +418,15 @@
31
     } gn;
32
33
     struct {
34
+#define MME_NEXT_GUTI_IS_AVAILABLE(__mME) ((__mME)->next.m_tmsi)
35
+#define MME_CURRENT_GUTI_IS_AVAILABLE(__mME) ((__mME)->current.m_tmsi)
36
         mme_m_tmsi_t *m_tmsi;
37
         ogs_nas_eps_guti_t guti;
38
+#define MME_NEXT_P_TMSI_IS_AVAILABLE(__mME) \
39
+    (MME_SGSAP_IS_CONNECTED(__mME) && (__mME)->next.p_tmsi)
40
+#define MME_CURRENT_P_TMSI_IS_AVAILABLE(__mME) \
41
+    (MME_SGSAP_IS_CONNECTED(__mME) && (__mME)->current.p_tmsi)
42
+        mme_p_tmsi_t    p_tmsi;
43
     } current, next;
44
45
     ogs_pool_id_t   *mme_s11_teid_node; /* A node of MME-S11-TEID */
46
@@ -659,10 +668,10 @@
47
     } while(0);
48
49
 #define CS_CALL_SERVICE_INDICATOR(__mME) \
50
-    (MME_P_TMSI_IS_AVAILABLE(__mME) && \
51
+    (MME_CURRENT_P_TMSI_IS_AVAILABLE(__mME) && \
52
      ((__mME)->service_indicator) == SGSAP_CS_CALL_SERVICE_INDICATOR)
53
 #define SMS_SERVICE_INDICATOR(__mME) \
54
-    (MME_P_TMSI_IS_AVAILABLE(__mME) && \
55
+    (MME_CURRENT_P_TMSI_IS_AVAILABLE(__mME) && \
56
      ((__mME)->service_indicator) == SGSAP_SMS_SERVICE_INDICATOR)
57
     uint8_t         service_indicator;
58
59
@@ -981,6 +990,12 @@
60
 void mme_ue_new_guti(mme_ue_t *mme_ue);
61
 void mme_ue_confirm_guti(mme_ue_t *mme_ue);
62
63
+#define INVALID_P_TMSI 0
64
+void mme_ue_set_p_tmsi(
65
+        mme_ue_t *mme_ue,
66
+        ogs_nas_mobile_identity_tmsi_t *nas_mobile_identity_tmsi);
67
+void mme_ue_confirm_p_tmsi(mme_ue_t *mme_ue);
68
+
69
 mme_ue_t *mme_ue_add(enb_ue_t *enb_ue);
70
 void mme_ue_remove(mme_ue_t *mme_ue);
71
 void mme_ue_remove_all(void);
72
​
View file
open5gs_2.7.2.4536.c888.202411042026.tar.xz/src/mme/mme-path.c -> open5gs_2.7.2.4538.4211.202411052026.tar.xz/src/mme/mme-path.c Changed
10
 
1
@@ -302,7 +302,7 @@
2
             r = nas_eps_send_detach_request(mme_ue);
3
             ogs_expect(r == OGS_OK);
4
             ogs_assert(r != OGS_ERROR);
5
-            if (MME_P_TMSI_IS_AVAILABLE(mme_ue)) {
6
+            if (MME_CURRENT_P_TMSI_IS_AVAILABLE(mme_ue)) {
7
                 ogs_assert(OGS_OK == sgsap_send_detach_indication(mme_ue));
8
             } else {
9
                 enb_ue_t *enb_ue = enb_ue_find_by_id(mme_ue->enb_ue_id);
10
​
View file
open5gs_2.7.2.4536.c888.202411042026.tar.xz/src/mme/mme-s6a-handler.c -> open5gs_2.7.2.4538.4211.202411052026.tar.xz/src/mme/mme-s6a-handler.c Changed
50
 
1
@@ -123,10 +123,26 @@
2
             return OGS_NAS_EMM_CAUSE_NO_EPS_BEARER_CONTEXT_ACTIVATED;
3
         }
4
5
-        r = nas_eps_send_tau_accept(mme_ue,
6
-                S1AP_ProcedureCode_id_InitialContextSetup);
7
-        ogs_expect(r == OGS_OK);
8
-        ogs_assert(r != OGS_ERROR);
9
+        /* Update CSMAP from Tracking area update request */
10
+        mme_ue->csmap = mme_csmap_find_by_tai(&mme_ue->tai);
11
+        if (mme_ue->csmap &&
12
+            mme_ue->network_access_mode ==
13
+                OGS_NETWORK_ACCESS_MODE_PACKET_AND_CIRCUIT &&
14
+            (mme_ue->nas_eps.update.value ==
15
+             OGS_NAS_EPS_UPDATE_TYPE_COMBINED_TA_LA_UPDATING ||
16
+             mme_ue->nas_eps.update.value ==
17
+             OGS_NAS_EPS_UPDATE_TYPE_COMBINED_TA_LA_UPDATING_WITH_IMSI_ATTACH)) {
18
+
19
+            mme_ue->tracking_area_update_request_type =
20
+                MME_TAU_TYPE_UNPROTECTED_INGERITY;
21
+            ogs_assert(OGS_OK == sgsap_send_location_update_request(mme_ue));
22
+
23
+        } else {
24
+            r = nas_eps_send_tau_accept(mme_ue,
25
+                    S1AP_ProcedureCode_id_InitialContextSetup);
26
+            ogs_expect(r == OGS_OK);
27
+            ogs_assert(r != OGS_ERROR);
28
+        }
29
     } else {
30
         ogs_error("Invalid Type%d", mme_ue->nas_eps.type);
31
         return OGS_NAS_EMM_CAUSE_PROTOCOL_ERROR_UNSPECIFIED;
32
@@ -275,7 +291,7 @@
33
             r = nas_eps_send_detach_request(mme_ue);
34
             ogs_expect(r == OGS_OK);
35
             ogs_assert(r != OGS_ERROR);
36
-            if (MME_P_TMSI_IS_AVAILABLE(mme_ue)) {
37
+            if (MME_CURRENT_P_TMSI_IS_AVAILABLE(mme_ue)) {
38
                 ogs_assert(OGS_OK == sgsap_send_detach_indication(mme_ue));
39
             } else {
40
                 enb_ue_t *enb_ue = enb_ue_find_by_id(mme_ue->enb_ue_id);
41
@@ -304,7 +320,7 @@
42
          * There is no need to send NAS or S1AP message to the UE.
43
          * So, we don't have to check whether UE is IDLE or not.
44
          */
45
-        if (MME_P_TMSI_IS_AVAILABLE(mme_ue)) {
46
+        if (MME_CURRENT_P_TMSI_IS_AVAILABLE(mme_ue)) {
47
             ogs_assert(OGS_OK == sgsap_send_detach_indication(mme_ue));
48
         } else {
49
             enb_ue_t *enb_ue = enb_ue_find_by_id(mme_ue->enb_ue_id);
50
​
View file
open5gs_2.7.2.4536.c888.202411042026.tar.xz/src/mme/nas-path.c -> open5gs_2.7.2.4538.4211.202411052026.tar.xz/src/mme/nas-path.c Changed
27
 
1
@@ -857,17 +857,15 @@
2
         return OGS_ERROR;
3
     }
4
5
-    if (mme_ue->next.m_tmsi) {
6
-        CLEAR_MME_UE_TIMER(mme_ue->t3450);
7
-        mme_ue->t3450.pkbuf = ogs_pkbuf_copy(emmbuf);
8
-        if (!mme_ue->t3450.pkbuf) {
9
-            ogs_error("ogs_pkbuf_copy(mme_ue->t3450.pkbuf) failed");
10
-            ogs_pkbuf_free(emmbuf);
11
-            return OGS_ERROR;
12
-        }
13
-        ogs_timer_start(mme_ue->t3450.timer,
14
-                mme_timer_cfg(MME_TIMER_T3450)->duration);
15
+    CLEAR_MME_UE_TIMER(mme_ue->t3450);
16
+    mme_ue->t3450.pkbuf = ogs_pkbuf_copy(emmbuf);
17
+    if (!mme_ue->t3450.pkbuf) {
18
+        ogs_error("ogs_pkbuf_copy(mme_ue->t3450.pkbuf) failed");
19
+        ogs_pkbuf_free(emmbuf);
20
+        return OGS_ERROR;
21
     }
22
+    ogs_timer_start(mme_ue->t3450.timer,
23
+            mme_timer_cfg(MME_TIMER_T3450)->duration);
24
25
     if (procedureCode == S1AP_ProcedureCode_id_InitialContextSetup) {
26
         ogs_pkbuf_t *s1apbuf = NULL;
27
​
View file
open5gs_2.7.2.4536.c888.202411042026.tar.xz/src/mme/s1ap-build.c -> open5gs_2.7.2.4538.4211.202411052026.tar.xz/src/mme/s1ap-build.c Changed
37
 
1
@@ -692,7 +692,7 @@
2
     ogs_log_hexdump(OGS_LOG_DEBUG, SecurityKey->buf, SecurityKey->size);
3
4
     if (mme_ue->nas_eps.type == MME_EPS_TYPE_EXTENDED_SERVICE_REQUEST &&
5
-        MME_P_TMSI_IS_AVAILABLE(mme_ue)) {
6
+        MME_CURRENT_P_TMSI_IS_AVAILABLE(mme_ue)) {
7
8
         /* Set CS-Fallback */
9
         S1AP_CSFallbackIndicator_t *CSFallbackIndicator = NULL;
10
@@ -727,7 +727,7 @@
11
         ogs_s1ap_buffer_to_OCTET_STRING(
12
             &mme_ue->tai.plmn_id, sizeof(ogs_plmn_id_t), &LAI->pLMNidentity);
13
         ogs_assert(mme_ue->csmap);
14
-        ogs_assert(mme_ue->p_tmsi);
15
+        ogs_assert(mme_ue->current.p_tmsi);
16
         ogs_asn_uint16_to_OCTET_STRING(mme_ue->csmap->lai.lac, &LAI->lAC);
17
18
     }
19
@@ -891,7 +891,7 @@
20
             enb_ue->enb_ue_s1ap_id, enb_ue->mme_ue_s1ap_id);
21
22
     if (mme_ue->nas_eps.type == MME_EPS_TYPE_EXTENDED_SERVICE_REQUEST &&
23
-        MME_P_TMSI_IS_AVAILABLE(mme_ue)) {
24
+        MME_CURRENT_P_TMSI_IS_AVAILABLE(mme_ue)) {
25
         ie = CALLOC(1, sizeof(S1AP_UEContextModificationRequestIEs_t));
26
         ASN_SEQUENCE_ADD(&UEContextModificationRequest->protocolIEs, ie);
27
28
@@ -919,7 +919,7 @@
29
         ogs_s1ap_buffer_to_OCTET_STRING(
30
             &mme_ue->tai.plmn_id, sizeof(ogs_plmn_id_t), &LAI->pLMNidentity);
31
         ogs_assert(mme_ue->csmap);
32
-        ogs_assert(mme_ue->p_tmsi);
33
+        ogs_assert(mme_ue->current.p_tmsi);
34
         ogs_asn_uint16_to_OCTET_STRING(mme_ue->csmap->lai.lac, &LAI->lAC);
35
36
     } else {
37
​
View file
open5gs_2.7.2.4536.c888.202411042026.tar.xz/src/mme/sgsap-handler.c -> open5gs_2.7.2.4538.4211.202411052026.tar.xz/src/mme/sgsap-handler.c Changed
201
 
1
@@ -101,6 +101,12 @@
2
         goto error;
3
     }
4
5
+    enb_ue = enb_ue_find_by_id(mme_ue->enb_ue_id);
6
+    if (!enb_ue) {
7
+        ogs_error("!enb_ue");
8
+        goto error;
9
+    }
10
+
11
     ogs_debug("    IMSI%s", mme_ue->imsi_bcd);
12
     if (lai) {
13
         ogs_debug("    LAIPLMN_ID:%06x,LAC:%d",
14
@@ -109,38 +115,125 @@
15
16
     if (nas_mobile_identity_tmsi) {
17
         if (nas_mobile_identity_tmsi->type == OGS_NAS_MOBILE_IDENTITY_TMSI) {
18
-            mme_ue->p_tmsi = be32toh(nas_mobile_identity_tmsi->tmsi);
19
+            mme_ue_set_p_tmsi(mme_ue, nas_mobile_identity_tmsi);
20
         } else {
21
             ogs_error("Not supported Identity type%d",
22
                     nas_mobile_identity_tmsi->type);
23
             goto error;
24
         }
25
-        ogs_debug("    P-TMSI0x%08x", mme_ue->p_tmsi);
26
+        ogs_debug("    P-TMSI0x%08x", mme_ue->next.p_tmsi);
27
     }
28
29
-    r = nas_eps_send_attach_accept(mme_ue);
30
-    ogs_expect(r == OGS_OK);
31
-    ogs_assert(r != OGS_ERROR);
32
+    if (mme_ue->nas_eps.type == MME_EPS_TYPE_ATTACH_REQUEST) {
33
+        r = nas_eps_send_attach_accept(mme_ue);
34
+        ogs_expect(r == OGS_OK);
35
+        ogs_assert(r != OGS_ERROR);
36
+    } else if (mme_ue->nas_eps.type == MME_EPS_TYPE_TAU_REQUEST) {
37
+        if (mme_ue->tracking_area_update_request_type ==
38
+                MME_TAU_TYPE_INITIAL_UE_MESSAGE) {
39
+            ogs_debug("    Iniital UE Message");
40
+            if (mme_ue->nas_eps.update.active_flag) {
41
+
42
+/*
43
+* TS33.401
44
+* 7 Security procedures between UE and EPS access network elements
45
+* 7.2 Handling of user-related keys in E-UTRAN
46
+* 7.2.7 Key handling for the TAU procedure when registered in E-UTRAN
47
+*
48
+* If the "active flag" is set in the TAU request message or
49
+* the MME chooses to establish radio bearers when there is pending downlink
50
+* UP data or pending downlink signalling, radio bearers will be established
51
+* as part of the TAU procedure and a KeNB derivation is necessary.
52
+*/
53
+                ogs_kdf_kenb(mme_ue->kasme, mme_ue->ul_count.i32,
54
+                        mme_ue->kenb);
55
+                ogs_kdf_nh_enb(mme_ue->kasme, mme_ue->kenb, mme_ue->nh);
56
+                mme_ue->nhcc = 1;
57
+
58
+                r = nas_eps_send_tau_accept(mme_ue,
59
+                        S1AP_ProcedureCode_id_InitialContextSetup);
60
+                ogs_expect(r == OGS_OK);
61
+                ogs_assert(r != OGS_ERROR);
62
+            } else {
63
+                r = nas_eps_send_tau_accept(mme_ue,
64
+                        S1AP_ProcedureCode_id_downlinkNASTransport);
65
+                ogs_expect(r == OGS_OK);
66
+                ogs_assert(r != OGS_ERROR);
67
+            }
68
+        } else if (mme_ue->tracking_area_update_request_type ==
69
+                MME_TAU_TYPE_UPLINK_NAS_TRANPORT) {
70
+            ogs_debug("    Uplink NAS Transport");
71
+            r = nas_eps_send_tau_accept(mme_ue,
72
+                    S1AP_ProcedureCode_id_downlinkNASTransport);
73
+            ogs_expect(r == OGS_OK);
74
+            ogs_assert(r != OGS_ERROR);
75
+        } else if (mme_ue->tracking_area_update_request_type ==
76
+                MME_TAU_TYPE_UNPROTECTED_INGERITY) {
77
+            ogs_debug("    Unprotected Integrity");
78
+            r = nas_eps_send_tau_accept(mme_ue,
79
+                    S1AP_ProcedureCode_id_InitialContextSetup);
80
+            ogs_expect(r == OGS_OK);
81
+        } else {
82
+            ogs_error("Invalid TAU Type%d",
83
+                    mme_ue->tracking_area_update_request_type);
84
+            return;
85
+        }
86
+
87
+        /*
88
+         * When active_flag is 0, check if the P-TMSI has been updated.
89
+         * If the P-TMSI has changed, wait to receive the TAU Complete message
90
+         * from the UE before sending the UEContextReleaseCommand.
91
+         *
92
+         * This ensures that the UE has acknowledged the new P-TMSI,
93
+         * allowing the TAU procedure to complete successfully
94
+         * and maintaining synchronization between the UE and the network.
95
+         */
96
+        if (!mme_ue->nas_eps.update.active_flag &&
97
+            !MME_NEXT_P_TMSI_IS_AVAILABLE(mme_ue)) {
98
+            enb_ue->relcause.group = S1AP_Cause_PR_nas;
99
+            enb_ue->relcause.cause = S1AP_CauseNas_normal_release;
100
+            mme_send_release_access_bearer_or_ue_context_release(enb_ue);
101
+        }
102
+    } else {
103
+        ogs_fatal("%s Invalid EPS-Type%d",
104
+                mme_ue->imsi_bcd, mme_ue->nas_eps.type);
105
+        ogs_assert_if_reached();
106
+    }
107
108
     return;
109
110
 error:
111
-    /* Clang scan-build SA: NULL pointer dereference: mme_ue=NULL if root=NULL. */
112
+    /* Clang scan-build SA:
113
+     * NULL pointer dereference: mme_ue=NULL if root=NULL. */
114
     if (!mme_ue) {
115
         ogs_error("!mme_ue");
116
         return;
117
-    }
118
+    }
119
     enb_ue = enb_ue_find_by_id(mme_ue->enb_ue_id);
120
-    if (enb_ue) {
121
+    if (!enb_ue) {
122
+        ogs_error("ENB-S1 Context has already been removed");
123
+        return;
124
+    }
125
+
126
+    if (mme_ue->nas_eps.type == MME_EPS_TYPE_ATTACH_REQUEST) {
127
         r = nas_eps_send_attach_reject(
128
                 enb_ue, mme_ue,
129
                 OGS_NAS_EMM_CAUSE_PROTOCOL_ERROR_UNSPECIFIED,
130
                 OGS_NAS_ESM_CAUSE_PROTOCOL_ERROR_UNSPECIFIED);
131
         ogs_expect(r == OGS_OK);
132
         ogs_assert(r != OGS_ERROR);
133
-        mme_send_delete_session_or_mme_ue_context_release(enb_ue, mme_ue);
134
-    } else
135
-        ogs_error("ENB-S1 Context has already been removed");
136
+    } else if (mme_ue->nas_eps.type == MME_EPS_TYPE_TAU_REQUEST) {
137
+        r = nas_eps_send_tau_reject(
138
+                enb_ue, mme_ue,
139
+                OGS_NAS_EMM_CAUSE_UE_IDENTITY_CANNOT_BE_DERIVED_BY_THE_NETWORK);
140
+        ogs_expect(r == OGS_OK);
141
+        ogs_assert(r != OGS_ERROR);
142
+    } else {
143
+        ogs_fatal("%s Invalid EPS-Type%d",
144
+                mme_ue->imsi_bcd, mme_ue->nas_eps.type);
145
+        ogs_assert_if_reached();
146
+    }
147
+    mme_send_delete_session_or_mme_ue_context_release(enb_ue, mme_ue);
148
 }
149
150
 void sgsap_handle_location_update_reject(mme_vlr_t *vlr, ogs_pkbuf_t *pkbuf)
151
@@ -148,6 +241,7 @@
152
     int r;
153
     ogs_tlv_t *root = NULL, *iter = NULL;
154
     mme_ue_t *mme_ue = NULL;
155
+    enb_ue_t *enb_ue = NULL;
156
157
     char imsi_bcdOGS_MAX_IMSI_BCD_LEN+1;
158
159
@@ -215,15 +309,94 @@
160
         return;
161
     }
162
163
+    enb_ue = enb_ue_find_by_id(mme_ue->enb_ue_id);
164
+    if (!enb_ue) {
165
+        ogs_error("!enb_ue");
166
+        goto error;
167
+    }
168
+
169
     ogs_debug("    IMSI%s CAUSE%d", mme_ue->imsi_bcd, emm_cause);
170
     if (lai) {
171
         ogs_debug("    LAIPLMN_ID:%06x,LAC:%d",
172
                     ogs_plmn_id_hexdump(&lai->nas_plmn_id), lai->lac);
173
     }
174
175
-    r = nas_eps_send_attach_accept(mme_ue);
176
-    ogs_expect(r == OGS_OK);
177
-    ogs_assert(r != OGS_ERROR);
178
+    if (mme_ue->nas_eps.type == MME_EPS_TYPE_ATTACH_REQUEST) {
179
+        r = nas_eps_send_attach_accept(mme_ue);
180
+        ogs_expect(r == OGS_OK);
181
+        ogs_assert(r != OGS_ERROR);
182
+    } else if (mme_ue->nas_eps.type == MME_EPS_TYPE_TAU_REQUEST) {
183
+        if (mme_ue->tracking_area_update_request_type ==
184
+                MME_TAU_TYPE_INITIAL_UE_MESSAGE) {
185
+            ogs_debug("    Iniital UE Message");
186
+            if (mme_ue->nas_eps.update.active_flag) {
187
+
188
+/*
189
+* TS33.401
190
+* 7 Security procedures between UE and EPS access network elements
191
+* 7.2 Handling of user-related keys in E-UTRAN
192
+* 7.2.7 Key handling for the TAU procedure when registered in E-UTRAN
193
+*
194
+* If the "active flag" is set in the TAU request message or
195
+* the MME chooses to establish radio bearers when there is pending downlink
196
+* UP data or pending downlink signalling, radio bearers will be established
197
+* as part of the TAU procedure and a KeNB derivation is necessary.
198
+*/
199
+                ogs_kdf_kenb(mme_ue->kasme, mme_ue->ul_count.i32,
200
+                        mme_ue->kenb);
201
​
View file
open5gs_2.7.2.4536.c888.202411042026.tar.xz/src/smf/ngap-build.c -> open5gs_2.7.2.4538.4211.202411052026.tar.xz/src/smf/ngap-build.c Changed
31
 
1
@@ -85,7 +85,8 @@
2
3
     ogs_assert(OGS_OK == ogs_sockaddr_to_ip(
4
                 sess->upf_n3_addr, sess->upf_n3_addr6, &upf_n3_ip));
5
-    ogs_asn_ip_to_BIT_STRING(&upf_n3_ip, &gTPTunnel->transportLayerAddress);
6
+    ogs_assert(OGS_OK == ogs_asn_ip_to_BIT_STRING(
7
+                &upf_n3_ip, &gTPTunnel->transportLayerAddress));
8
     ogs_asn_uint32_to_OCTET_STRING(sess->upf_n3_teid, &gTPTunnel->gTP_TEID);
9
10
     if (sess->handover.data_forwarding_not_possible == true) {
11
@@ -477,7 +478,8 @@
12
13
     ogs_assert(OGS_OK == ogs_sockaddr_to_ip(
14
                 sess->upf_n3_addr, sess->upf_n3_addr6, &upf_n3_ip));
15
-    ogs_asn_ip_to_BIT_STRING(&upf_n3_ip, &gTPTunnel->transportLayerAddress);
16
+    ogs_assert(OGS_OK == ogs_asn_ip_to_BIT_STRING(
17
+                &upf_n3_ip, &gTPTunnel->transportLayerAddress));
18
     ogs_asn_uint32_to_OCTET_STRING(sess->upf_n3_teid, &gTPTunnel->gTP_TEID);
19
20
 #endif
21
@@ -518,7 +520,8 @@
22
         ogs_assert(OGS_OK == ogs_sockaddr_to_ip(
23
                 sess->handover.upf_dl_addr, sess->handover.upf_dl_addr6,
24
                 &upf_dl_ip));
25
-        ogs_asn_ip_to_BIT_STRING(&upf_dl_ip, &gTPTunnel->transportLayerAddress);
26
+        ogs_assert(OGS_OK == ogs_asn_ip_to_BIT_STRING(
27
+                    &upf_dl_ip, &gTPTunnel->transportLayerAddress));
28
         ogs_asn_uint32_to_OCTET_STRING(
29
                 sess->handover.upf_dl_teid, &gTPTunnel->gTP_TEID);
30
31
​
View file
open5gs_2.7.2.4536.c888.202411042026.tar.xz/tests/app/5gc-init.c -> open5gs_2.7.2.4538.4211.202411052026.tar.xz/tests/app/5gc-init.c Changed
10
 
1
@@ -129,7 +129,7 @@
2
      *
3
      * If freeDiameter is not used, it uses a delay of less than 4 seconds.
4
      */
5
-    ogs_msleep(2000);
6
+    ogs_msleep(3000);
7
8
     return OGS_OK;
9
 }
10
​
View file
open5gs_2.7.2.4536.c888.202411042026.tar.xz/tests/common/sgsap-build.c -> open5gs_2.7.2.4538.4211.202411052026.tar.xz/tests/common/sgsap-build.c Changed
23
 
1
@@ -26,13 +26,21 @@
2
     ogs_pkbuf_t *pkbuf = NULL;
3
     const char *payloadTEST_SGSAP_MAX_MESSAGE = {
4
         "0a01089999073746 000006040509f107 09260e05f49ee88e 64",
5
+        "0a01089999073746 000006040509f107 09260e05f49ee88e 65",
6
+        "0a01089999073746 000006040509f107 09260e05f49ee88e 66",
7
+
8
         "0a01087942120000 000030040527f412 c9580e05f437ab9c c5",
9
         "",
10
+        "",
11
12
     };
13
     uint16_t lenTEST_SGSAP_MAX_MESSAGE = {
14
         25,
15
         25,
16
+        25,
17
+
18
+        25,
19
+        0,
20
         0,
21
     };
22
     char hexbufOGS_HUGE_LEN;
23
​
View file
open5gs_2.7.2.4536.c888.202411042026.tar.xz/tests/csfb/abts-main.c -> open5gs_2.7.2.4538.4211.202411052026.tar.xz/tests/csfb/abts-main.c Changed
17
 
1
@@ -25,6 +25,7 @@
2
 abts_suite *test_mt_active(abts_suite *suite);
3
 abts_suite *test_mo_sms(abts_suite *suite);
4
 abts_suite *test_mt_sms(abts_suite *suite);
5
+abts_suite *test_tau(abts_suite *suite);
6
 abts_suite *test_crash(abts_suite *suite);
7
8
 const struct testlist {
9
@@ -36,6 +37,7 @@
10
     {test_mt_active},
11
     {test_mo_sms},
12
     {test_mt_sms},
13
+    {test_tau},
14
     {test_crash},
15
     {NULL},
16
 };
17
​
View file
open5gs_2.7.2.4536.c888.202411042026.tar.xz/tests/csfb/meson.build -> open5gs_2.7.2.4538.4211.202411052026.tar.xz/tests/csfb/meson.build Changed
9
 
1
@@ -23,6 +23,7 @@
2
     mt-active-test.c
3
     mo-sms-test.c
4
     mt-sms-test.c
5
+    tau-test.c
6
     crash-test.c
7
 '''.split())
8
9
​
View file
open5gs_2.7.2.4538.4211.202411052026.tar.xz/tests/csfb/tau-test.c Added
201
 
1
@@ -0,0 +1,1538 @@
2
+/*
3
+ * Copyright (C) 2024 by Sukchan Lee <acetcom@gmail.com>
4
+ *
5
+ * This file is part of Open5GS.
6
+ *
7
+ * This program is free software: you can redistribute it and/or modify
8
+ * it under the terms of the GNU Affero General Public License as published by
9
+ * the Free Software Foundation, either version 3 of the License, or
10
+ * (at your option) any later version.
11
+ *
12
+ * This program is distributed in the hope that it will be useful,
13
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
14
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
15
+ * GNU General Public License for more details.
16
+ *
17
+ * You should have received a copy of the GNU General Public License
18
+ * along with this program.  If not, see <https://www.gnu.org/licenses/>.
19
+ */
20
+
21
+#include "test-common.h"
22
+
23
+extern ogs_socknode_t *sgsap;
24
+
25
+static void test_simple_func(abts_case *tc, void *data)
26
+{
27
+    int rv;
28
+    ogs_socknode_t *s1ap;
29
+    ogs_socknode_t *gtpu;
30
+    ogs_pkbuf_t *emmbuf;
31
+    ogs_pkbuf_t *esmbuf;
32
+    ogs_pkbuf_t *sendbuf;
33
+    ogs_pkbuf_t *recvbuf;
34
+    ogs_s1ap_message_t message;
35
+
36
+    ogs_nas_5gs_mobile_identity_suci_t mobile_identity_suci;
37
+    test_ue_t *test_ue = NULL;
38
+    test_sess_t *sess = NULL;
39
+    test_bearer_t *bearer = NULL;
40
+
41
+    uint32_t enb_ue_s1ap_id;
42
+    uint64_t mme_ue_s1ap_id;
43
+
44
+    bson_t *doc = NULL;
45
+
46
+    /* Setup Test UE & Session Context */
47
+    memset(&mobile_identity_suci, 0, sizeof(mobile_identity_suci));
48
+
49
+    mobile_identity_suci.h.supi_format = OGS_NAS_5GS_SUPI_FORMAT_IMSI;
50
+    mobile_identity_suci.h.type = OGS_NAS_5GS_MOBILE_IDENTITY_SUCI;
51
+    mobile_identity_suci.routing_indicator1 = 0;
52
+    mobile_identity_suci.routing_indicator2 = 0xf;
53
+    mobile_identity_suci.routing_indicator3 = 0xf;
54
+    mobile_identity_suci.routing_indicator4 = 0xf;
55
+    mobile_identity_suci.protection_scheme_id = OGS_PROTECTION_SCHEME_NULL;
56
+    mobile_identity_suci.home_network_pki_value = 0;
57
+
58
+    test_ue = test_ue_add_by_suci(&mobile_identity_suci, "3746000006");
59
+    ogs_assert(test_ue);
60
+
61
+    test_ue->e_cgi.cell_id = 0x54f6401;
62
+    test_ue->nas.ksi = OGS_NAS_KSI_NO_KEY_IS_AVAILABLE;
63
+    test_ue->nas.value = OGS_NAS_ATTACH_TYPE_COMBINED_EPS_IMSI_ATTACH;
64
+
65
+    test_ue->k_string = "465b5ce8b199b49faa5f0a2ee238a6bc";
66
+    test_ue->opc_string = "e8ed289deba952e4283b54e88e6183ca";
67
+
68
+    sess = test_sess_add_by_apn(test_ue, "internet", OGS_GTP2_RAT_TYPE_EUTRAN);
69
+    ogs_assert(sess);
70
+
71
+    /* eNB connects to MME */
72
+    s1ap = tests1ap_client(AF_INET);
73
+    ABTS_PTR_NOTNULL(tc, s1ap);
74
+
75
+    /* eNB connects to SGW */
76
+    gtpu = test_gtpu_server(1, AF_INET);
77
+    ABTS_PTR_NOTNULL(tc, gtpu);
78
+
79
+    /* Send S1-Setup Reqeust */
80
+    sendbuf = test_s1ap_build_s1_setup_request(
81
+            S1AP_ENB_ID_PR_macroENB_ID, 0x54f64);
82
+    ABTS_PTR_NOTNULL(tc, sendbuf);
83
+    rv = testenb_s1ap_send(s1ap, sendbuf);
84
+    ABTS_INT_EQUAL(tc, OGS_OK, rv);
85
+
86
+    /* Receive S1-Setup Response */
87
+    recvbuf = testenb_s1ap_read(s1ap);
88
+    ABTS_PTR_NOTNULL(tc, recvbuf);
89
+    tests1ap_recv(NULL, recvbuf);
90
+
91
+    /********** Insert Subscriber in Database */
92
+    doc = test_db_new_simple(test_ue);
93
+    ABTS_PTR_NOTNULL(tc, doc);
94
+    ABTS_INT_EQUAL(tc, OGS_OK, test_db_insert_ue(test_ue, doc));
95
+
96
+    /* Send Attach Request */
97
+    memset(&sess->pdn_connectivity_param,
98
+            0, sizeof(sess->pdn_connectivity_param));
99
+    sess->pdn_connectivity_param.eit = 1;
100
+    sess->pdn_connectivity_param.pco = 1;
101
+    sess->pdn_connectivity_param.request_type =
102
+        OGS_NAS_EPS_REQUEST_TYPE_INITIAL;
103
+    esmbuf = testesm_build_pdn_connectivity_request(
104
+            sess, false, OGS_NAS_EPS_PDN_TYPE_IPV4V6);
105
+    ABTS_PTR_NOTNULL(tc, esmbuf);
106
+
107
+    memset(&test_ue->attach_request_param,
108
+            0, sizeof(test_ue->attach_request_param));
109
+    test_ue->attach_request_param.ms_network_feature_support = 1;
110
+    emmbuf = testemm_build_attach_request(test_ue, esmbuf, false, false);
111
+    ABTS_PTR_NOTNULL(tc, emmbuf);
112
+
113
+    memset(&test_ue->initial_ue_param, 0, sizeof(test_ue->initial_ue_param));
114
+    sendbuf = test_s1ap_build_initial_ue_message(
115
+            test_ue, emmbuf, S1AP_RRC_Establishment_Cause_mo_Signalling, false);
116
+    ABTS_INT_EQUAL(tc, OGS_OK, rv);
117
+    rv = testenb_s1ap_send(s1ap, sendbuf);
118
+    ABTS_INT_EQUAL(tc, OGS_OK, rv);
119
+
120
+    /* Receive Authentication Request */
121
+    recvbuf = testenb_s1ap_read(s1ap);
122
+    ABTS_PTR_NOTNULL(tc, recvbuf);
123
+    tests1ap_recv(test_ue, recvbuf);
124
+
125
+    /* Send Authentication response */
126
+    emmbuf = testemm_build_authentication_response(test_ue);
127
+    ABTS_PTR_NOTNULL(tc, emmbuf);
128
+    sendbuf = test_s1ap_build_uplink_nas_transport(test_ue, emmbuf);
129
+    ABTS_PTR_NOTNULL(tc, sendbuf);
130
+    rv = testenb_s1ap_send(s1ap, sendbuf);
131
+    ABTS_INT_EQUAL(tc, OGS_OK, rv);
132
+
133
+    /* Receive Security mode Command */
134
+    recvbuf = testenb_s1ap_read(s1ap);
135
+    ABTS_PTR_NOTNULL(tc, recvbuf);
136
+    tests1ap_recv(test_ue, recvbuf);
137
+
138
+    /* Send Security mode complete */
139
+    test_ue->mobile_identity_imeisv_presence = true;
140
+    emmbuf = testemm_build_security_mode_complete(test_ue);
141
+    ABTS_PTR_NOTNULL(tc, emmbuf);
142
+    sendbuf = test_s1ap_build_uplink_nas_transport(test_ue, emmbuf);
143
+    ABTS_PTR_NOTNULL(tc, sendbuf);
144
+    rv = testenb_s1ap_send(s1ap, sendbuf);
145
+    ABTS_INT_EQUAL(tc, OGS_OK, rv);
146
+
147
+    /* Receive ESM Information Request */
148
+    recvbuf = testenb_s1ap_read(s1ap);
149
+    ABTS_PTR_NOTNULL(tc, recvbuf);
150
+    tests1ap_recv(test_ue, recvbuf);
151
+
152
+    /* Send ESM Information Response */
153
+    esmbuf = testesm_build_esm_information_response(sess);
154
+    ABTS_PTR_NOTNULL(tc, esmbuf);
155
+    sendbuf = test_s1ap_build_uplink_nas_transport(test_ue, esmbuf);
156
+    ABTS_PTR_NOTNULL(tc, sendbuf);
157
+    rv = testenb_s1ap_send(s1ap, sendbuf);
158
+    ABTS_INT_EQUAL(tc, OGS_OK, rv);
159
+
160
+    /* Receive SGsAP-Location-Update-Request */
161
+    recvbuf = testvlr_sgsap_read(sgsap);
162
+    ABTS_PTR_NOTNULL(tc, recvbuf);
163
+    ogs_pkbuf_free(recvbuf);
164
+
165
+    /* Send SGsAP-Location-Update-Accept */
166
+    sendbuf = test_sgsap_location_update_accept(1);
167
+    ABTS_PTR_NOTNULL(tc, sendbuf);
168
+    rv = testvlr_sgsap_send(sgsap, sendbuf);
169
+    ABTS_INT_EQUAL(tc, OGS_OK, rv);
170
+
171
+    /* Receive Initial Context Setup Request +
172
+     * Attach Accept +
173
+     * Activate Default Bearer Context Request */
174
+    recvbuf = testenb_s1ap_read(s1ap);
175
+    ABTS_PTR_NOTNULL(tc, recvbuf);
176
+    tests1ap_recv(test_ue, recvbuf);
177
+
178
+    /* Send UE Capability Info Indication */
179
+    sendbuf = tests1ap_build_ue_radio_capability_info_indication(test_ue);
180
+    ABTS_PTR_NOTNULL(tc, sendbuf);
181
+    rv = testenb_s1ap_send(s1ap, sendbuf);
182
+    ABTS_INT_EQUAL(tc, OGS_OK, rv);
183
+
184
+    /* Send Initial Context Setup Response */
185
+    sendbuf = test_s1ap_build_initial_context_setup_response(test_ue);
186
+    ABTS_PTR_NOTNULL(tc, sendbuf);
187
+    rv = testenb_s1ap_send(s1ap, sendbuf);
188
+    ABTS_INT_EQUAL(tc, OGS_OK, rv);
189
+
190
+    /* Send Attach Complete + Activate default EPS bearer cotext accept */
191
+    test_ue->nr_cgi.cell_id = 0x1234502;
192
+    bearer = test_bearer_find_by_ue_ebi(test_ue, 5);
193
+    ogs_assert(bearer);
194
+    esmbuf = testesm_build_activate_default_eps_bearer_context_accept(
195
+            bearer, false);
196
+    ABTS_PTR_NOTNULL(tc, esmbuf);
197
+    emmbuf = testemm_build_attach_complete(test_ue, esmbuf);
198
+    ABTS_PTR_NOTNULL(tc, emmbuf);
199
+    sendbuf = test_s1ap_build_uplink_nas_transport(test_ue, emmbuf);
200
+    ABTS_PTR_NOTNULL(tc, sendbuf);
201
​
Locations
Help
Contact