Osmocom Open Build Service

osmo-hnbgw.spec Changed

osmo-hnbgw_1.4.0.105.3a084.202306230026.dsc -> osmo-hnbgw_1.4.0.108.267a.202306240026.dsc Changed

@@ -2,7 +2,7 @@
 Source: osmo-hnbgw
 Binary: osmo-hnbgw, osmo-hnbgw-dbg, osmo-hnbgw-doc
 Architecture: any all
-Version: 1.4.0.105.3a084.202306230026
+Version: 1.4.0.108.267a.202306240026
 Maintainer: Osmocom team <openbsc@lists.osmocom.org>
 Homepage: https://projects.osmocom.org/projects/osmo-hnbgw
 Standards-Version: 3.9.8
@@ -14,8 +14,8 @@
  osmo-hnbgw-dbg deb debug extra arch=any
  osmo-hnbgw-doc deb doc optional arch=all
 Checksums-Sha1:
- 1e49f8a3f1b016bcdcd6771bae08da2c31991e2e 96972 osmo-hnbgw_1.4.0.105.3a084.202306230026.tar.xz
+ 49f7528d2fea9540aefe39e810b8e8802e4342a4 97076 osmo-hnbgw_1.4.0.108.267a.202306240026.tar.xz
 Checksums-Sha256:
- 23404ff06b3c4213d3af00b834e7a2c15268a72f5125611ee6f13174de005c24 96972 osmo-hnbgw_1.4.0.105.3a084.202306230026.tar.xz
+ cd7dc1e7315f6dc467f5e88e561515323875262cd7b0050a797dd561f0abfdce 97076 osmo-hnbgw_1.4.0.108.267a.202306240026.tar.xz
 Files:
- a42c3b466c004e6781b99461b8acc436 96972 osmo-hnbgw_1.4.0.105.3a084.202306230026.tar.xz
+ 0c1b0ae13d18abd6d0f3214bf10cf270 97076 osmo-hnbgw_1.4.0.108.267a.202306240026.tar.xz

osmo-hnbgw_1.4.0.105.3a084.202306230026.tar.xz/.tarball-version -> osmo-hnbgw_1.4.0.108.267a.202306240026.tar.xz/.tarball-version Changed

osmo-hnbgw_1.4.0.105.3a084.202306230026.tar.xz/contrib/osmo-hnbgw.spec.in -> osmo-hnbgw_1.4.0.108.267a.202306240026.tar.xz/contrib/osmo-hnbgw.spec.in Changed

osmo-hnbgw_1.4.0.105.3a084.202306230026.tar.xz/debian/changelog -> osmo-hnbgw_1.4.0.108.267a.202306240026.tar.xz/debian/changelog Changed

osmo-hnbgw_1.4.0.105.3a084.202306230026.tar.xz/debian/control -> osmo-hnbgw_1.4.0.108.267a.202306240026.tar.xz/debian/control Changed

osmo-hnbgw_1.4.0.105.3a084.202306230026.tar.xz/src/osmo-hnbgw/hnbgw_cn.c -> osmo-hnbgw_1.4.0.108.267a.202306240026.tar.xz/src/osmo-hnbgw/hnbgw_cn.c Changed

osmo-hnbgw_1.4.0.105.3a084.202306230026.tar.xz/src/osmo-hnbgw/ranap_rab_ass.c -> osmo-hnbgw_1.4.0.108.267a.202306240026.tar.xz/src/osmo-hnbgw/ranap_rab_ass.c Changed

@@ -41,11 +41,9 @@
 {
 	int rc;
 	struct msgb *msg;
-	RANAP_RAB_AssignmentRequest_t _rab_assignment_request;
+	RANAP_RAB_AssignmentRequest_t _rab_assignment_request = { 0 };
 	RANAP_RAB_AssignmentRequest_t *rab_assignment_request = &_rab_assignment_request;
 
-	memset(rab_assignment_request, 0, sizeof(*rab_assignment_request));
-
 	rc = ranap_encode_rab_assignmentrequesties(rab_assignment_request, rab_assignment_request_ies);
 	if (rc < 0)
 		return NULL;
@@ -72,11 +70,10 @@
 	int rc;
 	struct msgb *msg;
 
-	RANAP_RAB_AssignmentResponse_t _rab_assignment_response;
+	RANAP_RAB_AssignmentResponse_t _rab_assignment_response = { 0 };
 	RANAP_RAB_AssignmentResponse_t *rab_assignment_response = &_rab_assignment_response;
 
 	memset(data, 0, len);
-	memset(rab_assignment_response, 0, sizeof(*rab_assignment_response));
 
 	rc = ranap_encode_rab_assignmentresponseies(rab_assignment_response, rab_assignment_response_ies);
 	if (rc < 0)
@@ -176,7 +173,9 @@
 	return ies->raB_FailedList.raB_FailedList_ies.list.arrayindex;
 }
 
-/* find the RAB specified by rab_id in ies and when found, decode the result into items_ies */
+/* Find the RAB specified by rab_id in ies, decode the result into items_ies and return a positive index.
+ * The caller is responsible for freeing the contents in items_ies. In case of failure, the return code
+ * will be negative. */
 static int decode_rab_smditms_from_resp_ies(RANAP_RAB_SetupOrModifiedItemIEs_t *items_ies,
 					    RANAP_RAB_AssignmentResponseIEs_t *ies, uint8_t rab_id)
 {
@@ -313,7 +312,7 @@
 					    RANAP_RAB_AssignmentRequestIEs_t *ies, unsigned int index)
 {
 	RANAP_ProtocolIE_FieldPair_t *protocol_ie_field_pair;
-	RANAP_RAB_SetupOrModifyItemFirst_t _rab_setup_or_modify_item_first;
+	RANAP_RAB_SetupOrModifyItemFirst_t _rab_setup_or_modify_item_first = { 0 };
 	RANAP_RAB_SetupOrModifyItemFirst_t *rab_setup_or_modify_item_first = &_rab_setup_or_modify_item_first;
 	RANAP_TransportLayerAddress_t *trasp_layer_addr;
 	RANAP_IuTransportAssociation_t *transp_assoc;
@@ -382,7 +381,7 @@
  *  \returns 0 on success; negative on error. */
 int ranap_rab_ass_resp_ies_extract_inet_addr(struct osmo_sockaddr *addr, RANAP_RAB_AssignmentResponseIEs_t *ies, uint8_t rab_id)
 {
-	RANAP_RAB_SetupOrModifiedItemIEs_t _rab_setup_or_modified_items_ies;
+	RANAP_RAB_SetupOrModifiedItemIEs_t _rab_setup_or_modified_items_ies = { 0 };
 	RANAP_RAB_SetupOrModifiedItemIEs_t *rab_setup_or_modified_items_ies = &_rab_setup_or_modified_items_ies;
 	RANAP_RAB_SetupOrModifiedItem_t *rab_setup_or_modified_item;
 	uint16_t port;
@@ -434,7 +433,7 @@
 int ranap_rab_ass_req_ies_replace_inet_addr(RANAP_RAB_AssignmentRequestIEs_t *ies, struct osmo_sockaddr *addr, uint8_t rab_id)
 {
 	RANAP_ProtocolIE_FieldPair_t *protocol_ie_field_pair;
-	RANAP_RAB_SetupOrModifyItemFirst_t _rab_setup_or_modify_item_first;
+	RANAP_RAB_SetupOrModifyItemFirst_t _rab_setup_or_modify_item_first = { 0 };
 	RANAP_RAB_SetupOrModifyItemFirst_t *rab_setup_or_modify_item_first = &_rab_setup_or_modify_item_first;
 	RANAP_TransportLayerInformation_t *old_transport_layer_information = NULL;
 	RANAP_TransportLayerInformation_t *new_transport_layer_information = NULL;
@@ -504,7 +503,7 @@
 int ranap_rab_ass_resp_ies_replace_inet_addr(RANAP_RAB_AssignmentResponseIEs_t *ies, struct osmo_sockaddr *addr, uint8_t rab_id)
 {
 	RANAP_IE_t *setup_or_modified_list_ie;
-	RANAP_RAB_SetupOrModifiedItemIEs_t _rab_setup_or_modified_items_ies;
+	RANAP_RAB_SetupOrModifiedItemIEs_t _rab_setup_or_modified_items_ies = { 0 };
 	RANAP_RAB_SetupOrModifiedItemIEs_t *rab_setup_or_modified_items_ies = &_rab_setup_or_modified_items_ies;
 	RANAP_RAB_SetupOrModifiedItem_t *rab_setup_or_modified_item;
 	RANAP_TransportLayerInformation_t *temp_transport_layer_information = NULL;
@@ -573,20 +572,19 @@
  *  \returns true when RAB could be identified as failed; false otherwise */
 bool ranap_rab_ass_resp_ies_check_failure(RANAP_RAB_AssignmentResponseIEs_t *ies, uint8_t rab_id)
 {
-	RANAP_RAB_FailedItemIEs_t _rab_failed_items_ies;
+	RANAP_RAB_FailedItemIEs_t _rab_failed_items_ies = { 0 };
 	RANAP_RAB_FailedItemIEs_t *rab_failed_items_ies = &_rab_failed_items_ies;
 	int rc;
-	bool result = true;
 
-	/* If we can get a failed item for the specified RAB ID, then we know that the
+	/* If we can get a failed item (rc >= 0) for the specified RAB ID, then we know that the
 	 * HNB reported the RAB Assignment as failed */
 	rc = decode_rab_flitms_from_resp_ies(rab_failed_items_ies, ies, rab_id);
 	if (rc < 0)
-		result = false;
+		return false;
 
 	ASN_STRUCT_FREE_CONTENTS_ONLY(asn_DEF_RANAP_RAB_FailedItem, rab_failed_items_ies);
 
-	return result;
+	return true;
 }
 
 /*! Check if a specific RAB is present in an RAB-ReleaseList inside RANAP_RAB_AssignmentRequestIEs.
@@ -595,7 +593,7 @@
  *  \returns true when RAB is intended for release; false otherwise */
 bool ranap_rab_ass_req_ies_check_release(RANAP_RAB_AssignmentRequestIEs_t *ies, uint8_t rab_id)
 {
-	RANAP_RAB_ReleaseItemIEs_t _rab_release_items_ies;
+	RANAP_RAB_ReleaseItemIEs_t _rab_release_items_ies = { 0 };
 	RANAP_RAB_ReleaseItemIEs_t *rab_release_items_ies = &_rab_release_items_ies;
 	int rc;
 	bool result = true;

osmo-hnbgw_1.4.0.105.3a084.202306230026.tar.xz/tests/ranap_rab_ass/ranap_rab_ass_test.c -> osmo-hnbgw_1.4.0.108.267a.202306240026.tar.xz/tests/ranap_rab_ass/ranap_rab_ass_test.c Changed

@@ -299,6 +299,31 @@
 	ranap_cn_rx_co_free(&message);
 }
 
+/* Same as above but with a message that does not even contain a FailedItemsIEs list */
+void test_ranap_rab_ass_resp_ies_check_failure_no_faileditemies(void)
+{
+	int rc;
+	ranap_message message;
+	bool rab_failed_at_hnb;
+	uint8_t testvec = {
+		0x60, 0x00, 0x00, 0x2a, 0x00, 0x00, 0x01, 0x00,
+		0x34, 0x40, 0x23, 0x00, 0x00, 0x01, 0x00, 0x33,
+		0x40, 0x1c, 0x60, 0x3a, 0x7c, 0x35, 0x00, 0x01,
+		0x0a, 0x09, 0x01, 0xa4, 0x00, 0x00, 0x00, 0x00,
+		0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+		0x00, 0x40, 0x04, 0x0a, 0x00, 0x00
+	};
+
+	rc = ranap_cn_rx_co_decode2(&message, testvec, sizeof(testvec));
+
+	OSMO_ASSERT(rc == 0);
+	rab_failed_at_hnb =
+		ranap_rab_ass_resp_ies_check_failure(&message.msg.raB_AssignmentResponseIEs, 23);
+	OSMO_ASSERT(rab_failed_at_hnb == 0)
+
+	ranap_cn_rx_co_free(&message);
+}
+
 void test_ranap_rab_ass_req_ies_check_release(void)
 {
 	int rc;
@@ -413,6 +438,7 @@
 	test_ranap_rab_ass_req_ies_replace_inet_addr();
 	test_ranap_rab_ass_resp_ies_replace_inet_addr();
 	test_ranap_rab_ass_resp_ies_check_failure();
+	test_ranap_rab_ass_resp_ies_check_failure_no_faileditemies();
 	test_ranap_rab_ass_req_ies_check_release();
 	test_ranap_rab_ass_req_ies_get_count();

Changes of Revision 366