Osmocom Open Build Service

osmo-remsim_1.1.2.1.90c8.202602191800.tar.gz/.git/objects/pack/pack-2493015c7ac95d444de4a8499f43ae1176d28e8c.idx Deleted

osmo-remsim_1.1.2.1.90c8.202602191800.tar.gz/.git/objects/pack/pack-2493015c7ac95d444de4a8499f43ae1176d28e8c.pack Deleted

osmo-remsim_1.1.2.1.90c8.202602191800.tar.gz/.git/objects/pack/pack-2493015c7ac95d444de4a8499f43ae1176d28e8c.rev Deleted

osmo-remsim_1.1.2.1.90c8.202602191800.dsc -> osmo-remsim_1.1.3.202602201800.dsc Changed

osmo-remsim_1.1.2.1.90c8.202602191800.tar.gz/.git/HEAD -> osmo-remsim_1.1.3.202602201800.tar.gz/.git/HEAD Changed

osmo-remsim_1.1.2.1.90c8.202602191800.tar.gz/.git/ORIG_HEAD -> osmo-remsim_1.1.3.202602201800.tar.gz/.git/ORIG_HEAD Changed

osmo-remsim_1.1.2.1.90c8.202602191800.tar.gz/.git/index -> osmo-remsim_1.1.3.202602201800.tar.gz/.git/index Changed

osmo-remsim_1.1.2.1.90c8.202602191800.tar.gz/.git/logs/HEAD -> osmo-remsim_1.1.3.202602201800.tar.gz/.git/logs/HEAD Changed

osmo-remsim_1.1.2.1.90c8.202602191800.tar.gz/.git/logs/refs/heads/master -> osmo-remsim_1.1.3.202602201800.tar.gz/.git/logs/refs/heads/master Changed

osmo-remsim_1.1.2.1.90c8.202602191800.tar.gz/.git/logs/refs/remotes/origin/HEAD -> osmo-remsim_1.1.3.202602201800.tar.gz/.git/logs/refs/remotes/origin/HEAD Changed

osmo-remsim_1.1.3.202602201800.tar.gz/.git/objects/pack/pack-9e0771612293d3688278b25554238b7795010863.idx Added

osmo-remsim_1.1.3.202602201800.tar.gz/.git/objects/pack/pack-9e0771612293d3688278b25554238b7795010863.pack Added

osmo-remsim_1.1.3.202602201800.tar.gz/.git/objects/pack/pack-9e0771612293d3688278b25554238b7795010863.rev Added

osmo-remsim_1.1.2.1.90c8.202602191800.tar.gz/.git/packed-refs -> osmo-remsim_1.1.3.202602201800.tar.gz/.git/packed-refs Changed

osmo-remsim_1.1.2.1.90c8.202602191800.tar.gz/.git/refs/heads/master -> osmo-remsim_1.1.3.202602201800.tar.gz/.git/refs/heads/master Changed

osmo-remsim_1.1.2.1.90c8.202602191800.tar.gz/.tarball-version -> osmo-remsim_1.1.3.202602201800.tar.gz/.tarball-version Changed

osmo-remsim_1.1.2.1.90c8.202602191800.tar.gz/debian/changelog -> osmo-remsim_1.1.3.202602201800.tar.gz/debian/changelog Changed

osmo-remsim_1.1.2.1.90c8.202602191800.tar.gz/debian/control -> osmo-remsim_1.1.3.202602201800.tar.gz/debian/control Changed

@@ -25,7 +25,7 @@
 Section: libs
 Architecture: any
 Multi-Arch: same
-Depends: osmocom-nightly (= 202602191800), ${shlibs:Depends}, ${misc:Depends}
+Depends: osmocom-nightly (= 202602201800), ${shlibs:Depends}, ${misc:Depends}
 Pre-Depends: ${misc:Pre-Depends}
 Description: Osmocom Remote SIM - Shared Library
  libosmo-rsrpo is an utility library for encoding/decoding the ASN.1 BER
@@ -36,7 +36,7 @@
 Section: libdevel
 Architecture: any
 Multi-Arch: same
-Depends: osmocom-nightly (= 202602191800), ${misc:Depends}
+Depends: osmocom-nightly (= 202602201800), ${misc:Depends}
 Description: Osmocom Remote SIM - Shared Library Development Haders
  libosmo-rsrpo is an utility library for encoding/decoding the ASN.1 BER
  based RSPRO (Remote SIM Protocol) protocol used between the osmo-remsim
@@ -45,7 +45,7 @@
 Package: osmo-remsim-server
 Architecture: any
 Multi-Arch: same
-Depends: osmocom-nightly (= 202602191800), ${shlibs:Depends}, ${misc:Depends}
+Depends: osmocom-nightly (= 202602201800), ${shlibs:Depends}, ${misc:Depends}
 Description: Osmocom Remote SIM - Central Server
  The remsim-server is the central element of a osmo-remsim deployment,
  it maintains a list of clients + bankds connected to it, as well as the
@@ -54,7 +54,7 @@
 Package: osmo-remsim-apitool
 Architecture: any
 Multi-Arch: same
-Depends: osmocom-nightly (= 202602191800), ${misc:Depends}, python3, python3-requests
+Depends: osmocom-nightly (= 202602201800), ${misc:Depends}, python3, python3-requests
 Description: Osmocom Remote SIM - API tool for server
  This is a small python tool for generating API requests to remsim-server,
  which can be used by the system administrator to introspect and/or modify
@@ -63,7 +63,7 @@
 Package: osmo-remsim-bankd
 Architecture: any
 Multi-Arch: same
-Depends: osmocom-nightly (= 202602191800), ${shlibs:Depends}, ${misc:Depends}
+Depends: osmocom-nightly (= 202602201800), ${shlibs:Depends}, ${misc:Depends}
 Description: Osmocom Remote SIM - Bank Daemon
  The remsim-bankd is managing a bank of SIM card readers and their
  respective cards.  It establishes a control connection to remsim-server
@@ -74,7 +74,7 @@
 Breaks: osmo-remsim-client
 Architecture: any
 Multi-Arch: same
-Depends: osmocom-nightly (= 202602191800), ${shlibs:Depends}, ${misc:Depends}
+Depends: osmocom-nightly (= 202602201800), ${shlibs:Depends}, ${misc:Depends}
 Description: Osmocom Remote SIM - Client for SIMtrace2 cardem firmware
  The remsim-client is managing a given phone/modem.  It attaches to the
  'cardem' firmware of a SIMtrcace2 (or compatible, such as sysmoQMOD)
@@ -84,7 +84,7 @@
 Package: osmo-remsim-client-shell
 Architecture: any
 Multi-Arch: same
-Depends: osmocom-nightly (= 202602191800), ${shlibs:Depends}, ${misc:Depends}
+Depends: osmocom-nightly (= 202602201800), ${shlibs:Depends}, ${misc:Depends}
 Description: Osmocom Remote SIM - Interactive Client
  The remsim-client-shell is for manually interacting with a remote SIM
  card via remsim-bankd + remsim-server.  It's mostly a test/debug tool.
@@ -92,7 +92,7 @@
 Package: libifd-osmo-remsim-client0
 Architecture: any
 Multi-Arch: same
-Depends: osmocom-nightly (= 202602191800), pcscd, ${shlibs:Depends}, ${misc:Depends}
+Depends: osmocom-nightly (= 202602201800), pcscd, ${shlibs:Depends}, ${misc:Depends}
 Provides: pcsc-ifd-handler
 Suggests: pcsc-tools
 Description: Osmocom Remote SIM Client - PC/SC driver
@@ -104,6 +104,6 @@
 Architecture: all
 Section: doc
 Priority: optional
-Depends: osmocom-nightly (= 202602191800), ${misc:Depends}
+Depends: osmocom-nightly (= 202602201800), ${misc:Depends}
 Description: Osmocom Remote SIM documentation
  User manual for Osmocom Remote SIM in PDF format.

osmo-remsim_1.1.2.1.90c8.202602191800.tar.gz/src/server/rspro_server.c -> osmo-remsim_1.1.3.202602201800.tar.gz/src/server/rspro_server.c Changed

@@ -763,18 +763,21 @@
 {
 	struct rspro_client_conn *conn = osmo_stream_srv_get_data(peer);
 	OSMO_ASSERT(conn);
+
 	osmo_stream_srv_set_data(peer, NULL);
 	if (conn->ka_fi) {
 		osmo_ipa_ka_fsm_stop(conn->ka_fi);
 		osmo_ipa_ka_fsm_free(conn->ka_fi);
 		conn->ka_fi = NULL;
 	}
-	if (conn->fi) {
-		if (conn->peer) {
-			conn->peer = NULL;
+
+	if (conn->peer) {
+		conn->peer = NULL;
+		if (conn->fi)
 			osmo_fsm_inst_dispatch(conn->fi, CLNTC_E_TCP_DOWN, NULL);
-		} /* else: rspro conn is already being destroyed, do nothing. */
 	}
+	/* else: rspro conn is already being destroyed, do nothing. */
+
 	return 0;
 }
 
@@ -920,13 +923,13 @@
 /* only to be used by the FSM cleanup. */
 static void rspro_client_conn_destroy(struct rspro_client_conn *conn)
 {
-	/* this will internally call closed_cb() which will dispatch a TCP_DOWN event */
+	/* only the FSM should call this in the clean up, when conn->fi is already NULL */
+	OSMO_ASSERT(conn->fi == NULL);
+
 	if (conn->peer) {
 		struct osmo_stream_srv *peer = conn->peer;
-		conn->peer = NULL;
 		osmo_stream_srv_destroy(peer);
-		return;
-	} /* else: destroy initiated by conn->peer's closed_cb(). */
+	}
 
 	/* ensure all slotmaps are unlinked + returned to NEW or deleted */
 	slotmaps_wrlock(conn->srv->slotmaps);

Changes of Revision 1338